Bug#523671: qa.debian.org: wrong policy version
On Sat, 11 Apr 2009, Adeodato Simó wrote: The PTS should enhance the check to do, if possible, a version We lack the version comparison code in XSLT unfortunately. So it's not feasible right now. It's a simple string comparison and we rely on having the latest version in the stylesheet. Cheers, -- Raphaël Hertzog Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny : http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#523671: qa.debian.org: wrong policy version
+ Raphael Hertzog (Sun, 12 Apr 2009 11:29:35 +0200): Hello, On Sat, 11 Apr 2009, Adeodato Simó wrote: The PTS should enhance the check to do, if possible, a version We lack the version comparison code in XSLT unfortunately. So it's not feasible right now. It's a simple string comparison and we rely on having the latest version in the stylesheet. When you say, a “string comparison”, you mean a comparison for equality, I guess. Does XSLT offer at all the concept of strcmp()? I think that alone would be preferable if it’s not a full-fledged version comparison check: the Policy version numbers are simple enough that it should work, and it can be deactivated if this statement stops being true at some point in the future. Only, I don’t know if strcmp() is available or not. :-) -- - Are you sure we're good? - Always. -- Rory and Lorelai -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#523671: qa.debian.org: wrong policy version
On Sun, 12 Apr 2009, Adeodato Simó wrote: When you say, a “string comparison”, you mean a comparison for equality, I guess. Does XSLT offer at all the concept of strcmp()? I think that No it's simply this: xsl:if test=standards-version!='' and not(starts-with(standards-version, $lastsv)) and $lastv is currently hardcoded but could be fed from the script that calls it. Cheers, -- Raphaël Hertzog Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny : http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#523671: qa.debian.org: wrong policy version
On Sun, Apr 12, 2009 at 11:29:35AM +0200, Raphael Hertzog wrote: On Sat, 11 Apr 2009, Adeodato Simó wrote: The PTS should enhance the check to do, if possible, a version We lack the version comparison code in XSLT unfortunately. So it's not feasible right now. It's a simple string comparison and we rely on having the latest version in the stylesheet. And if a proper string comparison will pe possible some time it should still warn about a policy version which is too high. If I upload a package now with standards-version 4.0.0 the PTS should definitely warn about it, too, imho (and not simply suggest a downgrade of course :)). Hauke signature.asc Description: Digital signature
Bug#523671: qa.debian.org: wrong policy version
+ Jan Hauke Rahm (Sun, 12 Apr 2009 13:12:26 +0200): On Sun, Apr 12, 2009 at 11:29:35AM +0200, Raphael Hertzog wrote: On Sat, 11 Apr 2009, Adeodato Simó wrote: The PTS should enhance the check to do, if possible, a version We lack the version comparison code in XSLT unfortunately. So it's not feasible right now. It's a simple string comparison and we rely on having the latest version in the stylesheet. And if a proper string comparison will pe possible some time it should still warn about a policy version which is too high. If I upload a package now with standards-version 4.0.0 the PTS should definitely warn about it, too, imho (and not simply suggest a downgrade of course :)). That’s a fair observation, though I’m expecting lintian will surely warn in that case. If the PTS starts making checks rather than mentioning simple TODO actions... OTOH, it is also true that if the PTS is going to be always using the latest Policy version number available without need for manual updates (see #522434), improving the comparison code becomes somewhat less relevant, I’ll reckon. Thanks for bringing that up. -- - Are you sure we're good? - Always. -- Rory and Lorelai -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#523671: qa.debian.org: wrong policy version
Jan Hauke Rahm wrote: [...] And if a proper string comparison will pe possible some time it should still warn about a policy version which is too high. If I upload a package now with standards-version 4.0.0 the PTS should definitely warn about it, too, imho (and not simply suggest a downgrade of course :)). Already checked by lintian: E: asedriveiiie source: invalid-standards-version 3.6.3 W: csound-doc source: timewarp-standards-version (2004-01-26 2008-06-04) $ lintian-info -t invalid-standards-version timewarp-standards-version N: invalid-standards-version N: N: The source package refers to a Standards-Version which never existed. N: Please update your package to latest Policy and set this control field N: appropriately. N: N: Severity: important, Certainty: certain N: N: timewarp-standards-version N: N: The source package refers to a Standards-Version that was released N: after the date of the most recent debian/changelog entry. Perhaps you N: forgot to update the timestamp in debian/changelog before building the N: package? N: N: Severity: normal, Certainty: certain N: Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#523671: qa.debian.org: wrong policy version
On Sun, Apr 12, 2009 at 12:16:24PM -0500, Raphael Geissert wrote: Jan Hauke Rahm wrote: [...] And if a proper string comparison will pe possible some time it should still warn about a policy version which is too high. If I upload a package now with standards-version 4.0.0 the PTS should definitely warn about it, too, imho (and not simply suggest a downgrade of course :)). Already checked by lintian: E: asedriveiiie source: invalid-standards-version 3.6.3 W: csound-doc source: timewarp-standards-version (2004-01-26 2008-06-04) ...which implies that people always check their packages properly.[1] But as Dato already correctly pointed out, PTS is not the right place for checks like that. My point was just that *if* there is any complex version comparison *then* it should also deal with timewarp-standards-versions. [1] People building packages in a chroot and checking them with lintian from testing (or even ubuntu) would see that 3.7.3 is outdated and they should update to 3.8.0. Then they remember some mail on d-d-a but don't remember the version... was it 3.8.1 or 3.9.0? ah, wth I just take 3.9.0. Sure, this is a bad mistake but people... :) signature.asc Description: Digital signature
Bug#523671: qa.debian.org: wrong policy version
Package: qa.debian.org Severity: normal http://packages.qa.debian.org/m/mksh.html tells me to… │ Todo │ * The package should be updated to follow the last version of [29]Debian Policy (Standards-Version │ 3.8.0 instead of 3.8.1). I think that’d be a downgrade ☺ -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-1-xen-amd64 (SMP w/1 CPU core) Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/mksh -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#523671: qa.debian.org: wrong policy version
reopen 523671 thanks + Sandro Tosi (Sat, 11 Apr 2009 21:22:47 +0200): Hello, Sandro, Thorsten. That Policy version information on PTS was updated this morning, so it might take some time to propagate, and to show up correctly. That’s not really the point. Take a package like minirok; the PTS says: | The package should be updated to follow the last version of Debian | Policy (Standards-Version 3.8.0 instead of 3.7.3). So that’s fine, it tells me I should be using 3.8.0 instead of 3.7.3. However, the submitter was reading: | The package should be updated to follow the last version of Debian | Policy (Standards-Version 3.8.0 instead of 3.8.1). Because his package had been updated already whilst the PTS still didn’t know of this new version. The bug is not that the PTS does not know about 3.8.1; the bug is that it suggest using 3.8.0 over 3.8.1, which is clearly a downgrade. The PTS should enhance the check to do, if possible, a version comparison between the Standards-Version field in the package, and the latest Policy version known, and only emit the warning if S-V is older, and not always they’re different (which seems to be the case judging by the observed behavior). Thanks, -- - Are you sure we're good? - Always. -- Rory and Lorelai -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
