Bug#526530: ggz-server: FTBFS: redefinition of 'struct flock'

2009-11-29 Thread Michael Banck
tags 526530 +pending
thanks

Hi,

I am shortly going to NMU with the attached interdiff.


Cheers,

Michael
diff -u ggz-server-0.0.14.1/debian/changelog 
ggz-server-0.0.14.1/debian/changelog
--- ggz-server-0.0.14.1/debian/changelog
+++ ggz-server-0.0.14.1/debian/changelog
@@ -1,3 +1,12 @@
+ggz-server (0.0.14.1-1.3) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * debian/patches/inotify.diff: New patch switching to C library inotify
+interface from the Linux kernel interface, taken from upstream revision
+10564 (Closes: #526530) 
+
+ -- Michael Banck mba...@debian.org  Sun, 29 Nov 2009 12:34:31 +0100
+
 ggz-server (0.0.14.1-1.2) unstable; urgency=low
 
   * Non-maintainer upload.
only in patch2:
unchanged:
--- ggz-server-0.0.14.1.orig/debian/patches/inotify.diff
+++ ggz-server-0.0.14.1/debian/patches/inotify.diff
@@ -0,0 +1,192 @@
+diff -Naur ggz-server-0.0.14.1.orig/ggzd/control.c 
ggz-server-0.0.14.1/ggzd/control.c
+--- ggz-server-0.0.14.1.orig/ggzd/control.c2008-01-05 20:03:09.0 
+0100
 ggz-server-0.0.14.1/ggzd/control.c 2009-11-29 12:24:56.380983643 +0100
+@@ -60,13 +60,13 @@
+ #include motd.h
+ #include parse_opt.h
+ #include players.h
+-#include reconfiguration.h
+ #include room.h
+ #include table.h
+ #include util.h
+ #include meta.h
+ 
+ #ifdef HAVE_INOTIFY
++#include sys/inotify.h
+ #include sys/ioctl.h
+ #endif
+ #ifdef WITH_FAM
+@@ -78,6 +78,10 @@
+ #define HOST_NAME_MAX 256
+ #endif
+ 
++#ifdef HAVE_INOTIFY
++#define INOTIFY_EVENTSIZE sizeof(struct inotify_event)
++#endif
++
+ /* Server options */
+ Options opt;
+ 
+diff -Naur ggz-server-0.0.14.1.orig/ggzd/Makefile.am 
ggz-server-0.0.14.1/ggzd/Makefile.am
+--- ggz-server-0.0.14.1.orig/ggzd/Makefile.am  2008-02-14 19:04:42.0 
+0100
 ggz-server-0.0.14.1/ggzd/Makefile.am   2009-11-29 12:24:56.384983036 
+0100
+@@ -39,7 +39,6 @@
+   motd.h \
+   net.c \
+   net.h \
+-  reconfiguration.h \
+   room.c \
+   room.h \
+   stats.c \
+diff -Naur ggz-server-0.0.14.1.orig/ggzd/reconfiguration.h 
ggz-server-0.0.14.1/ggzd/reconfiguration.h
+--- ggz-server-0.0.14.1.orig/ggzd/reconfiguration.h2008-01-05 
20:03:09.0 +0100
 ggz-server-0.0.14.1/ggzd/reconfiguration.h 1970-01-01 01:00:00.0 
+0100
+@@ -1,135 +0,0 @@
+-/*
+- * File: reconfiguration.h
+- * Author: GGZ Development Team
+- * Project: GGZ Server
+- * Date: 2006-05-29 
+- * Desc: Tools for dynamic reconfiguration of the server
+- * $Id: reconfiguration.h 8467 2006-08-04 01:58:46Z jdorje $
+- *
+- * Copyright (C) 2006 GGZ Development Team
+- *
+- * This program is free software; you can redistribute it and/or modify
+- * it under the terms of the GNU General Public License as published by
+- * the Free Software Foundation; either version 2 of the License, or
+- * (at your option) any later version.
+- *
+- * This program is distributed in the hope that it will be useful,
+- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+- * GNU General Public License for more details.
+- *
+- * You should have received a copy of the GNU General Public License
+- * along with this program; if not, write to the Free Software
+- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
+- */
+-
+-#ifndef _GGZ_RECONFIGURATION_H
+-#define _GGZ_RECONFIGURATION_H
+-
+-#ifdef HAVE_INOTIFY
+-
+-#include linux/inotify.h
+-
+-/*#define IN_CREATE  0x0100*/
+-#define IN_DELETE  0x0200
+-#define IN_CLOSE_WRITE 0x0008
+-
+-#define INOTIFY_EVENTSIZE sizeof(struct inotify_event)
+-
+-#define __u32 unsigned int
+-
+-/* now mostly stolen from the Linux::Inotify2 perl module */
+-/* this should eventually be available from glibc but isn't yet */
+-
+-#include sys/syscall.h
+-
+-#if defined(__i386__)
+-# define __NR_inotify_init291
+-# define __NR_inotify_add_watch   292
+-# define __NR_inotify_rm_watch293
+-#elif defined(__x86_64__)
+-# define __NR_inotify_init253
+-# define __NR_inotify_add_watch   254
+-# define __NR_inotify_rm_watch255
+-#elif defined(__powerpc__) || defined(__powerpc64__)
+-# define __NR_inotify_init275
+-# define __NR_inotify_add_watch   276
+-# define __NR_inotify_rm_watch277
+-#elif defined (__ia64__)
+-# define __NR_inotify_init1277
+-# define __NR_inotify_add_watch   1278
+-# define __NR_inotify_rm_watch1279
+-#elif defined (__s390__)
+-# define __NR_inotify_init284
+-# define __NR_inotify_add_watch   285
+-# define __NR_inotify_rm_watch286
+-#elif defined (__alpha__)
+-# define __NR_inotify_init444
+-# define __NR_inotify_add_watch   445
+-# define __NR_inotify_rm_watch446
+-#elif defined (__sparc__) || defined (__sparc64__)
+-# define __NR_inotify_init151
+-# define __NR_inotify_add_watch   152
+-# define __NR_inotify_rm_watch156
+-#elif defined (__arm__)
+-# define __NR_inotify_init  

Bug#526530: ggz-server: FTBFS: redefinition of 'struct flock'

2009-06-10 Thread Daniel Schepler
I have to wonder why ggz-server is using linux/inotify.h directly in the first 
place.  If I replace that with sys/inotify.h, and remove the duplicate 
definitions of inotify_* in reconfiguration.h, the package builds just fine 
here.
-- 
Daniel Schepler




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#526530: ggz-server: FTBFS: redefinition of 'struct flock'

2009-05-03 Thread Josef Spillner
Am Freitag, 1. Mai 2009 21:53:50 schrieb Daniel Schepler:
 In file included from /usr/include/asm/fcntl.h:1,
  from /usr/include/linux/fcntl.h:4,
  from /usr/include/linux/inotify.h:11,
  from reconfiguration.h:31,
  from control.c:63:
 /usr/include/asm-generic/fcntl.h:117: error: redefinition of 'struct flock'
 /usr/include/asm-generic/fcntl.h:140: error: redefinition of 'struct

We need to include the following patch into the source package:

http://svn.ggzgamingzone.org/trac.cgi/changeset/10564

Or (as recommended in general) update all source packages with the latest 
diffs:

http://hq.ggzgamingzone.org/~josef/diffs/0.0.14.1/

Josef

-- 
Free online games for everybody: http://www.ggzgamingzone.org/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#526530: ggz-server: FTBFS: redefinition of 'struct flock'

2009-05-01 Thread Daniel Schepler
Package: ggz-server
Version: 0.0.14.1-1.2
Severity: serious

From my pbuilder build log:

...
cc -DHAVE_CONFIG_H -I. -I..  -I../ggzd/database -I../ggzd/meta -I../ggzdmod -I 
/usr/include  -I/usr/include -DGGZDCONFDIR=\/etc/ggzd\ 
-DGGZDSTATEDIR=\/var/lib/ggzd\ -DGGZDEXECMODDIR=\/usr/lib/ggzd\ -I 
/usr/include -I 
/usr/local/include -DGGZDDATADIR=\/usr/share/ggz/ggzd\  -g -O2 -g -Wall -O2 
-D_REENTRANT -c -o ggzd-control.o `test -f 'control.c' || echo './'`control.c
In file included from /usr/include/asm/fcntl.h:1,
 from /usr/include/linux/fcntl.h:4,
 from /usr/include/linux/inotify.h:11,
 from reconfiguration.h:31,
 from control.c:63:
/usr/include/asm-generic/fcntl.h:117: error: redefinition of 'struct flock'
/usr/include/asm-generic/fcntl.h:140: error: redefinition of 'struct flock64'
make[4]: *** [ggzd-control.o] Error 1
make[4]: Leaving directory `/tmp/buildd/ggz-server-0.0.14.1/ggzd'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/buildd/ggz-server-0.0.14.1/ggzd'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/ggz-server-0.0.14.1'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/ggz-server-0.0.14.1'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
-- 
Daniel Schepler




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org