Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-20 Thread Hendrik Sattler
Am Freitag 19 Juni 2009 23:33:03 schrieb Filippo Giunchedi:
 On Sun, May 24, 2009 at 01:49:01PM +0200, Filippo Giunchedi wrote:
  On Sun, May 24, 2009 at 01:23:02PM +0200, Hendrik Sattler wrote:
   I will fix the build-depend but will not include the patch because
   either that function is still available (and works) or the name of the
   -dev package needs to change.
 
  I'm not sure what you mean, libbluetooth-dev right now is 4.40 which has
  headers for libbluetooth3 so I don't see what needs to be changed.

 is there any update on this bug?

Same as with obexfs, this is in the queue. Didn't get around asking someone 
for upload, yet.
It is available at
http://www.hendrik-sattler.de/debian/pool/main/ussp-push/ussp-push_0.11-1.dsc

HS

PS: At one time, I will initiate collaborative obex maintainance.




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-20 Thread Filippo Giunchedi
On Sat, Jun 20, 2009 at 12:04:39PM +0200, Hendrik Sattler wrote:
   I'm not sure what you mean, libbluetooth-dev right now is 4.40 which has
   headers for libbluetooth3 so I don't see what needs to be changed.
 
  is there any update on this bug?
 
 Same as with obexfs, this is in the queue. Didn't get around asking someone 
 for upload, yet.
 It is available at
 http://www.hendrik-sattler.de/debian/pool/main/ussp-push/ussp-push_0.11-1.dsc

the call to hci_remote_name instead of hci_read_remote_name is still there:

/tmp/buildd/ussp-push-0.11/src/obex_socket.c: In function 'bt_sock_name2bth':
/tmp/buildd/ussp-push-0.11/src/obex_socket.c:200: warning: implicit declaration 
of function 'hci_remote_name'

thanks for the dgettable-url :)

filippo
--
Filippo Giunchedi - http://esaurito.net - 0x6B79D401

I find television very educating. Every time somebody turns on the
set, I go into the other room and read a book.
-- Groucho Marx



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-20 Thread Hendrik Sattler
Am Samstag 20 Juni 2009 12:48:40 schrieb Filippo Giunchedi:
 On Sat, Jun 20, 2009 at 12:04:39PM +0200, Hendrik Sattler wrote:
I'm not sure what you mean, libbluetooth-dev right now is 4.40 which
has headers for libbluetooth3 so I don't see what needs to be
changed.
  
   is there any update on this bug?
 
  Same as with obexfs, this is in the queue. Didn't get around asking
  someone for upload, yet.
  It is available at
  http://www.hendrik-sattler.de/debian/pool/main/ussp-push/ussp-push_0.11-1
 .dsc

 the call to hci_remote_name instead of hci_read_remote_name is still there:

 /tmp/buildd/ussp-push-0.11/src/obex_socket.c: In function
 'bt_sock_name2bth': /tmp/buildd/ussp-push-0.11/src/obex_socket.c:200:
 warning: implicit declaration of function 'hci_remote_name'

Hm, no. You cannot change the API without change the name of the -dev package. 
This is an absolute no-go!

And not having hci_remote_name() in bluetooth/hci_lib.h anymore _IS_ an API 
change.

You cannot have  both: either provide a compatible API or change the name of 
the -dev package.

HS




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-20 Thread Filippo Giunchedi
On Sat, Jun 20, 2009 at 01:32:13PM +0200, Hendrik Sattler wrote:
 Am Samstag 20 Juni 2009 12:48:40 schrieb Filippo Giunchedi:
  On Sat, Jun 20, 2009 at 12:04:39PM +0200, Hendrik Sattler wrote:
 I'm not sure what you mean, libbluetooth-dev right now is 4.40 which
 has headers for libbluetooth3 so I don't see what needs to be
 changed.
   
is there any update on this bug?
  
   Same as with obexfs, this is in the queue. Didn't get around asking
   someone for upload, yet.
   It is available at
   http://www.hendrik-sattler.de/debian/pool/main/ussp-push/ussp-push_0.11-1
  .dsc
 
  the call to hci_remote_name instead of hci_read_remote_name is still there:
 
  /tmp/buildd/ussp-push-0.11/src/obex_socket.c: In function
  'bt_sock_name2bth': /tmp/buildd/ussp-push-0.11/src/obex_socket.c:200:
  warning: implicit declaration of function 'hci_remote_name'
 
 Hm, no. You cannot change the API without change the name of the -dev 
 package. 
 This is an absolute no-go!
 
 And not having hci_remote_name() in bluetooth/hci_lib.h anymore _IS_ an API 
 change.

of course it is, that's what all this bug is about. bluez 4 has entered unstable
and together with libbluetooth3 (which has the soname bumped as required)

The -dev renaming has happened in March 2007 switching from libbluetooth2-dev to
libbluetooth-dev as the bluetooth API doesn't change often and there's no need
to support two different version at the same time.

Also, hci_local_name and hci_remote_name functions have been deprecated in
August 2008 and they were in the library as defined below since Jan 2005:

int hci_local_name(int dd, int len, char *name, int to)
{
   return hci_read_local_name(dd, len, name, to);
}

int hci_remote_name(int dd, const bdaddr_t *bdaddr, int len, char *name, int to)
{
   return hci_read_remote_name(dd, bdaddr, len, name, to);
}

so I don't really see the problem here.

filippo
--
Filippo Giunchedi - http://esaurito.net - 0x6B79D401

I always keep the Titanic in mind when I talk about security or
safety, meaning that nothing is fully secure.
-- Anonymous (?)



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-20 Thread Luk Claes
Hendrik Sattler wrote:
 Am Samstag 20 Juni 2009 12:48:40 schrieb Filippo Giunchedi:
 On Sat, Jun 20, 2009 at 12:04:39PM +0200, Hendrik Sattler wrote:
 I'm not sure what you mean, libbluetooth-dev right now is 4.40 which
 has headers for libbluetooth3 so I don't see what needs to be
 changed.
 is there any update on this bug?
 Same as with obexfs, this is in the queue. Didn't get around asking
 someone for upload, yet.
 It is available at
 http://www.hendrik-sattler.de/debian/pool/main/ussp-push/ussp-push_0.11-1
 .dsc
 the call to hci_remote_name instead of hci_read_remote_name is still there:

 /tmp/buildd/ussp-push-0.11/src/obex_socket.c: In function
 'bt_sock_name2bth': /tmp/buildd/ussp-push-0.11/src/obex_socket.c:200:
 warning: implicit declaration of function 'hci_remote_name'
 
 Hm, no. You cannot change the API without change the name of the -dev 
 package. 
 This is an absolute no-go!
 
 And not having hci_remote_name() in bluetooth/hci_lib.h anymore _IS_ an API 
 change.
 
 You cannot have  both: either provide a compatible API or change the name of 
 the -dev package.

In general you are right. Though it was already deprecated to use this
function and your package is the only one still using it AFAIK. There
are no other API changes AFAIK.

Cheers

Luk



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-20 Thread Hendrik Sattler
Am Samstag 20 Juni 2009 12:48:40 schrieb Filippo Giunchedi:
 On Sat, Jun 20, 2009 at 12:04:39PM +0200, Hendrik Sattler wrote:
I'm not sure what you mean, libbluetooth-dev right now is 4.40 which
has headers for libbluetooth3 so I don't see what needs to be
changed.
  
   is there any update on this bug?
 
  Same as with obexfs, this is in the queue. Didn't get around asking
  someone for upload, yet.
  It is available at
  http://www.hendrik-sattler.de/debian/pool/main/ussp-push/ussp-push_0.11-1
 .dsc

 the call to hci_remote_name instead of hci_read_remote_name is still there:

 /tmp/buildd/ussp-push-0.11/src/obex_socket.c: In function
 'bt_sock_name2bth': /tmp/buildd/ussp-push-0.11/src/obex_socket.c:200:
 warning: implicit declaration of function 'hci_remote_name'

 thanks for the dgettable-url :)

Fixed now. Same location.

Thanks

HS




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-06-19 Thread Filippo Giunchedi
On Sun, May 24, 2009 at 01:49:01PM +0200, Filippo Giunchedi wrote:
 On Sun, May 24, 2009 at 01:23:02PM +0200, Hendrik Sattler wrote:
  I will fix the build-depend but will not include the patch because either 
  that 
  function is still available (and works) or the name of the -dev package 
  needs 
  to change.
 
 I'm not sure what you mean, libbluetooth-dev right now is 4.40 which has 
 headers
 for libbluetooth3 so I don't see what needs to be changed.

is there any update on this bug?

filippo
--
Filippo Giunchedi - http://esaurito.net - 0x6B79D401

A mathematician is a device for turning coffee into theorems.
-- Paul Erdos



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-05-24 Thread Filippo Giunchedi
Package: ussp-push
Version: 0.9-2
User: fili...@debian.org
Usertags: bluez4-transition

Hi,
your package seems to build-depend on libbluetooth2-dev, however it has been
deprecated in favour of versionless libbluetooth-dev, please update.

Also, building the package I found that it makes uses of a deprecated function
in libbluetooth3, the following trivial patch fixes it:

--- ussp-push-0.9.orig/obex_socket.c2006-03-09 22:01:12.0 +0100
+++ ussp-push-0.9/obex_socket.c 2009-05-24 12:54:00.0 +0200
@@ -197,7 +197,7 @@
for (i = 0; i  niinf; i++) {
char devname[128];
 
-   if (hci_remote_name(dd, piinf[i].bdaddr, sizeof(devname) - 1,
+   if (hci_read_remote_name(dd, piinf[i].bdaddr, sizeof(devname) 
- 1,
devname, 10) = 0) {
if (strcasecmp(devname, btname) == 0) {
*btaddr = piinf[i].bdaddr;

thanks,
filippo



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-05-24 Thread Hendrik Sattler
Am Sonntag 24 Mai 2009 12:59:32 schrieb Filippo Giunchedi:
 Package: ussp-push
 Version: 0.9-2
 User: fili...@debian.org
 Usertags: bluez4-transition

 Hi,
 your package seems to build-depend on libbluetooth2-dev, however it has
 been deprecated in favour of versionless libbluetooth-dev, please update.

 Also, building the package I found that it makes uses of a deprecated
 function in libbluetooth3, the following trivial patch fixes it:

 --- ussp-push-0.9.orig/obex_socket.c  2006-03-09 22:01:12.0 +0100
 +++ ussp-push-0.9/obex_socket.c   2009-05-24 12:54:00.0 +0200
 @@ -197,7 +197,7 @@
   for (i = 0; i  niinf; i++) {
   char devname[128];

 - if (hci_remote_name(dd, piinf[i].bdaddr, sizeof(devname) - 1,
 + if (hci_read_remote_name(dd, piinf[i].bdaddr, sizeof(devname) 
 - 1,
   devname, 10) = 0) {
   if (strcasecmp(devname, btname) == 0) {
   *btaddr = piinf[i].bdaddr;

I will fix the build-depend but will not include the patch because either that 
function is still available (and works) or the name of the -dev package needs 
to change.

HS




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530359: ussp-push: transition from libbluetooth2-dev to libbluetooth-dev and use of hci_remote_name

2009-05-24 Thread Filippo Giunchedi
On Sun, May 24, 2009 at 01:23:02PM +0200, Hendrik Sattler wrote:
 I will fix the build-depend but will not include the patch because either 
 that 
 function is still available (and works) or the name of the -dev package needs 
 to change.

I'm not sure what you mean, libbluetooth-dev right now is 4.40 which has headers
for libbluetooth3 so I don't see what needs to be changed.

filippo
--
Filippo Giunchedi - http://esaurito.net - 0x6B79D401

Odium turbae sanabit solitudo, taedium solitudinis turba.
Solitude will cure our hatred of the crowd,
the crowd will cure our disgust with solitude.
-- Seneca, De Tranquillitate Animi



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org