Bug#532381: -doc dependencies on haddock
Hi. Em Ter, 2009-06-16 às 15:47 +0200, Joachim Breitner escreveu: (...) > Am Dienstag, den 16.06.2009, 08:40 -0300 schrieb Marco Túlio Gontijo e > Silva: > > Em Ter, 2009-06-09 às 00:48 +0200, Joachim Breitner escreveu: > > (...) > > > at the moment, if you put > > > Depends: ${haskell:Depends} > > > in debian/control for the -doc package stanza, dh_haskell_prep will add > > > this line: > > > Depends: haddock (<< 2.4.2+), haddock (>= 2.4.2) (...) > > I could not found where the code about this was: > > > > mar...@zezinho:~/codigo/debian/haskell-devscripts/haskell-devscripts$ > > grep doc $(grep -l haskell:Depends * | grep -v \.pod) > > dh_haskell_depends:#disclaimer in the documentation and/or other > > materials provided (...) > The relevant code is in dh_haskell_prep, line 60. Thanks, sorry about that. The new package is available at http://debian.holoscopio.com/haskell-devscripts/ . Good afternoon. -- marcot http://marcot.iaaeee.org/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#532381: -doc dependencies on haddock
Hi Marco, Am Dienstag, den 16.06.2009, 08:40 -0300 schrieb Marco Túlio Gontijo e Silva: > Em Ter, 2009-06-09 às 00:48 +0200, Joachim Breitner escreveu: > (...) > > Hi, > > > > at the moment, if you put > > Depends: ${haskell:Depends} > > in debian/control for the -doc package stanza, dh_haskell_prep will add > > this line: > > Depends: haddock (<< 2.4.2+), haddock (>= 2.4.2) > > At first I could not found where the code about this was: > > mar...@zezinho:~/codigo/debian/haskell-devscripts/haskell-devscripts$ > grep doc $(grep -l haskell:Depends * | grep -v \.pod) > dh_haskell_depends:#disclaimer in the documentation and/or other > materials provided > > Then I tryed to reproduce it with haskell-ghc-paths, and I couldn't: > > mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ tail -13 > ghc-paths-0.1.0.5/debian/control > Package: libghc6-ghc-paths-doc > Section: doc > Architecture: all > Depends: ${misc:Depends}, ${haskell:Depends} > Recommends: ghc6-doc > Suggests: libghc6-ghc-paths-dev (= ${binary:Version}) > Description: Knowledge of GHC's installation directories; documentation > This package provides the documentation for a library for the Haskell > programming language. > See http://www.haskell.org/ for more information on Haskell. > . > This package provides constants with the installation directories of > the > Glasgow Haskell Compiler. > mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ ar -x > libghc6-ghc-paths-doc_0.1.0.5-1_all.deb > mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ tar xzf > control.tar.gz > mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ grep Depends > control > mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ > > There's no dependency in the -doc generated package. Can you reproduce > it? strange. I did reproduce it, as can seen on http://packages.debian.org/sid/haskell-convertible-doc. Note that haskell-convertible does not use hlibrary.make, but rather a debian/rules on it’s own. hlibrary.make does not call _prep or _depends for -doc packages, which should probably be changed, once we add sensible Recommends: or Suggests: there. The relevant code is in dh_haskell_prep, line 60. I hope that gets you on the right tracks. Greetings, Joachim PS: Once my patch in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=532760 is merged, such issues (substvars forgotten in debian/rules) will probably turn up earlier. Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Bug#532381: -doc dependencies on haddock
Hi. Em Ter, 2009-06-09 às 00:48 +0200, Joachim Breitner escreveu: (...) > Hi, > > at the moment, if you put > Depends: ${haskell:Depends} > in debian/control for the -doc package stanza, dh_haskell_prep will add > this line: > Depends: haddock (<< 2.4.2+), haddock (>= 2.4.2) At first I could not found where the code about this was: mar...@zezinho:~/codigo/debian/haskell-devscripts/haskell-devscripts$ grep doc $(grep -l haskell:Depends * | grep -v \.pod) dh_haskell_depends:#disclaimer in the documentation and/or other materials provided Then I tryed to reproduce it with haskell-ghc-paths, and I couldn't: mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ tail -13 ghc-paths-0.1.0.5/debian/control Package: libghc6-ghc-paths-doc Section: doc Architecture: all Depends: ${misc:Depends}, ${haskell:Depends} Recommends: ghc6-doc Suggests: libghc6-ghc-paths-dev (= ${binary:Version}) Description: Knowledge of GHC's installation directories; documentation This package provides the documentation for a library for the Haskell programming language. See http://www.haskell.org/ for more information on Haskell. . This package provides constants with the installation directories of the Glasgow Haskell Compiler. mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ ar -x libghc6-ghc-paths-doc_0.1.0.5-1_all.deb mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ tar xzf control.tar.gz mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ grep Depends control mar...@zezinho:~/codigo/debian/haskell-ghc-paths/build$ There's no dependency in the -doc generated package. Can you reproduce it? Greetings. -- marcot http://marcot.iaaeee.org/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#532381: -doc dependencies on haddock
Hi, Am Donnerstag, den 11.06.2009, 08:59 -0300 schrieb Marco Túlio Gontijo e Silva: > > Recommending ghc-doc is probably ok. Also, recommending the -doc of any > > dependency could be useful (for the links). Bonus: Only depend on those > > that are actually linked to. > > The way I thought for doing this is searching with dpkg -S for a package > with the files linked. This would have to be done in > dh_haskell_depends, since dh_haskell_prep is called before build. One > problem of this is that dh_haskell_depends is a shell script, and > getting the links of a HTML file would be easier to do in Perl than in > shell. Do you know about some program that extract the links of a HTML > file, that could be used in dh_haskell_depends? $ LANG=C lynx -dump -listonly /usr/share/doc/libghc6-xmonad-doc/html/XMonad-ManageHook.html|head -n 10 References 1. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/src/XMonad-ManageHook.html 2. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/index.html 3. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/doc-index.html 4. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/XMonad-ManageHook.html#v%3AliftX 5. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/XMonad-Core.html#t%3AX 6. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/XMonad-Core.html#t%3AQuery 7. file://localhost/usr/share/doc/libghc6-xmonad-doc/html/XMonad-ManageHook.html#v%3AidHook but there might be better tools. > (...) > > A versioning is useless for Suggests, I > > think. Also, I don’t think that people will need this Suggests at all. > > I think it's good to have the -dev package as a Suggests or Recommends > in the -doc package, since the -doc is, at first, not very useful > without the -dev. What do you think about unversioned Suggests in the > -dev package? > > Suggests: libghc6-package-dev I’m fine with that, as I don’t care too much :-) Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Bug#532381: -doc dependencies on haddock
Hello. Em Qui, 2009-06-11 às 13:09 +0200, Joachim Breitner escreveu: (...) > Am Mittwoch, den 10.06.2009, 15:39 -0700 schrieb David Fox: > > On Wed, Jun 10, 2009 at 2:55 PM, Marco Túlio Gontijo e Silva > > wrote: > > what do you think is the appropriate output? I'd say there's > > no > > dependencies for documentation packages. I usually use: > > > > Recommends: ghc6-doc > > Suggests: libghc6-package-dev (= ${binary:Version}) > > > > Should we create a haskell:Recommends and a haskell:Suggests? (...) > Recommending ghc-doc is probably ok. Also, recommending the -doc of any > dependency could be useful (for the links). Bonus: Only depend on those > that are actually linked to. The way I thought for doing this is searching with dpkg -S for a package with the files linked. This would have to be done in dh_haskell_depends, since dh_haskell_prep is called before build. One problem of this is that dh_haskell_depends is a shell script, and getting the links of a HTML file would be easier to do in Perl than in shell. Do you know about some program that extract the links of a HTML file, that could be used in dh_haskell_depends? (...) > A versioning is useless for Suggests, I > think. Also, I don’t think that people will need this Suggests at all. I think it's good to have the -dev package as a Suggests or Recommends in the -doc package, since the -doc is, at first, not very useful without the -dev. What do you think about unversioned Suggests in the -dev package? Suggests: libghc6-package-dev Greetings. (...) -- marcot http://marcot.iaaeee.org/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#532381: -doc dependencies on haddock
Hi, Am Mittwoch, den 10.06.2009, 15:39 -0700 schrieb David Fox: > On Wed, Jun 10, 2009 at 2:55 PM, Marco Túlio Gontijo e Silva > wrote: > what do you think is the appropriate output? I'd say there's > no > dependencies for documentation packages. I usually use: > > Recommends: ghc6-doc > Suggests: libghc6-package-dev (= ${binary:Version}) > > Should we create a haskell:Recommends and a haskell:Suggests? No Depends in any case for -doc packages. Recommending ghc-doc is probably ok. Also, recommending the -doc of any dependency could be useful (for the links). Bonus: Only depend on those that are actually linked to. Not sure about the Suggests. A versioning is useless for Suggests, I think. Also, I don’t think that people will need this Suggests at all. I wonder why dpkg-gencontrol doesn’t warn or err if there were substvars defined, but not used in debian/control. > The documentation packages use haddock to update the index pages on > install, though this is done via the script, gen_contents_index in > ghc6-doc. In this case shouldn't there be a real dependency on > ghc6-doc, not just a Recommends? Also, up until recently it was the > case that haddock packages had to be installed using the same version > of haddock that they were built with. This has been fixed, but I'm > unclear exactly what versions of what packages you need to have this > fix. Since a while, gen_contents_index is not called by the package post-inst any more, but by a ghc6-doc trigger. This means, that the -doc packages work just fine without ghc6-doc, you just don’t have a index over all packages. Therefore, a Dependency is not needed any more. Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Bug#532381: -doc dependencies on haddock
On Wed, Jun 10, 2009 at 2:55 PM, Marco Túlio Gontijo e Silva < mar...@holoscopio.com> wrote: > Hi. > > Em Ter, 2009-06-09 às 00:48 +0200, Joachim Breitner escreveu: > > at the moment, if you put > > Depends: ${haskell:Depends} > > in debian/control for the -doc package stanza, dh_haskell_prep will add > > this line: > > Depends: haddock (<< 2.4.2+), haddock (>= 2.4.2) > (...) > > I think it’s not an mistake in these packages, but in haskell-devscripts, > > and from reading the code, it just seems to be an accidental artefact. > > what do you think is the appropriate output? I'd say there's no > dependencies for documentation packages. I usually use: > > Recommends: ghc6-doc > Suggests: libghc6-package-dev (= ${binary:Version}) > > Should we create a haskell:Recommends and a haskell:Suggests? > > Greetings. > The documentation packages use haddock to update the index pages on install, though this is done via the script, gen_contents_index in ghc6-doc. In this case shouldn't there be a real dependency on ghc6-doc, not just a Recommends? Also, up until recently it was the case that haddock packages had to be installed using the same version of haddock that they were built with. This has been fixed, but I'm unclear exactly what versions of what packages you need to have this fix. -david
Bug#532381: -doc dependencies on haddock
Hi. Em Ter, 2009-06-09 às 00:48 +0200, Joachim Breitner escreveu: > at the moment, if you put > Depends: ${haskell:Depends} > in debian/control for the -doc package stanza, dh_haskell_prep will add > this line: > Depends: haddock (<< 2.4.2+), haddock (>= 2.4.2) (...) > I think it’s not an mistake in these packages, but in haskell-devscripts, > and from reading the code, it just seems to be an accidental artefact. what do you think is the appropriate output? I'd say there's no dependencies for documentation packages. I usually use: Recommends: ghc6-doc Suggests: libghc6-package-dev (= ${binary:Version}) Should we create a haskell:Recommends and a haskell:Suggests? Greetings. -- marcot http://marcot.iaaeee.org/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#532381: -doc dependencies on haddock
Hello. Em Ter, 2009-06-09 às 00:48 +0200, Joachim Breitner escreveu: > Marco, do you want to prepare a haskell-devscript release that fixes > this, or do you think that you won’t have time soon for that? I'll work on that and make a new version of haskell-devscripts. Sorry for the other one without this fix, I haven't seen this e-mail before. Please discard it. Greetings. -- marcot http://marcot.iaaeee.org/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#532381: -doc dependencies on haddock
Package: haskell-devscripts Version: 0.6.15+nmu10 Severity: normal -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, at the moment, if you put Depends: ${haskell:Depends} in debian/control for the -doc package stanza, dh_haskell_prep will add this line: Depends: haddock (<< 2.4.2+), haddock (>= 2.4.2) This affects these packages: Package: haskell-convertible-doc Depends: haddock (<< 2.4.1+), haddock (>= 2.4.1) Package: haskell-hdbc-doc Depends: haddock (<< 2.4.1+), haddock (>= 2.4.1) Package: haskell-hdbc-postgresql-doc Depends: haskell-hdbc-doc (>= 2.1.0), haddock (<< 2.4.1+), haddock (>= 2.4.1) Package: haskell-hdbc-sqlite3-doc Depends: haddock (<< 2.4.1+), haddock (>= 2.4.1) Package: libghc6-vty-doc Depends: haddock (>= 0.8), haddock (<< 0.8-999) I have done manual a binNMUs for haskell-convertible-doc, but I guess we should fix haskell-devscripts before doing the rest. I think it’s not an mistake in these packages, but in haskell-devscripts, and from reading the code, it just seems to be an accidental artefact. Marco, do you want to prepare a haskell-devscript release that fixes this, or do you think that you won’t have time soon for that? Thanks, Joachim - -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.29-2-amd64 (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages haskell-devscripts depends on: ii cdbs 0.4.56 common build system for Debian pac ii dctrl-tools 2.13.1 Command-line tools to process Debi ii debhelper7.2.14 helper programs for debian/rules ii ghc6 6.10.1+dfsg1-13 GHC - the Glasgow Haskell Compilat ii xutils-dev 1:7.4+4 X Window System utility programs f haskell-devscripts recommends no packages. haskell-devscripts suggests no packages. - -- no debconf information -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkotlTMACgkQ9ijrk0dDIGy0UgCfVC7zeg58xRrc3RW+0UUG39pq oKcAoKSJibN3GAzwxITu8XZvKfudVnNs =mz1l -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org