Bug#535223: make-googleearth-package exits with status 1 when used with, --download

[Adnan Hodzic]

0.7.0 has been released and it also includes your patch, thanks,


Adnan

On Tue, Oct 25, 2011 at 4:56 PM, Laurent Dard f.coupe...@online.fr wrote:
 tag 535223 + patch
 thanks

 $ make-googleearth-package --download
 just doesn't work (and returns 1... what for?)
 I don't understand the changes that have been made.

 Here's another patch.

 --
 Laurent Dard





-- 
Adnan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#535223: make-googleearth-package exits with status 1 when used with, --download

[Laurent Dard]

tag 535223 + patch
thanks

$ make-googleearth-package --download
just doesn't work (and returns 1... what for?)
I don't understand the changes that have been made.

Here's another patch.

-- 
Laurent Dard


--- a/make-googleearth-package
+++ b/make-googleearth-package
@@ -152,14 +152,17 @@
 
 function verify_file_option() {
   if [ $OPT_DOWNLOAD == 1 ]; then
-exit 1
+if ! [ $OPT_FILE == $GoogleEarth_bin ]; then
+  echo WARNING: downloading $GoogleEarth_bin. 2
+  echo WARNING: ignored option: '--file $OPT_FILE' 2
+  OPT_FILE=$GoogleEarth_bin
+fi
+return 1
   elif [ $OPT_FILE == $GoogleEarth_bin ]; then
 [ -e $OPT_FILE ]
-  elif [ $OPT_FILE ]; then
-if [ ! -e $OPT_FILE ]; then
-  echo 'File not found:' '$OPT_FILE' 2
-  exit 1
-fi
+  elif [ ! -e $OPT_FILE ]; then
+echo 'File not found:' '$OPT_FILE' 2
+exit 1
   fi
 }
 

Bug#535223:

[Adnan Hodzic]

I believe this problem has been fixed in 0.6.x could you please try
the latest version and report back if you're still having this
problem.

Thanks,

Adnan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#535223: make-googleearth-package exits with status 1 when used with --download

[aszlig]

Package: googleearth-package
Version: 0.5.6
Severity: minor

hullo,

make-googleearth-package --download just simply exits with status 1,
patch attached =)

thanks in advance for fixing :-)

a!

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-aszlig (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages googleearth-package depends on:
ii  bzip2 1.0.5-3high-quality block-sorting file co
ii  curl  7.19.5-1   Get a file from an HTTP, HTTPS or 
ii  dpkg-dev  1.15.3 Debian package development tools
ii  fakeroot  1.12.2 Gives a fake root environment
ii  file  5.03-1 Determines file type using magic
ii  wget  1.11.4-2   retrieves files from the web
ii  x11-common1:7.4+3X Window System (X.Org) infrastruc
ii  x11-utils 7.4+1  X11 utilities

googleearth-package recommends no packages.

googleearth-package suggests no packages.

-- no debconf information

-- 
aszlig
Universaldilettant
RedMoonStudios
--- a/make-googleearth-package
+++ b/make-googleearth-package
@@ -151,7 +151,7 @@
 
 function verify_file_option() {
   if [ $OPT_DOWNLOAD == 1 ]; then
-exit 1
+return 1
   elif [ $OPT_FILE == $GoogleEarth_bin ]; then
 [ -e $OPT_FILE ]
   elif [ $OPT_FILE ]; then


signature.asc
Description: Digital signature