Bug#537043: in Debian! (vorbisgain: invalid tempfile name (longer than 255 chars))

2014-04-10 Thread G.raud
On Sat, Jan 12, 2013 at 08:59:39PM +0100, Daniel Martí wrote:
> On Fri, Jan 11, 2013 at 01:44:20PM +0100, G.raud wrote:
> > Please remove the patch 0001-temp_files.patch that introduces a bug
> > without fixing anything anymore.
> 
> Thank you for noticing. I will prepare a new version to be pushed to sid
> soon.

Any news on that?  The fix consists only in removing this patch and
refreshing the others (the disabling of code relating to keeping the mtime
is done differently by another patch).

-- 
G.raud


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#537043: in Debian! (vorbisgain: invalid tempfile name (longer than 255 chars))

2013-01-12 Thread Daniel Martí
On Fri, Jan 11, 2013 at 01:44:20PM +0100, G.raud wrote:
> Please remove the patch 0001-temp_files.patch that introduces a bug
> without fixing anything anymore.

Thank you for noticing. I will prepare a new version to be pushed to sid
soon.

-- 
Daniel Martí - mv...@mvdan.cc - GPG 0x58BF72C3


pgpA4Bn07hm5b.pgp
Description: PGP signature


Bug#537043: in Debian! (vorbisgain: invalid tempfile name (longer than 255 chars))

2013-01-11 Thread G.raud
found 537043 0.37-2
tags - upstream
tags + patch
thanks

This bug never existed in upstream, so I untagged upstream.

This bug is still present in the current sid (vorbisgain/0.37-2) but
is changed in behaviour.  vorbisgain does not crash anymore but fails
to open the output file.

$ vorbisgain $(perl -e 'print "A"x236').ogg 
Analyzing files...

   Gain   |  Peak  | Scale | New Peak | Track
--++---+--+--
 -4.47 dB |  34022 |  0.60 |    20336 | 
.ogg
Couldn't open '' for output: No such file or directory

The upstream version does not have this bug:

$ ./vorbisgain $(perl -e 'print "A"x251').ogg
Analyzing files...

   Gain   |  Peak  | Scale | New Peak | Track
--++---+--+--
 -4.47 dB |  34022 |  0.60 |    20336 | 
../AAA.ogg

Upstream has perfectly fixed the problem of the temp filename
uniqueness by using mktemp() in version 0.37, whereas Debian has,
for this version 0.37, updated its previous patch that used to fix the
problem by introducing this bug relating to the size limit!

Please remove the patch 0001-temp_files.patch that introduces a bug
without fixing anything anymore.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org