Bug#538107: multilink with nodetach [Fixed]
Hi, This bug has been resolved in upstream git, and the version in jessie 2.4.5+git20130610-1 includes the fix. Regards, Stephen commit 398ed2585640d198c53e736ee5bbd67f7ce8168e Author: Paul Mackerras pau...@samba.org Date: Sat Mar 2 20:25:28 2013 +1100 pppd: Add master_detach option This adds a new option, master_detach, to allow pppd to detach from the controlling terminal when it is the multilink bundle master but its own link has terminated, even if the nodetach option has been given. Requested-by: Stephen Marron s...@boxfusion.net Signed-off-by: Paul Mackerras pau...@samba.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#538107:
Hi,
The below diff is against upstream git repo
git://git.ozlabs.org/~paulus/ppp.git
on
Tue, 24 Aug 2010 16:44:43 +0930
this patch should be used rather than the previous one
diff --git a/pppd/auth.c b/pppd/auth.c
index fb71944..62648b8 100644
--- a/pppd/auth.c
+++ b/pppd/auth.c
@@ -669,8 +669,11 @@ link_terminated(unit)
(*the_channel-cleanup)();
if (doing_multilink multilink_master) {
- if (!bundle_terminating)
+ if (!bundle_terminating) {
new_phase(PHASE_MASTER);
+ if (!detached)
+ detach();
+ }
else
mp_bundle_terminated();
} else
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#538107: fixed patch
Hi,
The below diff is against upstream git repo
git://git.ozlabs.org/~paulus/ppp.git
on
Tue, 24 Aug 2010 16:44:43 +0930
this patch should be used rather than the previous one
diff --git a/pppd/auth.c b/pppd/auth.c
index fb71944..62648b8 100644
--- a/pppd/auth.c
+++ b/pppd/auth.c
@@ -669,8 +669,11 @@ link_terminated(unit)
(*the_channel-cleanup)();
if (doing_multilink multilink_master) {
- if (!bundle_terminating)
+ if (!bundle_terminating) {
new_phase(PHASE_MASTER);
+ if (!detached)
+ detach();
+ }
else
mp_bundle_terminated();
} else
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#538107: multilink with nodetach [PATCH]
Hi
This bug has been Reported in the Debian BTS as bug 538107
http://bugs.debian.org/578070
If pppd is used with l2tpd (nodetach) in a multilink situation then this
feature of pppd causes problems
MULTILINK
If the first link terminates (for example, because of a
hangup or a received LCP terminate-request) the bundle is
not destroyed unless there are no other links remaining in the
bundle. Rather than exiting, the first pppd keeps running
after its link terminates, until all the links in the bundle
have terminated.
pppd remains connected to l2tpd even though it is just acting as a
multilink master, causing l2tpd to believe that pppd is connected... i
have resolved the issue in my own system by instructing pppd to detach
from the terminal after it changes to PHASE_MASTER i have been using
this patch since 2009-02-19 in our production systems and havent had any
problems
The if (!detached) call is redundant since the detach function already
checks if the process is detached so can be optionally excluded
I have noticed other people complaining of similar issues when using
multilink/nodetach in other setups (eg pppoe) I believe that this patch
may also solve the problem for them, but i have not tested that setup
-
diff --git a/pppd/auth.c b/pppd/auth.c
index fb71944..62648b8 100644
--- a/pppd/auth.c
+++ b/pppd/auth.c
@@ -669,8 +669,11 @@ link_terminated(unit)
(*the_channel-cleanup)();
if (doing_multilink multilink_master) {
- if (!bundle_terminating)
+ if (!bundle_terminating) {
new_phase(PHASE_MASTER);
+ if (!detached)
+ detach();
+ }
else
mp_bundle_terminated();
} else
-
feedback is appreciated :)
Regards
Stephen
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#538107: fixed patch
On Aug 24, Stephen Marron deb...@solo.boxfusion.net wrote: The below diff is against upstream git repo I do not feel comfortable applying at this time a patch to code I do not understand, can you send it to the upstream mailing list and have somebody say it's OK? -- ciao, Marco signature.asc Description: Digital signature
Bug#538107: Acknowledgement (multilink with nodetach )
Hi, Is there any chance that this patch will make it in before squeeze gets frozen in december? Thanks Stephen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#538107: multilink with nodetach
Package: ppp
Version: 2.4.4rel-10.1
Severity: minor
If pppd is used with l2tpd (nodetach) in a multilink situation then this
feature of pppd causes problems
MULTILINK
If the first link terminates (for example, because of a hangup
or a
received LCP terminate-request) the bundle is not destroyed
unless
there are no other links remaining in the bundle. Rather than
exiting,
the first pppd keeps running after its link terminates, until
all the
links in the bundle have terminated.
pppd remains connected to l2tpd even though it is just acting as a
multilink master, causing l2tpd to belive the pppd is connected... i
have resolved the issue in my own system by instructing pppd to detach
from the terminal after it changes to PHASE_MASTER i have been using
this patch since 2009-02-19 in our production systems and havent had any
problems
The if (!detached) call is redundant since the detach function already
checks if the process is detached so can be optionally excluded
i have noticed other people complaining of similar issues when using
multilink/nodetach in other setups (eg pppoe) I believe that this patch
may also solve the problem for them, but i have not tested that setup
-
(auth.c)@(void link_terminated(unit))
if (doing_multilink multilink_master) {
if (!bundle_terminating)
new_phase(PHASE_MASTER);
+++if (!detached)
+++detach();
else
mp_bundle_terminated();
} else
new_phase(PHASE_DEAD);
-
feedback is appreciated :)
Regards
Stephen
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
