Bug#542287: [Monotone-debian] Bug#542287: monotone-server: Incorrect runlevels and dependencies in init.d script

[Zack Weinberg]

I would rather you did not, as I have almost completed packaging work
on the new upstream release; I  just need to find the time to finish
testing it.  This should happen in no more than a week.  Thanks for
the updated patch though, I will probably use it.

zw

On Thu, Oct 1, 2009 at 12:09 PM, Petter Reinholdtsen  wrote:
> Here is a more complete patch, to help you get the fix into unstable.
> Please let us know if we should not NMU to fix it. :)
>
> diff -ur ../monotone-0.44/debian/monotone-server.monotone.init 
> ../monotone-0.44-pere/debian/monotone-server.monotone.init
> --- ../monotone-0.44/debian/monotone-server.monotone.init       2009-10-01 
> 20:44:18.0 +0200
> +++ ../monotone-0.44-pere/debian/monotone-server.monotone.init  2009-10-01 
> 20:45:41.0 +0200
> @@ -6,10 +6,10 @@
>  #
>  ### BEGIN INIT INFO
>  # Provides: monotone
> -# Required-Start: $network $local_fs
> -# Required-Stop: $network $local_fs
> -# Default-Start: 3 4 5
> -# Default-Stop: 0 1 2 6
> +# Required-Start: $network $remote_fs $syslog
> +# Required-Stop:  $network $remote_fs $syslog
> +# Default-Start:  2 3 4 5
> +# Default-Stop:   0 1 6
>  # Short-Description: Monotone server.
>  ### END INIT INFO
>
> diff -ur ../monotone-0.44/debian/monotone-server.postinst 
> ../monotone-0.44-pere/debian/monotone-server.postinst
> --- ../monotone-0.44/debian/monotone-server.postinst    2009-10-01 
> 20:44:18.0 +0200
> +++ ../monotone-0.44-pere/debian/monotone-server.postinst       2009-10-01 
> 21:00:14.0 +0200
> @@ -223,6 +223,16 @@
>  # stop debconf
>  db_stop
>
> +# Those using dependency based boot sequencing and installing
> +# monotone before version 0.44-2 would miss the runlevel 2 symlink.
> +# Recover from this.
> +if [ "$1" = "configure" ] && dpkg --compare-versions "$2" le "0.44-2" \
> +   && [ ! -f /etc/rc2.d/[SK][0-9][0-9]monotone ] \
> +   && [ -f /etc/rc3.d/K[0-9][0-9]monotone ]
> +then
> +   update-rc.d -f monotone remove
> +fi
> +
>  # dh_installdeb will replace this with shell code automatically
>  # generated by other debhelper scripts.
>
>
> Happy hacking,
> --
> Petter Reinholdtsen
>
>
>
>
> ___
> Monotone-debian mailing list
> monotone-deb...@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/monotone-debian
>



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#542287: [Monotone-debian] Bug#542287: monotone-server: Incorrect runlevels and dependencies in init.d script

[Petter Reinholdtsen]

[Zack Weinberg]
> I would rather you did not, as I have almost completed packaging
> work on the new upstream release; I just need to find the time to
> finish testing it.  This should happen in no more than a week.
> Thanks for the updated patch though, I will probably use it.

Great to hear.  I eagerly away the new upload. :)

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#542287: [Monotone-debian] Bug#542287: monotone-server: Incorrect runlevels and dependencies in init.d script

[Zack Weinberg]

On Tue, Aug 18, 2009 at 1:06 PM, Petter Reinholdtsen  wrote:
>
> With dependency based boot sequencing, I discovered what I believe is
> a bug in the init.d script.

Thanks for this bug report.  I am going to fix it in the next upload,
but I could use a little help.  I've merged your changes to the init
script except that ...

> The script used to start after syslog, so I suggest making it depend on 
> $syslog.

... this is not necessary; the server does not use syslog for its logging.

> In addition to
> this header change, some code in postinst is needed to remove the stop
> symlink in rc2.d and add a start symlink in rc2.d during upgrades.

I don't know how to do this; can you point me at instructions?
Currently, all rc*.d related code is being generated by
dh_installinit.  I don't see clear instructions in any of the obvious
places to look (policy manual, developer's reference, man
dh_installinit, man update-rc.d) and I don't want to get it wrong.

zw



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org