Bug#548988: [pkg-cryptsetup-devel] Bug#548988: cryptsetup - uuid usage differs from what devmapper expects
hey bastian, hey milan, On 01/10/2009 Bastian Blank wrote: > On Wed, Sep 30, 2009 at 12:01:05PM +0200, Milan Broz wrote: > > That's the story. What's the real problem now in this bug? > > What you've shown is the theory. It does not look this way on my system > nor in the 1.0.7 code. i can verify that on a system with cryptsetup 1.0.7-2 from debian/unstable the symlinks in /dev/disk/by-uuid/ don't have the expected names: # ls -1 /dev/disk/by-id/dm-uuid-CRYPT-* /dev/disk/by-id/dm-uuid-CRYPT-324a3345-e673-fc23-4285-85a13e23c2b1 /dev/disk/by-id/dm-uuid-CRYPT-422340ce-234a-4311-ef34-2ba6c602f7d9 on the same system with cryptsetup 1.1.0-rc1 installed it is: # ls -1 /dev/disk/by-id/dm-uuid-CRYPT-* /dev/disk/by-id/dm-uuid-CRYPT-LUKS1-324a3345e673fc23428585a13e23c2b1-cdata1 /dev/disk/by-id/dm-uuid-CRYPT-LUKS1-422340ce234a4311ef342ba6c602f7d9-clvm1 /dev/disk/by-id/dm-uuid-CRYPT-PLAIN-cswap1 /dev/disk/by-id/dm-uuid-CRYPT-PLAIN-ctemp1 /dev/disk/by-id/dm-uuid-CRYPT-PLAIN-ctemp2 greetings, jonas signature.asc Description: Digital signature
Bug#548988: cryptsetup - uuid usage differs from what devmapper expects
Bastian Blank wrote: > On Wed, Sep 30, 2009 at 12:01:05PM +0200, Milan Broz wrote: >> That's the story. What's the real problem now in this bug? > > What you've shown is the theory. It does not look this way on my system > nor in the 1.0.7 code. Of course it is not theory but real implementation. Maybe there is bug. You really should be more specific. What's your problem? Milan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#548988: cryptsetup - uuid usage differs from what devmapper expects
On Wed, Sep 30, 2009 at 12:01:05PM +0200, Milan Broz wrote: > That's the story. What's the real problem now in this bug? What you've shown is the theory. It does not look this way on my system nor in the 1.0.7 code. Bastian -- Insufficient facts always invite danger. -- Spock, "Space Seed", stardate 3141.9 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#548988: [pkg-cryptsetup-devel] Bug#548988: cryptsetup - uuid usage differs from what devmapper expects
On 30/09/2009 Milan Broz wrote:
> Bastian Blank wrote:
> > I'm not sure, where this informations comes from, but LVM upstream
> > decided to use the UUID of CRYPT-TEMP-* to detect the temporary luks
> > devices. Also in the examples, they use CRYPT-PLAIN-* and CRYPT-LUKS1-*,
> > which is not set this way by the current version of cryptsetup.
>
> The rule is simple - all dm devices should have UUID set.
>
> for cryptsetup <= 1.0.6 it doesn't set dm-uuid at all.
>
> for cryptsetup == 1.0.7 it set dm-uuid for luks device, but because of
> problems
> (people are running snapshots of the whole header and then dm-uuid is
> duplicated...)
> I changed it (see debian bug 538221 for example).
>
> So now, all devices created by cryptsetup have DM-UUID set in the format
> CRYPT--[-]
>
> For example:
> CRYPT-PLAIN-name
> CRYPT-LUKS1--name
> CRYPT-TEMP-name
>
> (All dm devices have prefix which identifies subsystem - here CRYPT-, but we
> have LVM-, DMRAID-,
> MPATH, etc.)
i can verify that all dm-crypt devices have DM-UUID set correct on my
system with cryptsetup 1.1.0~rc1 installed. i guess this bug can be
closed once i uploaded cryptsetup 1.1.0~rc1 to debian/unstable.
> For udev rules, you should still detect temporary cryptsetup detect devices
> by name (because of
> old version of cryptsetup), but since version 1.1 it have also uuid prefix
> CRYPT-TEMP-.
> Name remains (temporary-cryptsetup-$PID)
>
> The lvm code already contains proper rule for udev:
>
> ENV{DM_UUID}=="CRYPT-TEMP-?*", GOTO="dm_last_rule"
> ENV{DM_UUID}!="?*", ENV{DM_NAME}=="temporary-cryptsetup-?*",
> GOTO="dm_last_rule"
>
>
> That's the story. What's the real problem now in this bug?
> The old cryptsetup do not set dm-uuid, but I see no real problem with that.
i understood the bugreport as request for consistent dm-uuids. beginning
with cryptsetup 1.1.0 this should be the case, so the bugreport will be
closed with the upload of cryptsetup 1.1.0(-rc1) to debian/unstable.
or did i miss something?
greetings,
jonas
signature.asc
Description: Digital signature
Bug#548988: cryptsetup - uuid usage differs from what devmapper expects
Bastian Blank wrote:
> I'm not sure, where this informations comes from, but LVM upstream
> decided to use the UUID of CRYPT-TEMP-* to detect the temporary luks
> devices. Also in the examples, they use CRYPT-PLAIN-* and CRYPT-LUKS1-*,
> which is not set this way by the current version of cryptsetup.
The rule is simple - all dm devices should have UUID set.
for cryptsetup <= 1.0.6 it doesn't set dm-uuid at all.
for cryptsetup == 1.0.7 it set dm-uuid for luks device, but because of problems
(people are running snapshots of the whole header and then dm-uuid is
duplicated...)
I changed it (see debian bug 538221 for example).
So now, all devices created by cryptsetup have DM-UUID set in the format
CRYPT--[-]
For example:
CRYPT-PLAIN-name
CRYPT-LUKS1--name
CRYPT-TEMP-name
(All dm devices have prefix which identifies subsystem - here CRYPT-, but we
have LVM-, DMRAID-,
MPATH, etc.)
For udev rules, you should still detect temporary cryptsetup detect devices by
name (because of
old version of cryptsetup), but since version 1.1 it have also uuid prefix
CRYPT-TEMP-.
Name remains (temporary-cryptsetup-$PID)
The lvm code already contains proper rule for udev:
ENV{DM_UUID}=="CRYPT-TEMP-?*", GOTO="dm_last_rule"
ENV{DM_UUID}!="?*", ENV{DM_NAME}=="temporary-cryptsetup-?*", GOTO="dm_last_rule"
That's the story. What's the real problem now in this bug?
The old cryptsetup do not set dm-uuid, but I see no real problem with that.
Milan
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#548988: cryptsetup - uuid usage differs from what devmapper expects
Package: cryptsetup Version: 2:1.0.7-2 I'm not sure, where this informations comes from, but LVM upstream decided to use the UUID of CRYPT-TEMP-* to detect the temporary luks devices. Also in the examples, they use CRYPT-PLAIN-* and CRYPT-LUKS1-*, which is not set this way by the current version of cryptsetup. Bastian -- Beam me up, Scotty! It ate my phaser! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
