Bug#549204: imap: set blindly read-only when it's not for flags

2016-09-04 Thread Antonio Radici
Patch applied in git, it will be included in 1.7.0-2



Bug#549204: imap: set blindly read-only when it's not for flags

2009-10-01 Thread Julien Danjou
Package: mutt
Version: 1.5.20-4
Severity: normal

This is upstream bug http://dev.mutt.org/trac/ticket/969
which is old.

I wrote a fix, attached, that remove the CHECK_READONLY in various place
and only use CHECK_ACL to check the permission.

I can provide more explanation/information if needed.

The patch is made to be put at last in misc/fix-acl. I can rework it if
needed.

-- Package-specific info:
Mutt 1.5.20 (2009-06-14)
Copyright (C) 1996-2009 Michael R. Elkins and others.
Mutt comes with ABSOLUTELY NO WARRANTY; for details type `mutt -vv'.
Mutt is free software, and you are welcome to redistribute it
under certain conditions; type `mutt -vv' for details.

System: Linux 2.6.30-1-amd64 (x86_64)
ncurses: ncurses 5.7.20090803 (compiled with 5.7)
libidn: 1.15 (compiled with 1.15)
hcache backend: GDBM version 1.8.3. 10/15/2002 (built Jul  9 2009 11:48:41)
Compile options:
-DOMAIN
+DEBUG
-HOMESPOOL  +USE_SETGID  +USE_DOTLOCK  +DL_STANDALONE  +USE_FCNTL  -USE_FLOCK   
+USE_POP  +USE_IMAP  +USE_SMTP  
-USE_SSL_OPENSSL  +USE_SSL_GNUTLS  +USE_SASL  +USE_GSS  +HAVE_GETADDRINFO  
+HAVE_REGCOMP  -USE_GNU_REGEX  
+HAVE_COLOR  +HAVE_START_COLOR  +HAVE_TYPEAHEAD  +HAVE_BKGDSET  
+HAVE_CURS_SET  +HAVE_META  +HAVE_RESIZETERM  
+CRYPT_BACKEND_CLASSIC_PGP  +CRYPT_BACKEND_CLASSIC_SMIME  +CRYPT_BACKEND_GPGME  
-EXACT_ADDRESS  -SUN_ATTACHMENT  
+ENABLE_NLS  -LOCALES_HACK  +COMPRESSED  +HAVE_WC_FUNCS  +HAVE_LANGINFO_CODESET 
 +HAVE_LANGINFO_YESEXPR  
+HAVE_ICONV  -ICONV_NONTRANS  +HAVE_LIBIDN  +HAVE_GETSID  +USE_HCACHE  
-ISPELL
SENDMAIL=/usr/sbin/sendmail
MAILPATH=/var/mail
PKGDATADIR=/usr/share/mutt
SYSCONFDIR=/etc
EXECSHELL=/bin/sh
MIXMASTER=mixmaster
To contact the developers, please mail to mutt-...@mutt.org.
To report a bug, please visit http://bugs.mutt.org/.

patch-1.5.13.cd.ifdef.2

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages mutt depends on:
ii  libc6   2.9-26   GNU C Library: Shared libraries
ii  libcomerr2  1.41.9-1 common error description library
ii  libgdbm31.8.3-6  GNU dbm database routines (runtime
ii  libgnutls26 2.8.4-1  the GNU TLS library - runtime libr
ii  libgpg-error0   1.6-1library for common error values an
ii  libgpgme11  1.2.0-1  GPGME - GnuPG Made Easy
ii  libgssapi-krb5-21.7dfsg~beta3-1  MIT Kerberos runtime libraries - k
ii  libidn111.15-1   GNU Libidn library, implementation
ii  libk5crypto31.7dfsg~beta3-1  MIT Kerberos runtime libraries - C
ii  libkrb5-3   1.7dfsg~beta3-1  MIT Kerberos runtime libraries
ii  libncursesw55.7+20090803-2   shared libraries for terminal hand
ii  libsasl2-2  2.1.23.dfsg1-1.1 Cyrus SASL - authentication abstra

Versions of packages mutt recommends:
ii  exim4-daemon-light [mai 4.69-11+b1   lightweight Exim MTA (v4) daemon
ii  libsasl2-modules2.1.23.dfsg1-1.1 Cyrus SASL - pluggable authenticat
ii  locales 2.9-26   GNU C Library: National Language (
ii  mime-support3.46-1   MIME files 'mime.types'  'mailcap

Versions of packages mutt suggests:
ii  aspell0.60.6-2   GNU Aspell spell-checker
ii  ca-certificates   20090814   Common CA certificates
ii  gnupg 1.4.10-2   GNU privacy guard - a free PGP rep
pn  mixmaster none (no description available)
ii  openssl   0.9.8k-5   Secure Socket Layer (SSL) binary a
pn  urlview   none (no description available)

Versions of packages mutt is related to:
ii  mutt  1.5.20-4   text-based mailreader supporting M
ii  mutt-dbg  1.5.20-4   debugging symbols for mutt
pn  mutt-patched  none (no description available)

-- no debconf information
Index: mutt-1.5.20/curs_main.c
===
--- mutt-1.5.20.orig/curs_main.c	2009-10-01 14:59:29.0 +0200
+++ mutt-1.5.20/curs_main.c	2009-10-01 14:59:30.0 +0200
@@ -819,7 +819,6 @@
 
 	CHECK_MSGCOUNT;
 CHECK_VISIBLE;
-	CHECK_READONLY;
 	CHECK_ACL(M_ACL_DELETE, _(delete message(s)));
 
 	CHECK_ATTACH;
@@ -987,7 +986,6 @@
 
 	CHECK_MSGCOUNT;
 CHECK_VISIBLE;
-	CHECK_READONLY;
 	CHECK_ACL(M_ACL_DELETE, _(undelete message(s)));
 
 	if (mutt_pattern_func (M_UNDELETE, _(Undelete messages matching: )) == 0)
@@ -1020,7 +1018,6 @@
 
 	CHECK_MSGCOUNT;
 CHECK_VISIBLE;
-	CHECK_READONLY;
 	{
 	  int oldvcount = Context-vcount;
 	  int oldcount  = Context-msgcount;
@@ -1273,7 +1270,6 @@
 
 	CHECK_MSGCOUNT;
  

Bug#549204: imap: set blindly read-only when it's not for flags

2009-10-01 Thread Julien Danjou
At 1254404981 time_t, Antonio Radici wrote:
 Ok, thanks for your patch, this will be included with the next release.

Please note, I did test if on IMAP, but on on POP or raw Maildir access.
Maybe some more extended test would be a good idea. I don't think that
the patch can break anything, but you never know. :-)

Cheers,
-- 
Julien Danjou
.''`.  Debian Developer
: :' : http://julien.danjou.info
`. `'  http://people.debian.org/~acid
  `-   9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD


signature.asc
Description: Digital signature