Bug#553207: lintian: wrong patch-system-but-no-source-readme when using quilt with 3.0 (quilt) source packages

[Stéphane Glondu]

tags 553207 + patch
thanks

Raphaël Hertzog a écrit :
 This warning is wrong since with this source format the quilt
 patch is auto-applied by dpkg-source -x and we don't need any special
 instruction.

Attached is a patch that fixes this issue.


Cheers,

-- 
Stéphane
From 200244d14e1387906ae25c7027044883e920aa4f Mon Sep 17 00:00:00 2001
From: Stephane Glondu st...@glondu.net
Date: Wed, 4 Nov 2009 09:41:07 +0100
Subject: [PATCH] Do not issue patch-system-but-no-source-readme with quilt format

---
 checks/patch-systems |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/checks/patch-systems b/checks/patch-systems
index 8fde4dd..0a29cce 100644
--- a/checks/patch-systems
+++ b/checks/patch-systems
@@ -167,7 +167,7 @@ sub run {
 	}
 
 	#- look for README.source
-	if ($uses_patch_system  ! -f 'debfiles/README.source') {
+	if ($uses_patch_system  ! $quilt_format  ! -f 'debfiles/README.source') {
 		tag patch-system-but-no-source-readme;
 	}
 
-- 
1.6.5

Bug#553207: lintian: wrong patch-system-but-no-source-readme when using quilt with 3.0 (quilt) source packages

[Raphaël Hertzog]

Package: lintian
Version: 2.2.17
Severity: normal

I just built and uploaded my first 3.0 (quilt) source package
and aside from unsupported-source-format (#552707) I also get:
W: ftplib source: patch-system-but-no-source-readme

This warning is wrong since with this source format the quilt
patch is auto-applied by dpkg-source -x and we don't need any special
instruction.

Cheers,
-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (150, 
'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.30-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.20-1The GNU assembler, linker and bina
ii  diffstat   1.47-1produces graph of changes introduc
ii  dpkg-dev   1.15.5Debian package development tools
ii  file   5.03-2Determines file type using magic
ii  gettext0.17-8GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl0.1.24Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1Perl module that automatically gen
ii  libipc-run-perl0.84-1Perl module for running processes
ii  libparse-debianchangel 1.1.1-2   parse Debian changelogs and output
ii  libtimedate-perl   1.1900-1  Time and date functions for Perl
ii  liburi-perl1.37+dfsg-1   Manipulates and accesses URI strin
ii  man-db 2.5.6-3   on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-5  Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarchnone (no description available)
ii  libtext-template-perl 1.45-1 Text::Template perl module
ii  man-db2.5.6-3on-line manual pager

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org