Bug#553293: sendmail-bin: read-in-maintainer-script (postinst:78, postinst:95)

2009-11-04 Thread Steve Langasek
severity 553293 minor
thanks

These calls to read are in an unreachable function whose only invocation
occurs after an unconditional 'exit'.  Downgrading.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: Digital signature


Bug#553293: sendmail-bin: read-in-maintainer-script (postinst:78, postinst:95)

2009-11-02 Thread Richard A Nelson

On Thu, 29 Oct 2009, Manoj Srivastava wrote:


This maintainer script appears to use read to get information from the
user. Prompting in maintainer scripts must be done by communicating through a
program such as debconf which conforms to the Debian Configuration management
specification, version 2 or higher.

Refer to Debian Policy Manual section 3.9.1 (Prompting in maintainer scripts)
for details.


Too bad lintian doesn't do control flow analysis - this is left over
code that was left for a potential conversion to debconf that never
happened...   It is *not* executed
--
Rick Nelson
...very few phenomena can pull someone out of Deep Hack Mode, with two
noted exceptions: being struck by lightning, or worse, your *computer*
being struck by lightning.
(By Matt Welsh)



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#553293: sendmail-bin: read-in-maintainer-script (postinst:78, postinst:95)

2009-11-02 Thread Manoj Srivastava
On Mon, Nov 02 2009, Richard A Nelson wrote:

 On Thu, 29 Oct 2009, Manoj Srivastava wrote:

 This maintainer script appears to use read to get information from the
 user. Prompting in maintainer scripts must be done by communicating through a
 program such as debconf which conforms to the Debian Configuration management
 specification, version 2 or higher.

 Refer to Debian Policy Manual section 3.9.1 (Prompting in maintainer scripts)
 for details.

 Too bad lintian doesn't do control flow analysis - this is left over
 code that was left for a potential conversion to debconf that never
 happened...   It is *not* executed

Please add  a lintian override to the package - this would
 prevent other people from falling into the error of reporting this bug.

manoj
-- 
The worst cliques are those which consist of one man. G.B. Shaw
Manoj Srivastava sriva...@debian.org http://www.debian.org/~srivasta/  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#553293: sendmail-bin: read-in-maintainer-script (postinst:78, postinst:95)

2009-10-29 Thread Manoj Srivastava
Package: sendmail-bin
Version: 8.14.3-9
Severity: serious
User: lintian-ma...@debian.org
Usertags: read-in-maintainer-script

 This maintainer script appears to use read to get information from the
 user. Prompting in maintainer scripts must be done by communicating through a
 program such as debconf which conforms to the Debian Configuration management
 specification, version 2 or higher.
 
 Refer to Debian Policy Manual section 3.9.1 (Prompting in maintainer scripts)
 for details.
 
,[ 3.9.1 Prompting in maintainer scripts ]
| Package maintainer scripts may prompt the user if necessary. Prompting must be
| done by communicating through a program, such as debconf, which conforms to 
the
| Debian Configuration Management Specification, version 2 or higher.
| 
| Packages which are essential, or which are dependencies of essential packages,
| may fall back on another prompting method if no such interface is available 
when
| they are executed.
| 
| The Debian Configuration Management Specification is included in the
| debconf_specification files in the debian-policy package. 
`

manoj


-- Package-specific info:
Ouput of /usr/share/bug/sendmail-bin/script:

ls -alR /etc/mail:
/etc/mail:
total 1316
drwxr-sr-x.   7 smmtasmmsp  4096 Aug 17 10:54 .
drwxr-xr-x. 231 root root  20480 Oct 29 13:26 ..
-rw-r--r--.   1 root smmsp 24298 Jul 12  2007 70_sare_evilnum0.cf
-rw-r--r--.   1 root smmsp 18190 Jul 12  2007 70_sare_random.cf
-rw-r--r--.   1 root smmsp13 Jul 12  2007 LocalIP
-rw-r--r--.   1 root smmsp 5 Jul 12  2007 LocalNames
-rwxr-xr--.   1 root smmsp 12078 Mar  2  2009 Makefile
-rw---.   1 root smmsp  4603 Mar  6  2009 access
-rw-r-.   1 smmtasmmsp 12288 Mar  6  2009 access.db
-rw---.   1 root smmsp  4571 Mar  6  2009 access.save
-rw-r--r--.   1 root smmsp   281 Jun 25  2007 address.resolve
lrwxrwxrwx.   1 root smmsp10 Jul  5  2007 aliases - ../aliases
-rw-r-.   1 smmtasmmsp 12288 Aug 28 15:02 aliases.db
-rw-r--r--.   1 root smmsp 10854 Jul 12  2007 asciispam.cf
-rw-r--r--.   1 root smmsp100721 Jul 12  2007 bogus-virus-warnings.cf
-rw-r--r--.   1 root root   3684 Mar  2  2009 databases
-rw-r-.   1 smmtasmmsp64 Jul 12  2007 default-auth-info
-rw-r--r--.   1 root smmsp  5657 Jun 25  2007 helpfile
-rw-r--r--.   1 root smmsp 61254 Jul 12  2007 junk
-rw-r--r--.   1 root smmsp43 Jul 12  2007 local-host-names
drwxr-sr-x.   2 smmtasmmsp  4096 Jul  5  2007 m4
-rw-r--r--.   1 root smmsp 0 Jul 12  2007 mailertable
-rw-r-.   1 root smmsp 12288 Mar  2  2009 mailertable.db
-rw-r--r--.   1 srivasta srivasta  68002 Aug 17 10:54 mimedefang-filter
-rw-r--r--.   1 root smmsp 12933 Dec 10  2007 
mimedefang-filter.dpkg-dist
-rw-r--r--.   1 root smmsp 58990 Jul 12  2007 mimedefang-filter.grey
-rw-r--r--.   1 root smmsp 67042 Nov 20  2007 mimedefang-filter.reaver
-rw-r--r--.   1 root smmsp 67963 Jul 31 23:00 mimedefang-filter.save
-rwxr-xr-x.   1 root smmsp   908 Jul 12  2007 mimedefang-monitor
-rw-r--r--.   1 root smmsp  4130 Jul 12  2007 mimedefang.conf.1003
-rw-r--r--.   1 root smmsp  4130 Jul 12  2007 mimedefang.conf.18984
-rw-r--r--.   1 root smmsp  4130 Jul 12  2007 mimedefang.conf.22199
-rw-r--r--.   1 root smmsp  4130 Jul 12  2007 mimedefang.conf.5828
-rw-r--r--.   1 root smmsp  4130 Jul 12  2007 mimedefang.conf.9654
-rw-r--r--.   1 root smmsp   276 Jul 12  2007 mimedefang.pl.conf
drwxr-xr-x.   2 root smmsp  4096 Mar  2  2009 peers
-rw-r--r--.   1 root smmsp47 Jul 12  2007 relay-domains
-rw-r--r--.   1 root smmsp 15033 Jul 12  2007 sa-mimedefang.cf
drwxr-xr-x.   2 smmtasmmsp  4096 Jul 12  2007 sasl
-rw-r--r--.   1 root smmsp 69076 Mar  2  2009 sendmail.cf
-rw-r--r--.   1 root root  69077 Mar  2  2009 sendmail.cf.old
-rw-r--r--.   1 root root  12237 Mar  2  2009 sendmail.conf
-rw-r--r--.   1 root smmsp  4935 May 22  2008 sendmail.mc
-rw-r--r--.   1 root smmsp  4709 Jul 12  2007 sendmail.mc.new
-rw-r--r--.   1 root smmsp  4709 Jul 12  2007 sendmail.mc.old
-rw-r--r--.   1 root smmsp   149 Jun 25  2007 service.switch
-rw-r--r--.   1 root smmsp   180 Jun 25  2007 service.switch-nodns
drwxr-sr-x.   2 smmtasmmsp  4096 Jul 12  2007 smrsh
-rw-r--r--.   1 root smmsp47 Jul 12  2007 spamlist
-rw-r--r--.   1 root smmsp 43888 Mar  2  2009 submit.cf
-rw-r--r--.   1 root root  43889 Mar  2  2009 submit.cf.old
-rw-r--r--.   1 root smmsp  2284 Mar  2  2009 submit.mc
drwxr-xr-x.   2 smmtasmmsp  4096 Mar 25  2008 tls
-rw-r--r--.   1 root smmsp 56238 Jul 12  2007 tripwire.cf
-rw-r--r--.   1 root smmsp 9 Jul 12  2007 trusted-users
-rw-r--r--.   1