Bug#556893: #556893,say which 'defaults' are which better
Control: tags -1 - patch Am 13.10.19 um 21:41 schrieb Jesse Smith: > On 10/13/19 4:33 PM, Michael Biebl wrote: >> Control: tags -1 + moreinfo >> Will insserv fail if the version is too old, i.e. do we need a versioned >> dependency (or rather versioned Breaks)? > > Yes, older versions of insserv will fail if --silent is specified as it > will not be a recognized option. There should probably be a version > check. Or a check in the calling script to try with insserv --silent and > if it fails, try again without the flag. Ok, thanks. Removing the patch tag then. >> What exactly is suppressed by -q/--silent? >> Only this specific error about "defaults" or other error messages as >> well? Do we want to suppress all error messages? > > The --silent flag suppresses warnings (non-fatal errors). Basically > anything that is a "heads up" warning is suppressed. Fatal errors and > issues which require user attention are still printed. Ok, good. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#556893: #556893,say which 'defaults' are which better
On 10/13/19 4:33 PM, Michael Biebl wrote: > Control: tags -1 + moreinfo > > On Sat, 28 Sep 2019 15:21:17 -0300 Jesse Smith > wrote: >> This has been addressed upstream in insserv by allowing the program to >> accept changes like this silently. All we need now is for update-rc.d to >> be updated to use the new behaviour (enabled with the -q flag) and this >> issue can be closed. > Is it -q or --silent? Or are they the same? -q and --silent do the same thing. These are now documented in the manual page for insserv. > > Will insserv fail if the version is too old, i.e. do we need a versioned > dependency (or rather versioned Breaks)? Yes, older versions of insserv will fail if --silent is specified as it will not be a recognized option. There should probably be a version check. Or a check in the calling script to try with insserv --silent and if it fails, try again without the flag. > What exactly is suppressed by -q/--silent? > Only this specific error about "defaults" or other error messages as > well? Do we want to suppress all error messages? The --silent flag suppresses warnings (non-fatal errors). Basically anything that is a "heads up" warning is suppressed. Fatal errors and issues which require user attention are still printed.
Bug#556893: #556893,say which 'defaults' are which better
Control: tags -1 + moreinfo On Sat, 28 Sep 2019 15:21:17 -0300 Jesse Smith wrote: > This has been addressed upstream in insserv by allowing the program to > accept changes like this silently. All we need now is for update-rc.d to > be updated to use the new behaviour (enabled with the -q flag) and this > issue can be closed. Is it -q or --silent? Or are they the same? Will insserv fail if the version is too old, i.e. do we need a versioned dependency (or rather versioned Breaks)? What exactly is suppressed by -q/--silent? Only this specific error about "defaults" or other error messages as well? Do we want to suppress all error messages? Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#556893: #556893,say which 'defaults' are which better
control: reassign -1 init-system-helpers
control: tags -1 +patch
[2019-09-28 15:21] Jesse Smith
> This has been addressed upstream in insserv by allowing the program to
> accept changes like this silently. All we need now is for update-rc.d to
> be updated to use the new behaviour (enabled with the -q flag) and this
> issue can be closed.
Thank you for bug triaging, Jesse. Reassigning back to
init-system-helpers.
Dear init-system-helpers maintainer, please consider applying following
patch:
From 638717158f50fa24a119b69ee0888158d306f492 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov
Date: Sat, 12 Oct 2019 13:55:45 +
Subject: [PATCH] Prevent insserv(8) from printing too much debug
Closes: #556893
---
script/update-rc.d | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/script/update-rc.d b/script/update-rc.d
index 71fb1a6..03d21cf 100755
--- a/script/update-rc.d
+++ b/script/update-rc.d
@@ -181,7 +181,7 @@ sub create_sequence {
$insserv = "/sbin/insserv" if ( -x "/sbin/insserv");
# If insserv is not configured it is not fully installed
my $insserv_installed = -x $insserv && -e "/etc/insserv.conf";
-my @opts;
+my @opts = ('--silent');
push(@opts, '-f') if $force;
# Add force flag if initscripts is not installed
# This enables inistcripts-less systems to not fail when a facility is
missing
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.
Bug#556893: #556893,say which 'defaults' are which better
This has been addressed upstream in insserv by allowing the program to accept changes like this silently. All we need now is for update-rc.d to be updated to use the new behaviour (enabled with the -q flag) and this issue can be closed. - Jesse
