Bug#558272: Date::Calc::Decode_Month(): argument is not a string
Hi, I prepared a patch for this issue. It passes the test suite and also the code snippets that failed before. I am not very familiar with XS, so any comments are welcome. The patch can be found at [1]. Regards, Ansgar [1] http://svn.debian.org/viewsvn/pkg-perl/branches/unstable/libdate-calc-perl/debian/patches/SvPV.patch?revision=62052view=markup -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
On Thu, Aug 26, 2010 at 05:47:53PM +0900, Ansgar Burchardt wrote: I prepared a patch for this issue. It passes the test suite and also the code snippets that failed before. I am not very familiar with XS, so any comments are welcome. [1] http://svn.debian.org/viewsvn/pkg-perl/branches/unstable/libdate-calc-perl/debian/patches/SvPV.patch?revision=62052view=markup I think even the SvROK() is overly defensive. Consider the attached amended test file, which has an additional regression test from the lenny version. Of course, it would be nice to get the upstream opinion. -- Niko Tyni nt...@debian.org debian-558272.t Description: Troff document
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
Niko Tyni nt...@debian.org writes: On Thu, Aug 26, 2010 at 05:47:53PM +0900, Ansgar Burchardt wrote: I prepared a patch for this issue. It passes the test suite and also the code snippets that failed before. I am not very familiar with XS, so any comments are welcome. [1] http://svn.debian.org/viewsvn/pkg-perl/branches/unstable/libdate-calc-perl/debian/patches/SvPV.patch?revision=62052view=markup I think even the SvROK() is overly defensive. Consider the attached amended test file, which has an additional regression test from the lenny version. Of course, it would be nice to get the upstream opinion. True, I forgot about overload here. I updated the patch accordingly and also amended the test as well. The patch is now also forwarded upstream [2] (very slightly modified to apply to Date::Calc::XS). Regards, Ansgar [2] https://rt.cpan.org/Public/Bug/Display.html?id=60233#txn-822819 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
tags 558272 - fixed-upstream forwarded 558272 https://rt.cpan.org/Ticket/Display.html?id=60233 thanks Hi, $ echo Oct | perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' Date::Calc::Decode_Month(): argument is not a string at -e line 1, line 1. This is not fixed in the latest upstream release. I installed Date::Calc 6.3 and Date::Calc::XS 6.2 from CPAN and the problem is still present. It is, however, limited to the XS implementation and can easily be worked around: just use $1 (with quotes) instead of $1. Regards, Ansgar -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
On 2010-08-11 15:55:21 +0900, Ansgar Burchardt wrote: This is not fixed in the latest upstream release. I installed Date::Calc 6.3 and Date::Calc::XS 6.2 from CPAN and the problem is still present. Well, Date::Calc 6.3 solves the problem on my machine: $ echo Oct | perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' 10 $ echo Oct | env -u PERL5LIB perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' Date::Calc::Decode_Month(): argument is not a string at -e line 1, line 1. See the difference when I use the CPAN version (6.3) installed in my $HOME and when I use Debian's version. FYI, here are the files that were installed: Installing /home/vlefevre/lib/site_perl/Date/Calc.pod Installing /home/vlefevre/lib/site_perl/Date/Calc.pm Installing /home/vlefevre/lib/site_perl/Date/Calendar.pm Installing /home/vlefevre/lib/site_perl/Date/Calendar.pod Installing /home/vlefevre/lib/site_perl/Date/Calendar/Year.pm Installing /home/vlefevre/lib/site_perl/Date/Calendar/Profiles.pm Installing /home/vlefevre/lib/site_perl/Date/Calendar/Year.pod Installing /home/vlefevre/lib/site_perl/Date/Calendar/Profiles.pod Installing /home/vlefevre/lib/site_perl/Date/Calc/Object.pod Installing /home/vlefevre/lib/site_perl/Date/Calc/Object.pm Installing /home/vlefevre/lib/site_perl/Date/Calc/PP.pod Installing /home/vlefevre/lib/site_perl/Date/Calc/PP.pm Installing /home/vlefevre/share/man/man3/Date::Calendar::Profiles.3pm Installing /home/vlefevre/share/man/man3/Date::Calc.3pm Installing /home/vlefevre/share/man/man3/Date::Calc::PP.3pm Installing /home/vlefevre/share/man/man3/Date::Calc::Object.3pm Installing /home/vlefevre/share/man/man3/Date::Calendar::Year.3pm Installing /home/vlefevre/share/man/man3/Date::Calendar.3pm It is, however, limited to the XS implementation and can easily be worked around: just use $1 (with quotes) instead of $1. I confirm, thanks. -- Vincent Lefèvre vinc...@vinc17.net - Web: http://www.vinc17.net/ 100% accessible validated (X)HTML - Blog: http://www.vinc17.net/blog/ Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
On 2010-08-11 09:39:43 +0200, Vincent Lefevre wrote: Well, Date::Calc 6.3 solves the problem on my machine: $ echo Oct | perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' 10 $ echo Oct | env -u PERL5LIB perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' Date::Calc::Decode_Month(): argument is not a string at -e line 1, line 1. Hmm... I see. The XS version is also provided by the Debian package, contrary to a CPAN installation when one doesn't explicitly ask for this XS version. -- Vincent Lefèvre vinc...@vinc17.net - Web: http://www.vinc17.net/ 100% accessible validated (X)HTML - Blog: http://www.vinc17.net/blog/ Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
severity 558272 grave thanks I'm raising the severity because of the urgency and to make sure that this bug (an important regression vs lenny, that has been fixed in a new upstream bugfix release for 9 months) is noticed soon enough for squeeze. See other comments below. On 2009-11-27 17:11:01 +0200, Damyan Ivanov wrote: Seems to be fixed in 6.3 upstream release, which is half-prepared in group's SVN repository. TODO from there: - add libdate-calc-xs-perl to B-D-I -- or not, because - t/f000.t checks the version of libdate-calc-xs-perl and errors out if it's different - might lead to problems if an older version is installed (libdate-calc-xs-perl seems to depend on libdate-calc-perl = its own version) - Q: what does United Date::Calc and Date::Pcalc into a single distribution (and the changelog entry below) tell us? we have also libdate-pcalc-perl Any news? Date-Calc-6.3 was released on October 31, 2009. FYI, the latest upstream releases were: Date-Calc-6.0 on 2009-10-08 (currently in Debian/testing) Date-Calc-6.1 on 2009-10-16 Date-Calc-6.2 on 2009-10-16 Date-Calc-6.3 on 2009-10-31 The fact that the releases up to 6.3 are close enough (less than a month between them) seems to imply that they are bugfix releases, and the fact that there have not been releases since 6.3 is probably because version 6.3 is quite stable. In this context, even though Squeeze is frozen, I think that version 6.3 should go to Squeeze. Note: this also requires an upgrade of libcarp-clan-perl to Carp::Clan 6.04 for about the same reasons; versions 6.02 and 6.03 have even been removed from CPAN. Not sure whether the licensing problem 6.04 solves is the cause: https://rt.cpan.org/Public/Bug/Display.html?id=50796 (FYI, I'm still stuck with the old libdate-calc-perl 5.4-5+b1 under Debian/unstable, because of this bug, even though I've tested that Date::Calc 6.3 from CPAN works.) -- Vincent Lefèvre vinc...@vinc17.net - Web: http://www.vinc17.net/ 100% accessible validated (X)HTML - Blog: http://www.vinc17.net/blog/ Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
Package: libdate-calc-perl Version: 6.0-1 Severity: important An important regression: $ echo Oct | perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' Date::Calc::Decode_Month(): argument is not a string at -e line 1, line 1. I've reverted to libdate-calc-perl 5.8-1 and this problem disappeared. -- System Information: Debian Release: squeeze/sid APT prefers oldstable APT policy: (500, 'oldstable'), (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26.5-20080922 (SMP w/2 CPU cores; PREEMPT) Locale: LANG=POSIX, LC_CTYPE=en_US.ISO8859-1 (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/bash Versions of packages libdate-calc-perl depends on: ii libbit-vector-perl7.1-1 Perl module for bit vectors and mo ii libc6 2.10.1-7 GNU C Library: Shared libraries ii libcarp-clan-perl 6.02-1 Perl enhancement to Carp error log ii perl 5.10.1-8 Larry Wall's Practical Extraction ii perl-base [perlapi-5.10.1]5.10.1-8 minimal Perl system libdate-calc-perl recommends no packages. libdate-calc-perl suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#558272: Date::Calc::Decode_Month(): argument is not a string
tags 558272 confirmed thanks -=| Vincent Lefevre, Fri, Nov 27, 2009 at 03:32:32PM +0100 |=- Package: libdate-calc-perl Version: 6.0-1 Severity: important An important regression: $ echo Oct | perl -p -e 'use Date::Calc qw(Decode_Month); s!(\w+)!Decode_Month($1)!e' Date::Calc::Decode_Month(): argument is not a string at -e line 1, line 1. I've reverted to libdate-calc-perl 5.8-1 and this problem disappeared. Seems to be fixed in 6.3 upstream release, which is half-prepared in group's SVN repository. TODO from there: - add libdate-calc-xs-perl to B-D-I -- or not, because - t/f000.t checks the version of libdate-calc-xs-perl and errors out if it's different - might lead to problems if an older version is installed (libdate-calc-xs-perl seems to depend on libdate-calc-perl = its own version) - Q: what does United Date::Calc and Date::Pcalc into a single distribution (and the changelog entry below) tell us? we have also libdate-pcalc-perl -- dam signature.asc Description: Digital signature
