Bug#565495: Invalid logic sourcing init-functions

2010-06-29 Thread Marc Haber
tags #565495 confirmed pending
thanks

On Sat, Jan 16, 2010 at 01:26:36PM +0100, Michael Welle wrote:
> The logic for sourcing the file init-functions seems to be odd:
> 
> if ! [ -x "/lib/lsb/init-functions" ]; then
>   . /lib/lsb/init-functions
> else
>   echo "E: /lib/lsb/init-functions not found, lsb-base (>= 3.0-6) needed"
>   exit 1
> fi
> 
> The file is not sourced if it exists, but has its execute bits set. On
> the other hand the script tries to source the file if it doesn't exist
> at all.

Yes, that's wrong, and works only because Debian doesn't ship the file
with its execute bit set. Fixed in svn.

>  It should be sufficient to just test if the file is readable. Maybe a
>  dependency to the package lsb-base is needful?

I added the dependency, but left the init script code in. I remember
this was needed for some funky reason that I don't remember any more.

Greetings
Marc

-- 
-
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#565495: Invalid logic sourcing init-functions

2010-01-16 Thread Michael Welle
Package: ippl
Version: 1.4.14-11

The logic for sourcing the file init-functions seems to be odd:

if ! [ -x "/lib/lsb/init-functions" ]; then
  . /lib/lsb/init-functions
else
  echo "E: /lib/lsb/init-functions not found, lsb-base (>= 3.0-6) needed"
  exit 1
fi

The file is not sourced if it exists, but has its execute bits set. On
the other hand the script tries to source the file if it doesn't exist
at all. It should be sufficient to just test if the file is
readable. Maybe a dependency to the package lsb-base is needful?

Regards
hmw

-- 
biff4emacsen - A biff-like tool for (X)Emacs
http://www.c0t0d0s0.de/biff4emacsen/biff4emacsen.html
Flood - Your friendly network packet generator
http://www.c0t0d0s0.de/flood/flood.html



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org