Bug#565903: icedove-3.0: Reply to list doesn't place the reply in the replied message's folder

2013-03-09 Thread Carsten Schoenert
forwarded 565903 https://bugzilla.mozilla.org/show_bug.cgi?id=522450
thanks

Hello Emilio,

On Tue, Jan 19, 2010 at 10:28:07PM +0100, Emilio Pozuelo Monfort wrote:
 On 19/01/10 15:57, Emilio Pozuelo Monfort wrote:
 I have 'Place replies in the folder of the message being replied to' option
 enabled. It works if I 'reply' or 'reply to all' to a message, but not if
 I 'reply to list'. When replying to list, the reply is stored in the Sent
 folder, and not in that of the replied message.
 
 I've looked at it and cooked a patch that fixed it for me. I've also
 attached it to the upstream bug report.
 
 Cheers,
 Emilio

 diff -ruNp icedove-3.0/mailnews/compose/src/nsMsgSend.cpp 
 icedove-3.0.new/mailnews/compose/src/nsMsgSend.cpp
 --- icedove-3.0/mailnews/compose/src/nsMsgSend.cpp2009-12-04 
 14:15:26.0 +0100
 +++ icedove-3.0.new/mailnews/compose/src/nsMsgSend.cpp2010-01-19 
 16:14:28.0 +0100
 @@ -2890,6 +2890,7 @@ nsMsgComposeAndSend::InitCompositionFiel
  aType == nsIMsgCompType::Reply ||
  aType == nsIMsgCompType::ReplyAll ||
  aType == nsIMsgCompType::ReplyToGroup ||
 +aType == nsIMsgCompType::ReplyToList ||
  aType == nsIMsgCompType::ReplyToSender ||
  aType == nsIMsgCompType::ReplyToSenderAndGroup ||
  aType == nsIMsgCompType::ReplyWithTemplate )

it seems that no one upstream take care about your patch. And the I
think your reported issue is still there (I haven't tested it).
I took a look into mailnews/compose/src/nsMsgSend.cpp and this file
looks for Icedove 17.0.1 like this.

2792   // Only check whether the user wants the message in the original 
message
2793   // folder if the msgcomptype is some kind of a reply.
2794   if (!aOriginalMsgURI.IsEmpty()  (
2795 aType == nsIMsgCompType::Reply ||
2796 aType == nsIMsgCompType::ReplyAll ||
2797 aType == nsIMsgCompType::ReplyToGroup ||
2798 aType == nsIMsgCompType::ReplyToSender ||
2799 aType == nsIMsgCompType::ReplyToSenderAndGroup ||
2800 aType == nsIMsgCompType::ReplyWithTemplate )
2801  )

This issue must be fixed by mozilla, in the between time we made a own
patch for one of the next releases of icedove. Localy it works right
now. I think Chris will implement this in the upcomming 17.0.3 version.

Guido has pushed this new patch upstream to mozilla, so hopefully it
will applied in the near time in one of the next releases.

Thanks for your good pre work! :)

Regards
Carsten


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#565903: icedove-3.0: Reply to list doesn't place the reply in the replied message's folder

2010-01-19 Thread Emilio Pozuelo Monfort
Package: icedove-3.0
Version: 3.0-2
Severity: normal

Hi,

I have 'Place replies in the folder of the message being replied to' option
enabled. It works if I 'reply' or 'reply to all' to a message, but not if
I 'reply to list'. When replying to list, the reply is stored in the Sent
folder, and not in that of the replied message.

I've found this upstream report:
https://bugzilla.mozilla.org/show_bug.cgi?id=522450

Cheers,
Emilio

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686 (SMP w/2 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages icedove-3.0 depends on:
ii  debianutils 3.2.2Miscellaneous utilities specific t
ii  fontconfig  2.8.0-2  generic font configuration library
ii  libasound2  1.0.21a-1shared library for ALSA applicatio
ii  libatk1.0-0 1.28.0-1 The ATK accessibility toolkit
ii  libc6   2.10.2-5 Embedded GNU C Library: Shared lib
ii  libcairo2   1.8.8-2  The Cairo 2D vector graphics libra
ii  libdbus-1-3 1.2.16-2 simple interprocess messaging syst
ii  libdbus-glib-1-20.82-2   simple interprocess messaging syst
ii  libfontconfig1  2.8.0-2  generic font configuration library
ii  libfreetype62.3.11-1 FreeType 2 font engine, shared lib
ii  libgcc1 1:4.4.2-9GCC support library
ii  libglib2.0-02.22.3-2 The GLib library of C routines
ii  libgtk2.0-0 2.18.5-1 The GTK+ graphical user interface 
ii  libjpeg62   6b-15The Independent JPEG Group's JPEG 
ii  libnspr4-0d 4.8.2-1  NetScape Portable Runtime Library
ii  libnss3-1d  3.12.5-1 Network Security Service libraries
ii  libpango1.0-0   1.26.2-1 Layout and rendering of internatio
ii  libsqlite3-03.6.21-2 SQLite 3 shared library
ii  libstartup-notification 0.10-1   library for program launch feedbac
ii  libstdc++6  4.4.2-9  The GNU Standard C++ Library v3
ii  libx11-62:1.3.2-1X11 client-side library
ii  libxrender1 1:0.9.5-1X Rendering Extension client libra
ii  libxt6  1:1.0.7-1X11 toolkit intrinsics library
ii  psmisc  22.10-1  utilities that use the proc file s
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages icedove-3.0 recommends:
ii  libbonobo2-0  2.24.2-1   Bonobo CORBA interfaces library
ii  libgconf2-4   2.28.0-1   GNOME configuration database syste
ii  libgnome2-0   2.28.0-1   The GNOME library - runtime files
ii  libgnomevfs2-01:2.24.2-1 GNOME Virtual File System (runtime
ii  liborbit2 1:2.14.17-2libraries for ORBit2 - a CORBA ORB
ii  libpopt0  1.15-1 lib for parsing cmdline parameters
ii  myspell-en-us [myspell-di 1:3.2.0~beta-1 English_american dictionary for my
ii  myspell-es [myspell-dicti 1.10-9 Spanish dictionary for myspell

Versions of packages icedove-3.0 suggests:
ii  latex-xft-fonts   1.6.5-1TrueType versions of some TeX font
ii  libthai0  0.1.12-2   Thai language support library

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#565903: icedove-3.0: Reply to list doesn't place the reply in the replied message's folder

2010-01-19 Thread Emilio Pozuelo Monfort

On 19/01/10 15:57, Emilio Pozuelo Monfort wrote:

I have 'Place replies in the folder of the message being replied to' option
enabled. It works if I 'reply' or 'reply to all' to a message, but not if
I 'reply to list'. When replying to list, the reply is stored in the Sent
folder, and not in that of the replied message.


I've looked at it and cooked a patch that fixed it for me. I've also attached it 
to the upstream bug report.


Cheers,
Emilio
diff -ruNp icedove-3.0/mailnews/compose/src/nsMsgSend.cpp icedove-3.0.new/mailnews/compose/src/nsMsgSend.cpp
--- icedove-3.0/mailnews/compose/src/nsMsgSend.cpp	2009-12-04 14:15:26.0 +0100
+++ icedove-3.0.new/mailnews/compose/src/nsMsgSend.cpp	2010-01-19 16:14:28.0 +0100
@@ -2890,6 +2890,7 @@ nsMsgComposeAndSend::InitCompositionFiel
 aType == nsIMsgCompType::Reply ||
 aType == nsIMsgCompType::ReplyAll ||
 aType == nsIMsgCompType::ReplyToGroup ||
+aType == nsIMsgCompType::ReplyToList ||
 aType == nsIMsgCompType::ReplyToSender ||
 aType == nsIMsgCompType::ReplyToSenderAndGroup ||
 aType == nsIMsgCompType::ReplyWithTemplate )