Bug#568511: Please add module to monitor interface package drops

2010-09-17 Thread Jerome Warnier
tags 568511 + patch
forwarded 568511 http://munin-monitoring.org/ticket/967
thanks

Which I actually already did for you now.
Hope it helps.




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#568511: Please add module to monitor interface package drops

2010-05-15 Thread Tom Feiner
Hi Petter,

Thanks for the bug report.

I'm trying to keep the munin package as patch free as possible.

I think the correct way to propose a new patch as you suggest here is:

1. Add it to muninexchange [1].
2. Discuss it in the munin mailing list and see if upstream authors agree with
the idea and incorporate it in the munin package.

Adding a plugin only in the debian package will not serve the munin community
as best as possible, as it will only be available for debian users.

Regards,
Tom Feiner

[1] http://muninexchange.projects.linpro.no/



signature.asc
Description: OpenPGP digital signature


Bug#568511: Please add module to monitor interface package drops

2010-05-15 Thread Petter Reinholdtsen
[Tom Feiner]
 I think the correct way to propose a new patch as you suggest here is:
 
 1. Add it to muninexchange [1].
 2. Discuss it in the munin mailing list and see if upstream authors agree with
 the idea and incorporate it in the munin package.
 
 Adding a plugin only in the debian package will not serve the munin community
 as best as possible, as it will only be available for debian users.

Sound good to me.  Please go ahead and do it that way if you see it as
the best way to get this issue fixed.  My priority is to get the issue
fixed in Debian, to make sure the stats are available out of the box
in the future. :)

Happy hacking,
-- 
PEtter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#568511: Please add module to monitor interface package drops

2010-02-05 Thread Petter Reinholdtsen

Package: munin-node
Version: 1.2.6-10
Severity: wishlist

I ran into a problem with dropped packages on a LTSP server with many
NFS clients.  It would be nice if munin would graph the number of
dropped packages as well as throughtput and error packages.

It is trivial to implement by changing the if_err script, using the
column to the right of the error package count.

Here is a patch to implement it.  Please provide such script as
if_drop, and make it autoconfigure like if_err. :)


--- if_err_eth0 2009-11-25 11:38:05.0 +0100
+++ if_drop_eth02010-02-05 10:43:10.0 +0100
@@ -63,7 +63,7 @@
 #%# family=auto
 #%# capabilities=autoconf suggest

-INTERFACE=`basename $0 | sed 's/^if_err_//g'`
+INTERFACE=`basename $0 | sed 's/^if_drop_//g'`

 if [ $1 = autoconf ]; then
if [ -r /proc/net/dev ]; then
@@ -86,11 +86,11 @@

 if [ $1 = config ]; then
echo graph_order rcvd trans
-   echo graph_title $INTERFACE errors
+   echo graph_title $INTERFACE drops
echo 'graph_args --base 1000'
echo 'graph_vlabel packets in (-) / out (+) per ${graph_period}'
echo 'graph_category network'
-   echo graph_info This graph shows the amount of errors on the 
$INTERFACE network interface.
+   echo graph_info This graph shows the amount of drops on the $INTERFACE 
network interface.
echo 'rcvd.label packets'
 echo 'rcvd.type COUNTER'
 echo 'rcvd.graph no'
@@ -107,6 +107,6 @@
 'BEGIN { gsub(/\./, \\., interface) } \
 $1 ~ ^ interface : {
 split($0, a, /: */); $0 = a[2]; \
-print rcvd.value  $3 \ntrans.value  $11 \
+print rcvd.value  $4 \ntrans.value  $12 \
 }' \
 /proc/net/dev

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org