Bug#574604: [tuxonice-userui] initramfs generated initrd misses tuxonice-userui

2010-08-26 Thread Frédéric Boiteux
Hello,

I'm agree with the proposed solution, the warning message can be wrong
and confusing (telling it installs an initrd for a TuxOnIce-disabled
kernel whereas it is actually enabled) and putting TuxOnIce's user UI
things in initrd for TOI-disabled kernels is harmless (and people
installing this package surely want to have this software in kernels
which can use them).

I also wonder if the
script /usr/share/initramfs-tools/hooks/tuxonice_userui should also
copy the /etc/splash whole directory if it exists ?

regards,

-- 
Frédéric Boiteux



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#574604: [tuxonice-userui] initramfs generated initrd misses tuxonice-userui

2010-03-19 Thread Kiro Zimmer
Package: tuxonice-userui
Version: 1.0-1
Severity: normal

Hello,

if the actual running kernel has no tuxonice-support and the kernel for 
which the initrd should be generated has tuxonice static compiled in 
(not as a module!) then the tuxonice-userui is not assembled into the 
initrd.

As solution I suggest to drop the tuxonice detection in file
/usr/share/initramfs-tools/hooks/tuxonice_userui .
This should not harm any setup, because on boot just nothing happens if 
the kernel has no tuxonice support.

The first part of the detection is wrong anyways, running a 
tuxonice-capable kernel doesnt mean the new one is also capable.

regards, Kiro

--- System information. ---
Architecture: amd64
Kernel:   Linux 2.6.31-amd64
--- tuxonice_userui_old	2010-03-19 11:25:05.0 +0100
+++ tuxonice_userui	2010-03-19 11:32:41.0 +0100
@@ -17,20 +17,6 @@
 
 . /usr/share/initramfs-tools/hook-functions
 
-TUXONICE_ENABLED=/sys/power/tuxonice/user_interface/enabled
-
-# Don't do  anything if the  kernel does not  support tuxonice_userui,
-# nor the module is there
-if [ -f ${TUXONICE_ENABLED} ]; then
-if [ `cat ${TUXONICE_ENABLED}` = 0 ]; then
-	echo TuxOnIce user interface is disabled, skipping...
-	exit 0
-fi
-elif [ ! -f ${MODULESDIR}/kernel/power/tuxonice_userui.ko ]; then
-echo This kernel does not seem to support TuxOnIce user interface, skipping...
-exit 0
-fi
-
 # Add the module and its  dependencies and load it automatically if it
 # exists
 force_load tuxonice_userui


signature.asc
Description: This is a digitally signed message part.