Bug#574798: zlib: Please ship minizip as a shared library
Michael Gilbert wrote: > On Mon, May 12, 2014 at 4:05 PM, Mark Brown wrote: Please discuss this with upstream. >>> >>> If you have bug reports in upstream's libminizip support, I'm happy to >>> work on them upstream. Last time I checked, it Just Worked (tm). > > I'm also willing to help if needed. Chromium currently uses embeded > minizip, and I did this work to be able to link against it. Let's try to add symbol versioning. (Feel free to contact me privately if that helps coordinate work.) I don't think that blocks packaging what already exists, though. Thanks, Jonathan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#574798: zlib: Please ship minizip as a shared library
On Mon, May 12, 2014 at 4:05 PM, Mark Brown wrote: >> > Please discuss this with upstream. > >> If you have bug reports in upstream's libminizip support, I'm happy to >> work on them upstream. Last time I checked, it Just Worked (tm). I'm also willing to help if needed. Chromium currently uses embeded minizip, and I did this work to be able to link against it. >> I don't think it would make sense to go upstream and say "Mark Brown >> is not happy with how contrib/minizip deals with the shared library. >> Discuss" without further details. ;-) > > Well, figuring out if they realise it is building a shared library and > understand the stable ABI requirements that Unix like systems have would > be the main thing I guess. The comments in MiniZip64_info.txt about the > changes for 64 bit are a bit worrying here but seem to mostly refer to > the on disk format rather than the interfaces for users of the library. Fedora has shipped minizip packages [0] since version 19, which has been out for almost a year now, and they seem to be able to make it work, which probably indicates that upstream isn't being too disruptive with respect to the ABI now. Also, it sounds like the minizip64 changes are now in the past, and there isn't anything obvious that would be so disruptive in the near future anyway. Best wishes, Mike [0] https://apps.fedoraproject.org/packages/minizip -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#574798: zlib: Please ship minizip as a shared library
Copying message to the main bug report.
On Sun, May 11, 2014 at 7:47 PM, Mark Brown wrote:
>> Merged 574798 709803
>
> Please always CC a plain text version of the explanation for why bug
> manipulation is happening to the relevant package manintainer especially
> if it involves a reassignment. minizip has been in Debian for some
> considerable time as zlib-bin. The bug it's merged with is for making
> it a zip alternative which is something different and would rely on a
> compatible command line interface (something that it doesn't have right
> now).
I was in the process of putting together a patch addressing both of
these requests, and hadn't yet finished this mail, which has the
desired context.
I'm attaching a proposed patch that adds support for building the
requested minizip packages.
Best wishes,
Mike
diff -Nru zlib-1.2.8.dfsg/debian/changelog zlib-1.2.8.dfsg/debian/changelog
--- zlib-1.2.8.dfsg/debian/changelog 2013-05-03 16:00:51.0 +
+++ zlib-1.2.8.dfsg/debian/changelog 2014-05-12 00:00:10.0 +
@@ -1,3 +1,10 @@
+zlib (1:1.2.8.dfsg-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Build minizip packages (closes: #574798).
+
+ -- Michael Gilbert Sun, 11 May 2014 22:27:45 +
+
zlib (1:1.2.8.dfsg-1) unstable; urgency=low
* New upstream release.
diff -Nru zlib-1.2.8.dfsg/debian/control zlib-1.2.8.dfsg/debian/control
--- zlib-1.2.8.dfsg/debian/control 2013-05-03 15:32:22.0 +
+++ zlib-1.2.8.dfsg/debian/control 2014-05-12 00:23:44.0 +
@@ -4,7 +4,7 @@
Maintainer: Mark Brown
Standards-Version: 3.9.4
Homepage: http://zlib.net/
-Build-Depends: debhelper (>= 8.1.3~), binutils (>= 2.18.1~cvs20080103-2) [mips mipsel], gcc-multilib [amd64 i386 kfreebsd-amd64 mips mipsel powerpc ppc64 s390 sparc s390x], dpkg-dev (>= 1.16.1)
+Build-Depends: debhelper (>= 8.1.3~), autoconf, binutils (>= 2.18.1~cvs20080103-2) [mips mipsel], gcc-multilib [amd64 i386 kfreebsd-amd64 mips mipsel powerpc ppc64 s390 sparc s390x], dpkg-dev (>= 1.16.1)
Package: zlib1g
Architecture: any
@@ -43,13 +43,13 @@
when debugging applications which use zlib.
Package: zlib-bin
-Section: utils
+Section: oldlibs
+Priority: extra
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: compression library - sample programs
- Some generally useful sample programs from the contrib directory.
- Includes a "mini" implementation of `zip' and `unzip' called
- `minizip' and `miniunzip' respectively.
+Depends: minizip
+Description: compression library - transitional package
+ zlib is a library implementing the deflate compression method found
+ in gzip and PKZIP. This is a transitional package to minizip.
Package: zlib1g-udeb
XC-Package-Type: udeb
@@ -120,3 +120,33 @@
zlib is a library implementing the deflate compression method found
in gzip and PKZIP. This package includes the development support
files for building n32 applications.
+
+Package: minizip
+Section: utils
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Replaces: zlib-bin (<< 1:1.2.8.dfsg-1.1)
+Conflicts: zlib-bin (<< 1:1.2.8.dfsg-1.1)
+Description: compression library - minizip tools
+ zlib is a library implementing the deflate compression method found
+ in gzip and PKZIP. This package includes a "mini" implementation
+ of `zip' and `unzip' called `minizip' and `miniunzip' respectively.
+
+Package: libminizip1
+Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: compression library - minizip library
+ zlib is a library implementing the deflate compression method found
+ in gzip and PKZIP. This package includes the minizip library.
+
+Package: libminizip-dev
+Architecture: any
+Multi-Arch: same
+Section: libdevel
+Depends: ${misc:Depends}, libminizip1 (= ${binary:Version})
+Description: compression library - minizip development files
+ zlib is a library implementing the deflate compression method found
+ in gzip and PKZIP. This package includes the development support
+ files for the minizip library.
diff -Nru zlib-1.2.8.dfsg/debian/libminizip1.install zlib-1.2.8.dfsg/debian/libminizip1.install
--- zlib-1.2.8.dfsg/debian/libminizip1.install 1970-01-01 00:00:00.0 +
+++ zlib-1.2.8.dfsg/debian/libminizip1.install 2014-05-11 23:17:39.0 +
@@ -0,0 +1 @@
+usr/lib/*/libminizip.so.*
diff -Nru zlib-1.2.8.dfsg/debian/libminizip-dev.install zlib-1.2.8.dfsg/debian/libminizip-dev.install
--- zlib-1.2.8.dfsg/debian/libminizip-dev.install 1970-01-01 00:00:00.0 +
+++ zlib-1.2.8.dfsg/debian/libminizip-dev.install 2014-05-11 23:30:44.0 +
@@ -0,0 +1,4 @@
+usr/lib/*/libminizip.a
+usr/lib/*/libminizip.so
+usr/lib/*/pkgconfig/minizip.pc
+usr/include/minizip
diff -Nru zlib-1.2.8.dfsg/debian/minizip.install zlib-1.2.8.dfsg/debian/minizip.install
--- zlib-1.2.8.dfsg/debian/minizip.install 1970-01-01 00:00:00.0 +
+++ zlib-1.2.8.dfsg/debian/minizip.i
Bug#574798: zlib: Please ship minizip as a shared library
Sébastien Barthélemy wrote: > Is there any progress with this? > Jonathan, have got in touch with minizip authors? No, I haven’t found time to work on it yet. You might want to subscribe to this list: http://zlib.net/mailman/listinfo/zlib-devel_madler.net > I'm willing to package collada-dom (ITP #589152) which also needs libminizip. Part of my reason for putting this off so long is lack of a small example program to test with. collaba-dom looks small relative to chromium, so this is welcome indeed. I’ll try out collaba-dom this weekend. Any help would be much appreciated. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#574798: zlib: Please ship minizip as a shared library
Is there any progress with this? Jonathan, have got in touch with minizip authors? I'm willing to package collada-dom (ITP #589152) which also needs libminizip. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#574798: zlib: Please ship minizip as a shared library
Mark Brown wrote: > Please work with upstream on this (as the Chrome guys really ought > to have done...). This is not something that should be done as a > Debian local change and I don't feel I'd be adding anything to the > process compared to you working with upstream. Makes sense. Thank you for your thoughtfulness. For reference: Fedora’s minizip library package was introduced in August, 2007 [1]. They use automake to build the package [2], so probably what will be required here is to rewrite their Makefile.am to fit in with upstream’s build system. [1] http://cvs.fedoraproject.org/viewvc/rpms/zlib/devel/zlib.spec?view=co [2] http://cvs.fedoraproject.org/viewvc/rpms/zlib/devel/zlib-1.2.3-autotools.patch?content-type=text/plain&view=co -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#574798: zlib: Please ship minizip as a shared library
On 21 Mar 2010, at 05:16, Jonathan Nieder wrote: Source: zlib Version: 1:1.2.3.4.dfsg-3 Severity: wishlist The Chromium browser has its own copy of minizip. It would be nice if it could use libminizip.so.1 from a new libminizip1 package instead. Thoughts? Do you think this worth working on? (If so, I can mock something up.) Please work with upstream on this (as the Chrome guys really ought to have done...). This is not something that should be done as a Debian local change and I don't feel I'd be adding anything to the process compared to you working with upstream. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#574798: zlib: Please ship minizip as a shared library
Source: zlib Version: 1:1.2.3.4.dfsg-3 Severity: wishlist The Chromium browser has its own copy of minizip. It would be nice if it could use libminizip.so.1 from a new libminizip1 package instead. Thoughts? Do you think this worth working on? (If so, I can mock something up.) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
