Bug#576786: open-iscsi: Unable to login with initramfs script

2010-04-07 Thread Ritesh Raj Sarraf
tags 576786 +pending
thanks


Thank you Aurel. I have applied it. Will be part of the next upload.


Regards,
Ritesh


On Wednesday 07 Apr 2010 15:50:40 Aurelien Jarno wrote:
> > Can you have a look at 525053 ?
> >
> > 
> >
> > What you are proposing seems to be part of an older problem.
> >
> > 
> > 
> 
> Indeed, the brokenness has been introduced by this patch, it looks like
> the two proposed patches have been applied, and they conflict, hence the
> problem I observed.
> 
> In that case the best is to revert the first proposed patch. It can be
> done with the new patch I attached to this mail.

-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."


signature.asc
Description: This is a digitally signed message part.


Bug#576786: open-iscsi: Unable to login with initramfs script

2010-04-07 Thread Aurelien Jarno
Ritesh Raj Sarraf a écrit :
> Hello Aurel,
> 
> Can you have a look at 525053 ?
> 
> What you are proposing seems to be part of an older problem.
> 
> 

Indeed, the brokenness has been introduced by this patch, it looks like
the two proposed patches have been applied, and they conflict, hence the
problem I observed.

In that case the best is to revert the first proposed patch. It can be
done with the new patch I attached to this mail.



-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net
diff -u open-iscsi-2.0.871.3/debian/extra/initramfs.local-top open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
--- open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
+++ open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
@@ -42,22 +42,6 @@
 		ISCSI_TARGET_GROUP=1
 	fi
 
-	if [ ! -z "$ISCSI_USERNAME" ]; then
-		ISCSI_USERNAME="-u $ISCSI_USERNAME"
-	fi
-
-	if [ ! -z "$ISCSI_PASSWORD" ]; then
-		ISCSI_PASSWORD="-w $ISCSI_PASSWORD"
-	fi
-
-	if [ ! -z "$ISCSI_IN_USERNAME" ]; then
-		ISCSI_IN_USERNAME="-U $ISCSI_IN_USERNAME"
-	fi
-
-	if [ ! -z "$ISCSI_IN_PASSWORD" ]; then
-		ISCSI_IN_PASSWORD="-W $ISCSI_IN_PASSWORD"
-	fi
-
 	iscsistart -i $ISCSI_INITIATOR -t $ISCSI_TARGET_NAME	\
 		   -g $ISCSI_TARGET_GROUP -a $ISCSI_TARGET_IP	\
 		   -p $ISCSI_TARGET_PORT \


Bug#576786: open-iscsi: Unable to login with initramfs script

2010-04-07 Thread Ritesh Raj Sarraf
Hello Aurel,

Can you have a look at 525053 ?

What you are proposing seems to be part of an older problem.


Regards,
Rietsh


On Wednesday 07 Apr 2010 13:24:11 Aurelien Jarno wrote:
> The initramfs script is not able to login to the target when a
> login/password is used. This is due to a bug in the script, the -u
> or -w parameters are passed twice to iscsistart. When iscsistart is
> called, ISCSI_USERNAME and ISCSI_PASSWORD already contain -u or -w.
> 
> The patch below fixes the problem.
> 
> diff -u open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
> open-iscsi-2.0.871.3/debian/extra/initramfs.local-top ---
> open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
> +++ open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
> @@ -61,10 +61,8 @@
> iscsistart -i $ISCSI_INITIATOR -t $ISCSI_TARGET_NAME\
>-g $ISCSI_TARGET_GROUP -a $ISCSI_TARGET_IP   \
>-p $ISCSI_TARGET_PORT \
> -  ${ISCSI_USERNAME:+-u "$ISCSI_USERNAME"}  \
> -  ${ISCSI_PASSWORD:+-w "$ISCSI_PASSWORD"}  \
> -  ${ISCSI_IN_USERNAME:+-U "$ISCSI_IN_USERNAME"}\
> -  ${ISCSI_IN_PASSWORD:+-W "$ISCSI_IN_PASSWORD"}
> +  ${ISCSI_USERNAME} ${ISCSI_PASSWORD} \
> +  ${ISCSI_IN_USERNAME} ${ISCSI_IN_PASSWORD}
>  }
>  
>  parse_iscsi_ops ()

-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."


signature.asc
Description: This is a digitally signed message part.


Bug#576786: open-iscsi: Unable to login with initramfs script

2010-04-07 Thread Aurelien Jarno
Package: open-iscsi
Version: 2.0.871.3-1
Severity: normal
Tags: patch

The initramfs script is not able to login to the target when a
login/password is used. This is due to a bug in the script, the -u
or -w parameters are passed twice to iscsistart. When iscsistart is
called, ISCSI_USERNAME and ISCSI_PASSWORD already contain -u or -w.

The patch below fixes the problem.

diff -u open-iscsi-2.0.871.3/debian/extra/initramfs.local-top 
open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
--- open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
+++ open-iscsi-2.0.871.3/debian/extra/initramfs.local-top
@@ -61,10 +61,8 @@
iscsistart -i $ISCSI_INITIATOR -t $ISCSI_TARGET_NAME\
   -g $ISCSI_TARGET_GROUP -a $ISCSI_TARGET_IP   \
   -p $ISCSI_TARGET_PORT \
-  ${ISCSI_USERNAME:+-u "$ISCSI_USERNAME"}  \
-  ${ISCSI_PASSWORD:+-w "$ISCSI_PASSWORD"}  \
-  ${ISCSI_IN_USERNAME:+-U "$ISCSI_IN_USERNAME"}\
-  ${ISCSI_IN_PASSWORD:+-W "$ISCSI_IN_PASSWORD"}
+  ${ISCSI_USERNAME} ${ISCSI_PASSWORD} \
+  ${ISCSI_IN_USERNAME} ${ISCSI_IN_PASSWORD}
 }
 
 parse_iscsi_ops ()


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages open-iscsi depends on:
ii  libc6 2.11-0exp2 Embedded GNU C Library: Shared lib

open-iscsi recommends no packages.

open-iscsi suggests no packages.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org