Bug#579893: conky-all: add support for xmms2 and other players
What's more, I'd like to suggest to change the names of conky packages. The names, conky-std and conky-all, can lead users to think the latter is greater. Since you are planning to enable more features in the package for main, do you mind rename them to something like conky-main and conky-contrib? Transitional package is needed. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
On Wed, Aug 10, 2011 at 10:55 PM, Aron Xu happyaron...@gmail.com wrote: I think it depends on what additional dependencies will be pulled in when adding the features. This requires a lot of testing, by building the package with different settings again and again. If the dependency is fine then there is no reason not to include the feature even if they have relatively smaller user base. With my proposed changes (I'll upload an updated version of conky asap to expo.d.n), the only additional dependency for conky-std is libimlib2 (+ the dependencies introduced by adding audacious and xmms2 support). What's more, I'd like to suggest to change the names of conky packages. The names, conky-std and conky-all, can lead users to think the latter is greater. Since you are planning to enable more features in the package for main, do you mind rename them to something like conky-main and conky-contrib? Transitional package is needed. Hmmm...conky-main and conky-contrib would make less sense to Ubuntu users than the current conky-std and conky-all packages. I tend to think that conky-all refers to conky with all features enabled, and conky-std as conky with the standard feature set available, i.e. similar to what you would end up with if you ran ./configure with no other arguments (although I suppose conky-std is a bit different now, with multiple additional features enabled). In that context, I'd personally prefer the current naming scheme (but I'll remove the recommendation in conky-all's package description to install that package if the user is uncertain). I'm still open to discussion though, and I'll gladly change the names of those packages if we can come up with a set of names that makes sense for both Debian and Ubuntu, and describe those packages better than the current names. - Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
On Thu, Aug 11, 2011 at 11:34, Vincent Cheng vincentc1...@gmail.com wrote: On Tue, Aug 9, 2011 at 8:45 PM, Aron Xu happyaron...@gmail.com wrote: reassign 579893 src:conky retitle 579893 src:conky: enable more features in conky packages thanks I think in conky-std, there are too few features enabled, however conky-all is in contrib, this gives main users no chance to have more features usable (curl, rss, etc). So I reassign and retitle this report to a more general one. There are two ways of enabling more features for main users, by adding a new binary, or changing conky-std. This is up to the maintainer's decision, so I haven't created the patch. Comments? I agree (in fact, I was planning to address this issue in a future upload). Looking at conky's popcon scores, there are relatively few conky-std users compared to conky-all (61 vs 2102), so instead of adding yet another conky binary, I'd rather just enable more features in conky-std, i.e. the ones that are more commonly used. Features that have very specific uses, or are only useful to a small subset of conky users (e.g. nvidia support, eve support, IBM/lenovo support, etc.) won't go in conky-std. I think it depends on what additional dependencies will be pulled in when adding the features. This requires a lot of testing, by building the package with different settings again and again. If the dependency is fine then there is no reason not to include the feature even if they have relatively smaller user base. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
On Tue, Aug 9, 2011 at 8:45 PM, Aron Xu happyaron...@gmail.com wrote: reassign 579893 src:conky retitle 579893 src:conky: enable more features in conky packages thanks I think in conky-std, there are too few features enabled, however conky-all is in contrib, this gives main users no chance to have more features usable (curl, rss, etc). So I reassign and retitle this report to a more general one. There are two ways of enabling more features for main users, by adding a new binary, or changing conky-std. This is up to the maintainer's decision, so I haven't created the patch. Comments? I agree (in fact, I was planning to address this issue in a future upload). Looking at conky's popcon scores, there are relatively few conky-std users compared to conky-all (61 vs 2102), so instead of adding yet another conky binary, I'd rather just enable more features in conky-std, i.e. the ones that are more commonly used. Features that have very specific uses, or are only useful to a small subset of conky users (e.g. nvidia support, eve support, IBM/lenovo support, etc.) won't go in conky-std. As for conky-all's more player support, I have created the patch to enable xmms2 and audacious, no BMPx support because it's not in Debian. This patch also enable -O3 by default (the old one was -O2). It builds fine on latest amd64 sid. diff -ru debian-old/changelog debian/changelog --- debian-old/changelog 2011-08-10 03:38:12.362932245 + +++ debian/changelog 2011-08-10 03:36:52.778933721 + @@ -1,3 +1,10 @@ +conky (1.8.1-3) UNRELEASED; urgency=low + + * Enable xmms2 and audacious support. + * Use -O3 by default. + + -- Aron Xu a...@debian.org Wed, 10 Aug 2011 11:33:09 +0800 + conky (1.8.1-2) unstable; urgency=low * Add build dependency on libxnvctrl-dev | nvidia-settings to keep Conky diff -ru debian-old/control debian/control --- debian-old/control 2011-08-10 03:38:12.362932245 + +++ debian/control 2011-08-10 03:37:25.018928935 + @@ -10,7 +10,7 @@ libiw-dev [linux-any], libasound2-dev [linux-any], libkvm-dev [kfreebsd-any], libdevstat-dev [kfreebsd-any], libxnvctrl-dev [i386 amd64] | nvidia-settings [i386 amd64], - libncurses5-dev + libncurses5-dev, libxmmsclient-dev, audacious-dev Homepage: http://conky.sourceforge.net/ Standards-Version: 3.9.2 Vcs-Svn: svn://svn.debian.org/svn/collab-maint/deb-maint/conky/trunk Only in debian/patches: fix-xmms2.patch diff -ru debian-old/rules debian/rules --- debian-old/rules 2011-08-10 03:38:12.362932245 + +++ debian/rules 2011-08-10 03:38:02.918931878 + @@ -17,7 +17,7 @@ ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) CFLAGS += -O0 else - CFLAGS += -O2 + CFLAGS += -O3 endif ifeq ($(DEB_HOST_ARCH_OS),linux) @@ -70,7 +70,7 @@ ../configure $(COMMON_CONFIGURE_FLAGS) \ --enable-imlib2 --enable-rss --enable-weather-xoap \ --enable-eve --enable-lua-cairo --enable-lua-imlib2 \ - --disable-static --enable-argb \ + --disable-static --enable-argb --enable-xmms2 --enable-audacious \ $(LINUX_CONF_ARGS_ALL) $(ENABLE_NVIDIA) touch $@ -- Regards, Aron Xu Thanks for the patch! :) - Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
BMPx has gone from Debian for long, so it does not bother. MOC and MPD is rather popular, but I'm sure XMMS2 and Audacious have many users, especially for latter one I know many users of it in real life. (XMMS2 is more geeky and powerful, but the frontends of it does not support CJK well.) I guess solving this bug needs another change on how we split the package? I haven't tested to build conky with the options enabled to see what dependencies they'll pull in at the time writing this email, but only by doing that we can determine what we need to do, though. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
After build conky with xmms2 and audacious support, it appears nothing is in our way of adding the support in conky-all, no need for reorganizing the package. By passing --enable-xmms2, new dependency introduced is llibxmmsclient6, it's 324k on amd64 and only depends on libc itself. By passing --enable-audacious, new dependency introduced are libaudclient2 (104k on amd64) and libdbus-glib-1-2 (368k on amd64). Enabling Audacious support does introduce some more symbols, but they are all in libglib2.0-0, and conky-all is depending on it already. So I believe it's okay to add support for xmms2 and audacious to conky-all without bothering MOC/MPD users. What do you think about it? Because there are more tweaks I planned to test out, so I don't submit a patch this time, will do it when I finished testing. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
reassign 579893 src:conky retitle 579893 src:conky: enable more features in conky packages thanks I think in conky-std, there are too few features enabled, however conky-all is in contrib, this gives main users no chance to have more features usable (curl, rss, etc). So I reassign and retitle this report to a more general one. There are two ways of enabling more features for main users, by adding a new binary, or changing conky-std. This is up to the maintainer's decision, so I haven't created the patch. Comments? As for conky-all's more player support, I have created the patch to enable xmms2 and audacious, no BMPx support because it's not in Debian. This patch also enable -O3 by default (the old one was -O2). It builds fine on latest amd64 sid. diff -ru debian-old/changelog debian/changelog --- debian-old/changelog2011-08-10 03:38:12.362932245 + +++ debian/changelog2011-08-10 03:36:52.778933721 + @@ -1,3 +1,10 @@ +conky (1.8.1-3) UNRELEASED; urgency=low + + * Enable xmms2 and audacious support. + * Use -O3 by default. + + -- Aron Xu a...@debian.org Wed, 10 Aug 2011 11:33:09 +0800 + conky (1.8.1-2) unstable; urgency=low * Add build dependency on libxnvctrl-dev | nvidia-settings to keep Conky diff -ru debian-old/control debian/control --- debian-old/control 2011-08-10 03:38:12.362932245 + +++ debian/control 2011-08-10 03:37:25.018928935 + @@ -10,7 +10,7 @@ libiw-dev [linux-any], libasound2-dev [linux-any], libkvm-dev [kfreebsd-any], libdevstat-dev [kfreebsd-any], libxnvctrl-dev [i386 amd64] | nvidia-settings [i386 amd64], - libncurses5-dev + libncurses5-dev, libxmmsclient-dev, audacious-dev Homepage: http://conky.sourceforge.net/ Standards-Version: 3.9.2 Vcs-Svn: svn://svn.debian.org/svn/collab-maint/deb-maint/conky/trunk Only in debian/patches: fix-xmms2.patch diff -ru debian-old/rules debian/rules --- debian-old/rules2011-08-10 03:38:12.362932245 + +++ debian/rules2011-08-10 03:38:02.918931878 + @@ -17,7 +17,7 @@ ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) CFLAGS += -O0 else - CFLAGS += -O2 + CFLAGS += -O3 endif ifeq ($(DEB_HOST_ARCH_OS),linux) @@ -70,7 +70,7 @@ ../configure $(COMMON_CONFIGURE_FLAGS) \ --enable-imlib2 --enable-rss --enable-weather-xoap \ --enable-eve --enable-lua-cairo --enable-lua-imlib2 \ - --disable-static --enable-argb \ + --disable-static --enable-argb --enable-xmms2 --enable-audacious \ $(LINUX_CONF_ARGS_ALL) $(ENABLE_NVIDIA) touch $@ -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
I think the relative popularity of the players compared to moc and mpd would provide the best justification to its inclusion. My only experience is with xmms2, but BMPx is dead.
Bug#579893: conky-all: add support for xmms2 and other players
Please build conky-all with support for xmms2, audacious, and bmpx. Why? C. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#579893: conky-all: add support for xmms2 and other players
Package: conky-all Version: 1.8.0-1 Severity: wishlist Please build conky-all with support for xmms2, audacious, and bmpx. The current package wasn't built with these options enabled. -- System Information: Debian Release: squeeze/sid APT prefers testing-proposed-updates APT policy: (500, 'testing-proposed-updates'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-trunk-amd64 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages conky-all depends on: ii libasound21.0.22-2 shared library for ALSA applicatio ii libc6 2.10.2-6 Embedded GNU C Library: Shared lib ii libcairo2 1.8.10-4 The Cairo 2D vector graphics libra ii libcurl3-gnutls 7.20.0-3+b1Multi-protocol file transfer libra ii libglib2.0-0 2.24.0-1 The GLib library of C routines ii libimlib2 1.4.2-8+b1 powerful image loading and renderi ii libiw30 30~pre9-4 Wireless tools - library ii liblua5.1-0 5.1.4-5Simple, extensible, embeddable pro ii libncurses5 5.7+20100313-2 shared libraries for terminal hand ii libx11-6 2:1.3.3-3 X11 client-side library ii libxdamage1 1:1.1.2-1 X11 damaged region extension libra ii libxext6 2:1.1.1-3 X11 miscellaneous extension librar ii libxfixes31:4.0.4-2 X11 miscellaneous 'fixes' extensio ii libxft2 2.1.14-2 FreeType-based font drawing librar ii libxml2 2.7.7.dfsg-2 GNOME XML library conky-all recommends no packages. Versions of packages conky-all suggests: ii apcupsd 3.14.8-2APC UPS Power Management (daemon) ii moc 1:2.5.0~alpha4+svn20091009-1+b1 ncurses based console audio player pn mpd none (no description available) -- no debconf information -- Karl Sackett k...@hiwaay.net -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
