package usb-modeswitch tags 581143 +pending +upstream thanks Le mardi 11 mai 2010 08:15:05 Raphael Geissert, vous avez écrit : > Package: usb-modeswitch > Severity: important > Version: 1.1.2-2 > User: debian-rele...@lists.debian.org > Usertags: goal-dash > > Hello maintainer, > > While performing an archive wide checkbashisms (from the 'devscripts' > package) check I've found your package containing a /bin/sh script making > use of a bashism. > > checkbashisms' output: > > possible bashism in ./lib/udev/usb_modeswitch line 7 (should be >word > > 2>&1): > > /usr/bin/tclsh "$0" "$@" &>/dev/null & \ > > Not using bash (or a Debian Policy compliant shell interpreter that doesn't > provide such an extra feature) as /bin/sh is likely to lead to errors or > unexpected behaviours. Please be aware that dash is now the default > /bin/sh. > > Thank you, > Raphael Geissert
Hi Raphael, and thanks for your bug report, (Josua, upstream, CC'ed) I just committed [1] that fixes that (patch is attached). It will be part of the next upload. Cheers, OdyX [1] http://git.debian.org/?p=collab-maint/usb-modeswitch.git;a=commitdiff;h=803337c -- Didier Raboud, proud Debian Maintainer (DM). CH-1020 Renens did...@raboud.com
Description: Fixes bashism in usb_modeswitch.tcl Author: Didier Raboud <did...@raboud.com> Origin: vendor Forwarded: yes (e-mail) Bugs: http://bugs.debian.org/581143 Last-Updated: 2010-05-11 Index: usb-modeswitch.git/usb_modeswitch.tcl =================================================================== --- usb-modeswitch.git.orig/usb_modeswitch.tcl 2010-05-11 09:19:05.000000000 +0200 +++ usb-modeswitch.git/usb_modeswitch.tcl 2010-05-11 09:19:29.000000000 +0200 @@ -4,7 +4,7 @@ if [ ! -e "/usr/bin/tclsh" ]; then \ logger -p syslog.error "usb_modeswitch: tcl shell not found, install tcl package!"; \ fi; \ -/usr/bin/tclsh "$0" "$@" &>/dev/null & \ +/usr/bin/tclsh "$0" "$@" >/dev/null 2>&1 & \ sleep 1; \ exit
