Bug#586563: Ubuntu changes to maxima-emacs installation
Greetings, and thanks for your suggestion. Applied this in the
latest.
Take care,
Agustin Martin agmar...@debian.org writes:
On Sun, Jun 20, 2010 at 05:52:04PM +0200, Stefano Rivera wrote:
Package: maxima-emacs
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch
Version: 5.21.1-1
Severity: minor
Tags: patch
PS: I can't comment on the content of this patch as I didn't author it
and am not an emacs user.
I came to this bug report because of the verbosity when byte-compiling so,
besides suggesting another change, I will comment a bit on some of these
changes,
In Ubuntu, we've applied the attached patch to achieve the following:
- debian/maxima-emacs.emacsen-install:
+ Install symlinks for source files rather than copying them. This
makes find-function work.
+ Install symlink for *.lisp so that we don't need to add
/usr/share/emacs/site-lisp/maxima to load-path.
Please consider above changes. That is the way most emacsen add-on packages
behave.
- debian/maxima-emacs.emacsen-startup:
+ Remove use of /usr/share/emacs/site-lisp/maxima, since this
causes load-path shadows and is not needed anymore.
This seems also useful. Path for $flavour byte-compiled files is already
included and, if symlinks to .el files are included, they are available
from the $flavour dir.
- Comment out backward-delete-char-untabify in maxima.el.
Seems that nothing appears about this in given reference at
These changes originated (a while ago) in this report:
https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/124415
but I could find info at
https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/5273
Seems that what was done is to rebind delete key to delete backwards.
Removing the lines as in Ubuntu patch is reported to restore the standard
behaviour. I'd suggest a more descriptive changelog entry, something like
- Do not rebind delete key to `backward-delete-char-untabify' (delete
backwards)
And now an additional suggestion. byte-compilation of maxima emacsen files
is way too verbose because startup files are loaded for no good reason.
Please consider attached patch. Note that it only uses '-no-start-file', the
XEmacs form. Current FSF Emacs also supports that, so that is no problem.
Suggested changelog entry:
- Do not load site-files when byte-compiling.
Cheers,
--
Agustin
--- maxima-emacs.emacsen-install.orig 2010-06-29 15:01:59.0 +0200
+++ maxima-emacs.emacsen-install 2010-06-29 16:07:38.0 +0200
@@ -12,12 +12,9 @@
echo install/${PACKAGE}: Handling install for emacsen flavor ${FLAVOR}
-#FLAVORTEST=`echo $FLAVOR | cut -c-6`
-#if [ ${FLAVORTEST} = xemacs ] ; then
-#SITEFLAG=-no-site-file
-#else
-#SITEFLAG=--no-site-file
-#fi
+# Do not load startup files when byte-compiling.
+SITEFLAG=-no-site-file
+
FLAGS=${SITEFLAG} -q -batch -l path.el -f batch-byte-compile
ELDIR=/usr/share/emacs/site-lisp/${PACKAGE}
--
Camm Maguirec...@maguirefamily.org
==
The earth is but one country, and mankind its citizens. -- Baha'u'llah
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#586563: Ubuntu changes to maxima-emacs installation
On Sun, Jun 20, 2010 at 05:52:04PM +0200, Stefano Rivera wrote:
Package: maxima-emacs
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch
Version: 5.21.1-1
Severity: minor
Tags: patch
PS: I can't comment on the content of this patch as I didn't author it
and am not an emacs user.
I came to this bug report because of the verbosity when byte-compiling so,
besides suggesting another change, I will comment a bit on some of these
changes,
In Ubuntu, we've applied the attached patch to achieve the following:
- debian/maxima-emacs.emacsen-install:
+ Install symlinks for source files rather than copying them. This
makes find-function work.
+ Install symlink for *.lisp so that we don't need to add
/usr/share/emacs/site-lisp/maxima to load-path.
Please consider above changes. That is the way most emacsen add-on packages
behave.
- debian/maxima-emacs.emacsen-startup:
+ Remove use of /usr/share/emacs/site-lisp/maxima, since this
causes load-path shadows and is not needed anymore.
This seems also useful. Path for $flavour byte-compiled files is already
included and, if symlinks to .el files are included, they are available
from the $flavour dir.
- Comment out backward-delete-char-untabify in maxima.el.
Seems that nothing appears about this in given reference at
These changes originated (a while ago) in this report:
https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/124415
but I could find info at
https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/5273
Seems that what was done is to rebind delete key to delete backwards.
Removing the lines as in Ubuntu patch is reported to restore the standard
behaviour. I'd suggest a more descriptive changelog entry, something like
- Do not rebind delete key to `backward-delete-char-untabify' (delete
backwards)
And now an additional suggestion. byte-compilation of maxima emacsen files
is way too verbose because startup files are loaded for no good reason.
Please consider attached patch. Note that it only uses '-no-start-file', the
XEmacs form. Current FSF Emacs also supports that, so that is no problem.
Suggested changelog entry:
- Do not load site-files when byte-compiling.
Cheers,
--
Agustin
--- maxima-emacs.emacsen-install.orig 2010-06-29 15:01:59.0 +0200
+++ maxima-emacs.emacsen-install 2010-06-29 16:07:38.0 +0200
@@ -12,12 +12,9 @@
echo install/${PACKAGE}: Handling install for emacsen flavor ${FLAVOR}
-#FLAVORTEST=`echo $FLAVOR | cut -c-6`
-#if [ ${FLAVORTEST} = xemacs ] ; then
-#SITEFLAG=-no-site-file
-#else
-#SITEFLAG=--no-site-file
-#fi
+# Do not load startup files when byte-compiling.
+SITEFLAG=-no-site-file
+
FLAGS=${SITEFLAG} -q -batch -l path.el -f batch-byte-compile
ELDIR=/usr/share/emacs/site-lisp/${PACKAGE}
Bug#586563: Ubuntu changes to maxima-emacs installation
Package: maxima-emacs
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch
Version: 5.21.1-1
Severity: minor
Tags: patch
In Ubuntu, we've applied the attached patch to achieve the following:
- debian/maxima-emacs.emacsen-install:
+ Install symlinks for source files rather than copying them. This
makes find-function work.
+ Install symlink for *.lisp so that we don't need to add
/usr/share/emacs/site-lisp/maxima to load-path.
- debian/maxima-emacs.emacsen-startup:
+ Remove use of /usr/share/emacs/site-lisp/maxima, since this
causes load-path shadows and is not needed anymore.
- Comment out backward-delete-char-untabify in maxima.el.
We thought you might be interested in doing the same.
These changes originated (a while ago) in this report:
https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/124415
SR
PS: I can't comment on the content of this patch as I didn't author it
and am not an emacs user.
--
Stefano Rivera
http://tumbleweed.org.za/
H: +27 21 465 6908 C: +27 72 419 8559 UCT: x3127
diff -u maxima-5.21.1/debian/maxima-emacs.emacsen-startup maxima-5.21.1/debian/maxima-emacs.emacsen-startup
--- maxima-5.21.1/debian/maxima-emacs.emacsen-startup
+++ maxima-5.21.1/debian/maxima-emacs.emacsen-startup
@@ -25,11 +25,6 @@
(autoload 'maxima maxima t)
-
-; For emaxima.lisp to be found and tex update mode to be enabled.
-;
-(debian-pkg-add-load-path-item /usr/share/emacs/site-lisp/maxima)
-;
(autoload 'emaxima-mode emaxima t)
(autoload 'imaxima imaxima t)
diff -u maxima-5.21.1/debian/changelog maxima-5.21.1/debian/changelog
diff -u maxima-5.21.1/debian/maxima-emacs.emacsen-install maxima-5.21.1/debian/maxima-emacs.emacsen-install
--- maxima-5.21.1/debian/maxima-emacs.emacsen-install
+++ maxima-5.21.1/debian/maxima-emacs.emacsen-install
@@ -34,12 +34,12 @@
cd ${ELDIR}
FILES=`echo *.el`
-cp ${FILES} ${ELCDIR}
cd ${ELCDIR}
+ln -sf ${ELDIR}/*.el ${ELDIR}/*.lisp .
cat EOF path.el
(setq load-path (cons . load-path) byte-compile-warnings nil)
EOF
${FLAVOR} ${FLAGS} ${FILES}
-rm -f *.el path.el
+rm -f path.el
exit 0
only in patch2:
unchanged:
--- maxima-5.21.1.orig/interfaces/emacs/emaxima/maxima.el
+++ maxima-5.21.1/interfaces/emacs/emaxima/maxima.el
@@ -2494,7 +2494,7 @@
(define-key map \C-c\) 'maxima-check-parens)
(define-key map [(control c) (control \))] 'maxima-check-form-parens)
;(define-key map \C-cC-\) 'maxima-check-form-parens)
-(define-key map \177 'backward-delete-char-untabify)
+;(define-key map \177 'backward-delete-char-untabify)
(setq maxima-mode-map map)))
Menu
@@ -3321,7 +3321,7 @@
(define-key inferior-maxima-mode-map [(meta control tab)]
'inferior-maxima-input-complete)
(define-key inferior-maxima-mode-map \e\t 'inferior-maxima-complete)
-(define-key inferior-maxima-mode-map \177 'backward-delete-char-untabify)
+;(define-key inferior-maxima-mode-map \177 'backward-delete-char-untabify)
(define-key inferior-maxima-mode-map \C-c\C-k 'maxima-stop)
(define-key inferior-maxima-mode-map \C-c\C-d maxima-help-map)
signature.asc
Description: Digital signature
