Bug#588811: [Pkg-xen-devel] Bug#588811: [Patch] Import xen.lowlevel.xc later in pygrub
Hello Bastian, On Mon, Jul 12, 2010 at 07:18:28PM +0200, Bastian Blank wrote: > I would believe that the correct fix is to remove the usage of the > lowlevel interface. I think i agree. I just took a glance over the code, and also fired up a python shell to see what the code is actually used for. >From what i can tell xen.lowlevel.xc allows the script to find out the capabilities of the enviorment, in the script it is *only* called when checking if the dom0 supports running 64-bit pvguests, i.e. the supports64bitPVguest() function. Anyway it doesn't seem like a piece of code that is necessary for most users. In fact, deleting this import line worked just as well. The only thing that bothers me is that it is called used in the bit of code labeled: "If nothing has been specified, look for a Solaris domU" I don't have (nor do i want) any solaris domU's to test this code with. However i can say that both this import line, as well as the supports64bitPVguest function and the subsequent calls to it are absent in the Xen installation i have on one of my CentOS machines (xen 3.4.2). The version listed at the top of the script in that installation is also 0.6. Anyway I think it'd be best to prepare a patch to delete this cruft in the Debian package. It's a shame that it breaks pygrub right now. Regards, Dmitry -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#588811: [Pkg-xen-devel] Bug#588811: [Patch] Import xen.lowlevel.xc later in pygrub
On Mon, Jul 12, 2010 at 06:56:51PM +0200, Dmitry Nedospasov wrote: > Since the script resolves additional dependencies anyway by appending > the path, we simply move the import xen.lowlevel.xc line to below the > line that appends path. I would believe that the correct fix is to remove the usage of the lowlevel interface. Bastian -- Sometimes a feeling is all we humans have to go on. -- Kirk, "A Taste of Armageddon", stardate 3193.9 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#588811: [Patch] Import xen.lowlevel.xc later in pygrub
This is a relatively simple fix i found, I don't know if it need to be reported to upstream. Since the script resolves additional dependencies anyway by appending the path, we simply move the import xen.lowlevel.xc line to below the line that appends path. Worked like a charm for me. Rergards, Dmitry diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub index d0d8844..f8d8f37 100644 --- a/tools/pygrub/src/pygrub +++ b/tools/pygrub/src/pygrub @@ -17,13 +17,13 @@ import os, sys, string, struct, tempfile, re import copy import logging import platform -import xen.lowlevel.xc import curses, _curses, curses.wrapper, curses.textpad, curses.ascii import getopt sys.path.insert(1, sys.path[0] + '/../lib/python') +import xen.lowlevel.xc import fsimage import grub.GrubConf import grub.LiloConf
