Bug#589283: find commit adding/removing could use changing option

2011-01-18 Thread Jonathan Nieder
# v1.7.4-rc0~205^2~1 (git log/diff: add -Gregexp that greps in the
# patch text, 2010-08-23)
clone 589283 -1
retitle -1 git log --grep-diff
reassign -1 git
block 589283 by -1
tags -1 + fixed-upstream
quit

Hi Chris,

C or L Smith wrote:

 One thing I find myself wishing for is the ability to find a line
 that has been modified by using gitk. It seems to me that if I have
 the following in a diff
 
 - def foo(this)
 + def foo(this, that=False)
 
 that I can't find the line by searching for foo.

Junio finished the plumbing. :)

 git log -Gregexp

finds commits that add or remove a line matching regexp.  It's
handy.

 would like to know how foo has changed and I would like to search
 for def foo without knowing what else is on the line. Perhaps an
 option find commit 'with string' could be added to find commit
 'adding/removing'.

This piece still needs writing.

Thanks for a nice suggestion.
Jonathan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#589283: find commit adding/removing could use changing option

2010-07-16 Thread C or L Smith
package: gitk

One thing I find myself wishing for is the ability to find a line that has been 
modified by using gitk. It seems to me that if I have the following in a diff

- def foo(this)
+ def foo(this, that=False)

that I can't find the line by searching for foo. There are times I would like 
to know how foo has changed and I would like to search for def foo without 
knowing what else is on the line. Perhaps an option find commit 'with string' 
could be added to find commit 'adding/removing'.

Version info: I am accessing git through MINGW32 (gitbash?) under Windows XP, 
version 1.6.3.2-preview20090608.

Best regards,
 Chris Smith



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#589283: find commit adding/removing could use changing option

2010-07-16 Thread Jonathan Nieder
retitle 589283 gitk: add grep diff selection criterion
severity 589283 wishlist
found 589283 git-core/1:1.6.3.3-1
found 589283 git/1:1.7.1-1
tags 589283 + upstream
quit

Hi Chris,

C or L Smith wrote:

 One thing I find myself wishing for is the ability to find a line that has
 been modified by using gitk. It seems to me that if I have the following in a
 diff
 
 - def foo(this)
 + def foo(this, that=False)
 
 that I can't find the line by searching for foo.

This seems like something to get tips on upstream. I’ll forward the
report in a moment.

 Version info: I am accessing git through MINGW32 (gitbash?) under Windows XP,
 version 1.6.3.2-preview20090608.

This is the Debian bug tracker, so it would have been more
conventional to send your report straight to the git list.  But since
the bug applies on Debian systems, too, I’ll keep it for tracking.

Be seeing you,
Jonathan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org