Bug#594092: initramfs-tools: Detection of resume device could terminate prematurely

2010-08-23 Thread Dmitry Astapov
Package: initramfs-tools
Version: 0.98
Severity: normal

Hi,

My configuration includes (among other things) encrypted swap + uswsusp.

Within last month one of the initrams-tools upgrades rendered my setup 
unusable: resume device (/dev/mapper/swap) was not available during boot.

I went and peppered /usr/share/initramfs-tools/hooks/cryptroot with debug 
output and found out that:
1)I have (orphaned) /etc/suspend.conf lying around since Good Olde Times which 
lists /dev/sda8 as resume target
2)All other (proper) places list /dev/mapper/swap as resume target
3)cryptroot hook terminates prematurely trying to find canonical name for 
/dev/sda8.

Specifically, line 97 of cryptroot:
device=$(canonical_device $device) || return 0

causes hook to terminate prematurely, broking the resume process. I think that 
old config files lying around are not the only possible cause for breakage in 
this place, so other users might be affected as well - for example, if they 
made errors in their config files.

I think that either user should be warned (Resume device ... is not available, 
fix manually) or more sensible approach to error handling should be employed.

Thank you!

-- Package-specific info:
-- initramfs sizes
-rw-r--r-- 1 root root 8.8M Aug 23 18:59 /boot/initrd.img-2.6.30-1-686
-rw-r--r-- 1 root root 8.6M Aug 10 15:04 /boot/initrd.img-2.6.30-1-686.bak
-- /proc/cmdline
root=/dev/sda1 ro ramdisk_size=8192 resume=/dev/mapper/swap

-- resume
RESUME=/dev/mapper/swap
-- /proc/filesystems
ext2
ext3
fuseblk

-- lsmod
Module  Size  Used by
iwl394561064  0 
omnibook   47824  0 
sco 8832  2 
rfcomm 30368  14 
bnep   10860  4 
l2cap  18120  19 rfcomm,bnep
vboxnetadp  6428  0 
vboxnetflt 12324  0 
vboxdrv   155584  2 vboxnetadp,vboxnetflt
acpi_cpufreq7640  0 
cpufreq_powersave   1292  0 
cpufreq_userspace   2768  0 
cpufreq_stats   3520  0 
cpufreq_conservative 6256  2 
autofs420544  1 
irda   95720  0 
crc_ccitt   1816  1 irda
binfmt_misc 7120  1 
vmnet  33260  13 
parport_pc 22420  0 
parport31144  1 parport_pc
vmblock11256  1 
vmci   42584  0 
vmmon  59876  0 
kvm_intel  39744  0 
kvm   138608  1 kvm_intel
fuse   47752  1 
nfsd  204900  0 
exportfs3792  1 nfsd
nfs   221580  0 
lockd  57972  2 nfsd,nfs
fscache34440  1 nfs
nfs_acl 2640  2 nfsd,nfs
auth_rpcgss31416  2 nfsd,nfs
sunrpc163772  6 nfsd,nfs,lockd,nfs_acl,auth_rpcgss
ext3  107172  3 
jbd41036  1 ext3
btusb  10276  2 
bluetooth  47060  9 sco,rfcomm,bnep,l2cap,btusb
visor  13812  0 
usbserial  27456  1 visor
coretemp5176  0 
ip_tables  10188  0 
x_tables   14108  1 ip_tables
sha256_generic 11216  0 
cbc 3012  1 
aes_i5868092  4 
aes_generic27436  1 aes_i586
dm_crypt   11092  3 
dm_mod 49992  7 dm_crypt
snd_hda_codec_si3054 4024  1 
snd_hda_codec_realtek   178472  1 
snd_hda_intel  22192  0 
snd_hda_codec  63580  3 
snd_hda_codec_si3054,snd_hda_codec_realtek,snd_hda_intel
snd_hwdep   6120  1 snd_hda_codec
arc41560  2 
snd_pcm_oss32232  0 
snd_mixer_oss  12368  1 snd_pcm_oss
ecb 2368  4 
snd_pcm62420  4 
snd_hda_codec_si3054,snd_hda_intel,snd_hda_codec,snd_pcm_oss
snd_seq_midi5688  0 
snd_rawmidi18596  1 snd_seq_midi
iwlcore92264  1 iwl3945
snd_seq_midi_event  6212  1 snd_seq_midi
pcmcia 24280  0 
snd_seq42436  2 snd_seq_midi,snd_seq_midi_event
snd_timer  17436  2 snd_pcm,snd_seq
snd_seq_device  6136  3 snd_seq_midi,snd_rawmidi,snd_seq
joydev  8576  0 
snd49060  12 
snd_hda_codec_si3054,snd_hda_codec_realtek,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_rawmidi,snd_seq,snd_timer,snd_seq_device
mac80211  142848  2 iwl3945,iwlcore
yenta_socket   21168  1 
tifm_7xx1   4864  0 
intel_agp  22900  0 
rsrc_nonstatic  9664  1 yenta_socket
soundcore   6184  1 snd
i2c_i8018564  0 
nvidia   8869740  31 
pcmcia_core31212  3 pcmcia,yenta_socket,rsrc_nonstatic
pcspkr  2104  0 
rng_core3672  0 
rfkill  9668  2 iwlcore
snd_page_alloc  

Bug#594092: initramfs-tools: Detection of resume device could terminate prematurely

2010-08-23 Thread maximilian attems
reassign 594092 cryptsetup
stop

On Mon, Aug 23, 2010 at 07:12:59PM +0300, Dmitry Astapov wrote:
 Package: initramfs-tools
 Version: 0.98
 Severity: normal
 
 Hi,
 
 My configuration includes (among other things) encrypted swap + uswsusp.
 
 Within last month one of the initrams-tools upgrades rendered my setup 
 unusable: resume device (/dev/mapper/swap) was not available during boot.
 
 I went and peppered /usr/share/initramfs-tools/hooks/cryptroot with debug 
 output and found out that:
 1)I have (orphaned) /etc/suspend.conf lying around since Good Olde Times 
 which lists /dev/sda8 as resume target
 2)All other (proper) places list /dev/mapper/swap as resume target
 3)cryptroot hook terminates prematurely trying to find canonical name for 
 /dev/sda8.
 
 Specifically, line 97 of cryptroot:
 device=$(canonical_device $device) || return 0
 
 causes hook to terminate prematurely, broking the resume process. I think 
 that old config files lying around are not the only possible cause for 
 breakage in this place, so other users might be affected as well - for 
 example, if they made errors in their config files.
 
 I think that either user should be warned (Resume device ... is not 
 available, fix manually) or more sensible approach to error handling should 
 be employed.
 
 Thank you!

reassigning to the good folks that do the encryption.
happy day.
 
 -- Package-specific info:
 -- initramfs sizes
 -rw-r--r-- 1 root root 8.8M Aug 23 18:59 /boot/initrd.img-2.6.30-1-686
 -rw-r--r-- 1 root root 8.6M Aug 10 15:04 /boot/initrd.img-2.6.30-1-686.bak
 -- /proc/cmdline
 root=/dev/sda1 ro ramdisk_size=8192 resume=/dev/mapper/swap
 
 -- resume
 RESUME=/dev/mapper/swap
 -- /proc/filesystems
   ext2
   ext3
   fuseblk
 
 -- lsmod
 Module  Size  Used by
 iwl394561064  0 
 omnibook   47824  0 
 sco 8832  2 
 rfcomm 30368  14 
 bnep   10860  4 
 l2cap  18120  19 rfcomm,bnep
 vboxnetadp  6428  0 
 vboxnetflt 12324  0 
 vboxdrv   155584  2 vboxnetadp,vboxnetflt
 acpi_cpufreq7640  0 
 cpufreq_powersave   1292  0 
 cpufreq_userspace   2768  0 
 cpufreq_stats   3520  0 
 cpufreq_conservative 6256  2 
 autofs420544  1 
 irda   95720  0 
 crc_ccitt   1816  1 irda
 binfmt_misc 7120  1 
 vmnet  33260  13 
 parport_pc 22420  0 
 parport31144  1 parport_pc
 vmblock11256  1 
 vmci   42584  0 
 vmmon  59876  0 
 kvm_intel  39744  0 
 kvm   138608  1 kvm_intel
 fuse   47752  1 
 nfsd  204900  0 
 exportfs3792  1 nfsd
 nfs   221580  0 
 lockd  57972  2 nfsd,nfs
 fscache34440  1 nfs
 nfs_acl 2640  2 nfsd,nfs
 auth_rpcgss31416  2 nfsd,nfs
 sunrpc163772  6 nfsd,nfs,lockd,nfs_acl,auth_rpcgss
 ext3  107172  3 
 jbd41036  1 ext3
 btusb  10276  2 
 bluetooth  47060  9 sco,rfcomm,bnep,l2cap,btusb
 visor  13812  0 
 usbserial  27456  1 visor
 coretemp5176  0 
 ip_tables  10188  0 
 x_tables   14108  1 ip_tables
 sha256_generic 11216  0 
 cbc 3012  1 
 aes_i5868092  4 
 aes_generic27436  1 aes_i586
 dm_crypt   11092  3 
 dm_mod 49992  7 dm_crypt
 snd_hda_codec_si3054 4024  1 
 snd_hda_codec_realtek   178472  1 
 snd_hda_intel  22192  0 
 snd_hda_codec  63580  3 
 snd_hda_codec_si3054,snd_hda_codec_realtek,snd_hda_intel
 snd_hwdep   6120  1 snd_hda_codec
 arc41560  2 
 snd_pcm_oss32232  0 
 snd_mixer_oss  12368  1 snd_pcm_oss
 ecb 2368  4 
 snd_pcm62420  4 
 snd_hda_codec_si3054,snd_hda_intel,snd_hda_codec,snd_pcm_oss
 snd_seq_midi5688  0 
 snd_rawmidi18596  1 snd_seq_midi
 iwlcore92264  1 iwl3945
 snd_seq_midi_event  6212  1 snd_seq_midi
 pcmcia 24280  0 
 snd_seq42436  2 snd_seq_midi,snd_seq_midi_event
 snd_timer  17436  2 snd_pcm,snd_seq
 snd_seq_device  6136  3 snd_seq_midi,snd_rawmidi,snd_seq
 joydev  8576  0 
 snd49060  12 
 snd_hda_codec_si3054,snd_hda_codec_realtek,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_rawmidi,snd_seq,snd_timer,snd_seq_device
 mac80211  142848  2 iwl3945,iwlcore
 yenta_socket   21168  1 
 tifm_7xx1   4864  0 
 intel_agp  22900  0 
 rsrc_nonstatic  9664  1 yenta_socket
 soundcore