Bug#595756: notify_email: segfaults with slow mail server

2010-09-07 Thread Manuel CISSE
Hi,

On 9/6/2010 3:02 PM, Sebastian Harl wrote:
> Thanks for reporting this! Afaik, Florian already has a (rather
> untested) patch available in Git. I'll look into that and prepare an
> updated package (targeting Squeeze [through unstable]).

This patch seems to fix the problem, collectd is running for one day on
my system, no problem (previously collectd crashed several times a day).

-- 
Regards,
Manuel CISSE




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#595756: notify_email: segfaults with slow mail server

2010-09-06 Thread Sebastian Harl
severity 595756 serious
thanks

Hi Manuel,

On Mon, Sep 06, 2010 at 02:46:37PM +0200, Manuel CISSE wrote:
> With a slow mail server, notify_email_notification() may be called 
> simultaneously by
> 2 or more threads, leading to a crash in libesmtp (due to multiple calls to
> smtp_start_session() on the same session).
> 
> Also, if collectd is stopped when a notification is being dispatched,
> notify_email_shutdown() destroys the session used by 
> notify_email_notification()
> causing a segfault.

Thanks for reporting this! Afaik, Florian already has a (rather
untested) patch available in Git. I'll look into that and prepare an
updated package (targeting Squeeze [through unstable]).

Since segfaults in any plug-in will bring down the whole daemon process,
this a) makes the plugin rather unusable and b) could cause data loss
when having caching enabled in the "rrdtool" plugin. Thus, I've raised
the severity to "serious". (It's perfectly fine, though, that you've
used "normal" -- it's the maintainers job to change the severity if
necessary ;-))

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin



signature.asc
Description: Digital signature


Bug#595756: notify_email: segfaults with slow mail server

2010-09-06 Thread Manuel CISSE
Package: collectd
Version: 4.10.1-1
Severity: normal

With a slow mail server, notify_email_notification() may be called 
simultaneously by
2 or more threads, leading to a crash in libesmtp (due to multiple calls to
smtp_start_session() on the same session).

Also, if collectd is stopped when a notification is being dispatched,
notify_email_shutdown() destroys the session used by notify_email_notification()
causing a segfault.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages collectd depends on:
ii  collectd-core 4.10.1-1   statistics collection and monitori
ii  libc6 2.11.2-4   Embedded GNU C Library: Shared lib
ii  librrd4   1.4.3-1time-series data storage and displ

Versions of packages collectd recommends:
ii  iptables 1.4.9-1 administration tools for packet fi
ii  libatk1.0-0  1.30.0-1The ATK accessibility toolkit
ii  libc62.11.2-4Embedded GNU C Library: Shared lib
ii  libcairo21.8.10-5The Cairo 2D vector graphics libra
ii  libcurl3-gnutls  7.21.1-1Multi-protocol file transfer libra
ii  libdbi0  0.8.3+really0.8.2-1 Database Independent Abstraction L
ii  libdbus-1-3  1.2.24-3simple interprocess messaging syst
ii  libdbus-glib-1-2 0.88-2  simple interprocess messaging syst
ii  libesmtp51.0.4-5 LibESMTP SMTP client library
ii  libfontconfig1   2.8.0-2.1   generic font configuration library
ii  libfreetype6 2.4.2-2 FreeType 2 font engine, shared lib
ii  libgcrypt11  1.4.5-2 LGPL Crypto library - runtime libr
ii  libglib2.0-0 2.24.1-1The GLib library of C routines
ii  libgtk2.0-0  2.20.1-1The GTK+ graphical user interface 
ii  libhal1  0.5.14-3Hardware Abstraction Layer - share
pn  libmemcached5  (no description available)
ii  libmysqlclient16 5.1.49-1MySQL database client library
ii  libnotify1 [libnotif 0.5.0-2 sends desktop notifications to a n
pn  libopenipmi0   (no description available)
ii  liboping01.4.0-1 C/C++ library to generate ICMP ECH
ii  libpango1.0-01.28.1-1Layout and rendering of internatio
ii  libpcap0.8   1.1.1-2 system interface for user-level pa
ii  libperl5.10  5.10.1-14   shared Perl library
ii  libpq5   8.4.4-2 PostgreSQL C client library
pn  libprotobuf-c0 (no description available)
ii  libpython2.6 2.6.6-3 Shared Python runtime library (ver
ii  librrd4  1.4.3-1 time-series data storage and displ
ii  libsensors4  1:3.1.2-6   library to read temperature/voltag
ii  libsnmp155.4.3~dfsg-1SNMP (Simple Network Management Pr
ii  libssl0.9.8  0.9.8o-2SSL shared libraries
pn  libtokyotyrant3(no description available)
pn  libupsclient1  (no description available)
pn  libvirt0   (no description available)
ii  libxml2  2.7.7.dfsg-4GNOME XML library
pn  libyajl1   (no description available)

collectd suggests no packages.

-- Configuration Files:
/etc/collectd/collectd.conf changed [not included]
/etc/collectd/thresholds.conf changed [not included]

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org