Bug#596401: unblock: planner-el/3.42-3

2010-09-16 Thread John Sullivan
Philipp Kern pk...@debian.org writes:

 On Fri, Sep 10, 2010 at 05:52:35PM -0700, John Sullivan wrote:
 Please unblock package planner-el.
 
 3.42-3 fixes a FTBFS bug by removing a build dependency that does not
 exist in squeeze. Instead of naming specific emacs version packages as
 build dependencies, it just names the emacsen virtual package (which
 it did before as one of the ORed list), since any of the providers of
 that package work.

 How did you build test it?  I suppose that the default sbuild dependency
 resolving algorithm will fail horribly on this.


I tested building it inside pbuilder with each of the following:

emacs
emacs23
emacs23-lucid
emacs23-nox
xemacs21-mule
xemacs21-mule-canna-wnn
xemacs21-nomule

These are all the providers of the emacsen virtual package in squeeze. I
tested each provider individually in a fresh environment, as well as
with apt-get build-dep to make sure it could work without any provider
yet installed.

I see other emacs packages using ORed build-dependencies (muse-el,
remember-el) instead of or in addition to the virtual emacsen package,
but Lucas's bug suggested I shouldn't use ORed build-deps either. If
there's a better recommended way to state that any of the alternatives
will suffice for building, I'm happy to apply it.

My fix is essentially the same as what was done in remember-el to fix
the same bug (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=543126).

-- 
-John Sullivan
-http://wjsullivan.net




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#596401: unblock: planner-el/3.42-3

2010-09-16 Thread Philipp Kern
On Thu, Sep 16, 2010 at 12:16:51AM -0700, John Sullivan wrote:
 I see other emacs packages using ORed build-dependencies (muse-el,
 remember-el) instead of or in addition to the virtual emacsen package,
 but Lucas's bug suggested I shouldn't use ORed build-deps either. If
 there's a better recommended way to state that any of the alternatives
 will suffice for building, I'm happy to apply it.

The fix is to list the real package you want it to build it in the archive
first, and the alternatives (even virtual) or'ed after.

(Like emacs23 | emacsen)

Kind regards,
Philipp Kern
 


signature.asc
Description: Digital signature


Bug#596401: unblock: planner-el/3.42-3

2010-09-16 Thread John Sullivan
Philipp Kern pk...@debian.org writes:

 On Thu, Sep 16, 2010 at 12:16:51AM -0700, John Sullivan wrote:
 I see other emacs packages using ORed build-dependencies (muse-el,
 remember-el) instead of or in addition to the virtual emacsen package,
 but Lucas's bug suggested I shouldn't use ORed build-deps either. If
 there's a better recommended way to state that any of the alternatives
 will suffice for building, I'm happy to apply it.

 The fix is to list the real package you want it to build it in the archive
 first, and the alternatives (even virtual) or'ed after.

 (Like emacs23 | emacsen)

 Kind regards,
 Philipp Kern
  

I've uploaded planner-el_3.42-4 with this fix.

diff -u planner-el-3.42/debian/changelog planner-el-3.42/debian/changelog
--- planner-el-3.42/debian/changelog
+++ planner-el-3.42/debian/changelog
@@ -1,3 +1,10 @@
+planner-el (3.42-4) unstable; urgency=low
+
+  * Tweak Build-Depends-Indep again, to work better with sbuild (See:
+#596401).
+
+ -- John Sullivan j...@wjsullivan.net  Thu, 16 Sep 2010 12:56:04 -0700
+
 planner-el (3.42-3) unstable; urgency=low
 
   * Depend on just the virtual emacsen package, since all providers
diff -u planner-el-3.42/debian/control planner-el-3.42/debian/control
--- planner-el-3.42/debian/control
+++ planner-el-3.42/debian/control
@@ -3,13 +3,13 @@
 Priority: optional
 Maintainer: John Sullivan j...@wjsullivan.net
 Build-Depends: debhelper ( 4.0.0)
-Build-Depends-Indep: emacsen, texinfo, texi2html
+Build-Depends-Indep: texinfo, texi2html, emacs23 | emacsen
 Standards-Version: 3.8.0
 DM-Upload-Allowed: yes
 
 Package: planner-el
 Architecture: all
-Depends: emacsen, muse-el, emacsen-common (= 1.4.14)
+Depends: emacs23 | emacsen, muse-el, emacsen-common (= 1.4.14)
 Suggests: remember-el
 Description: personal information manager for Emacs
  This package extends Emacs Muse to act as a day planner.

-- 
-John Sullivan
-http://wjsullivan.net



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#596401: unblock: planner-el/3.42-3

2010-09-11 Thread Philipp Kern
On Fri, Sep 10, 2010 at 05:52:35PM -0700, John Sullivan wrote:
 Please unblock package planner-el.
 
 3.42-3 fixes a FTBFS bug by removing a build dependency that does not
 exist in squeeze. Instead of naming specific emacs version packages as
 build dependencies, it just names the emacsen virtual package (which
 it did before as one of the ORed list), since any of the providers of
 that package work.

How did you build test it?  I suppose that the default sbuild dependency
resolving algorithm will fail horribly on this.

Kind regards,
Philipp Kern


signature.asc
Description: Digital signature


Bug#596401: unblock: planner-el/3.42-3

2010-09-10 Thread John Sullivan
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock


Please unblock package planner-el.

3.42-3 fixes a FTBFS bug by removing a build dependency that does not
exist in squeeze. Instead of naming specific emacs version packages as
build dependencies, it just names the emacsen virtual package (which
it did before as one of the ORed list), since any of the providers of
that package work.

Since the change is minimal and fixes an RC bug, please unblock the
package.

unblock planner-el/3.42-3

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org