Bug#605703: iodine-start-client fails twice in a row
Okay, I have made the tiny modification needed to address this issue, and pushed to git://github.com/barak/iodine-client-start.git. I'm not really sure how useful it will be, since other parts of the route setup are also non-idempotent, but I don't see how it can mess things up that wouldn't be fixed by taking the device down and up again, which is the alternative without the patch. --Barak. -- Barak A. Pearlmutter Hamilton Institute Dept Comp Sci, NUI Maynooth, Co. Kildare, Ireland http://www.bcl.hamilton.ie/~barak/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#605703: iodine-start-client fails twice in a row
On Fri, Dec 03, 2010 at 10:16:34PM +, Barak A. Pearlmutter wrote: or, if you wait a few months, i'll scrape up an hour to work up that fix... Today I've cloned the repo, but a fix is already there! Thanks. Cheers -- Enrico Tassi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#605703: iodine-start-client fails twice in a row
Somewhat related to this thread... Martin Kraft had the idea of using policy routing in conjunction with iodine to help address the issue of setting up and tearing down routes. The basic idea being to create a separate routing table (we could request that a label be added to the /etc/iproute2/rt_tables package in iproute2) and then have iodine mark packets destined for the iodine server so that they went through the table. I just wanted to bring it up, as it might be a good mechanism to give iodine more control over the routing table. tony On 12/06/2010 04:41 AM, Barak A. Pearlmutter wrote: Okay, I have made the tiny modification needed to address this issue, and pushed to git://github.com/barak/iodine-client-start.git. I'm not really sure how useful it will be, since other parts of the route setup are also non-idempotent, but I don't see how it can mess things up that wouldn't be fixed by taking the device down and up again, which is the alternative without the patch. --Barak. -- Barak A. Pearlmutter Hamilton Institute Dept Comp Sci, NUI Maynooth, Co. Kildare, Ireland http://www.bcl.hamilton.ie/~barak/ signature.asc Description: OpenPGP digital signature
Bug#605703: iodine-start-client fails twice in a row
On Mon, 06 Dec 2010 12:41:01 +, Barak A. Pearlmutter wrote: Okay, I have made the tiny modification needed to address this issue, and pushed to git://github.com/barak/iodine-client-start.git. Thanks, updated in the package's svn repo! Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: Sting: If You Love Somebody Set Them signature.asc Description: Digital signature
Bug#605703: iodine-start-client fails twice in a row
On Thu, 02 Dec 2010 15:49:48 +0100, Enrico Tassi wrote:
iodine-start-client removes the default route replacing it with a default
route
that passes trough the tunnel.
## Remove default route via local router
ip -4 route del default via ${router} || ${continue_on_error}
Just after that line the script sets a new default route as expected. If you
then kill iodine this default route is cleared (since the network interface
dns0 disappears). The next time you start the script you get this warning
WARNING: no default route, guessing local router IP address.
and the former line fails. I think that, if you consider this as a warning,
you
should record that there was no default route and avoid to try to delete such
non existing route, or at least avoid to fail (even if the user is root).
Thanks for your bug report, and I agree with your suggestion.
Barak, what do you think about it?
Cheers,
gregor
--
.''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe
`-NP: Supertramp: Hide In Your Shell
signature.asc
Description: Digital signature
Bug#605703: iodine-start-client fails twice in a row
Thanks for your bug report, and I agree with your suggestion. Barak, what do you think about it? sound reasonable. send a patch! (the repo is replicated as github.com/barak/iodine-client so you don't even need to send the patch, just a pull req.) or, if you wait a few months, i'll scrape up an hour to work up that fix... --Barak. -- Barak A. Pearlmutter Hamilton Institute Dept Comp Sci, NUI Maynooth, Co. Kildare, Ireland http://www.bcl.hamilton.ie/~barak/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#605703: iodine-start-client fails twice in a row
Package: iodine
Version: 0.6.0~rc1-2
Severity: normal
iodine-start-client removes the default route replacing it with a default route
that passes trough the tunnel.
## Remove default route via local router
ip -4 route del default via ${router} || ${continue_on_error}
Just after that line the script sets a new default route as expected. If you
then kill iodine this default route is cleared (since the network interface
dns0 disappears). The next time you start the script you get this warning
WARNING: no default route, guessing local router IP address.
and the former line fails. I think that, if you consider this as a warning, you
should record that there was no default route and avoid to try to delete such
non existing route, or at least avoid to fail (even if the user is root).
Cheers
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.36-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages iodine depends on:
ii adduser 3.112+nmu2 add and remove users and groups
ii debconf [debconf-2.0] 1.5.37 Debian configuration management sy
ii libc6 2.11.2-7 Embedded GNU C Library: Shared lib
ii udev164-2/dev/ and hotplug management daemo
ii zlib1g 1:1.2.3.4.dfsg-3 compression library - runtime
iodine recommends no packages.
Versions of packages iodine suggests:
ii dnsutils 1:9.7.2.dfsg.P2-2 Clients provided with BIND
ii fping 2.4b2-to-ipv6-16.1 sends ICMP ECHO_REQUEST packets to
ii gawk 1:3.1.7.dfsg-5 GNU awk, a pattern scanning and pr
ii ipcalc0.41-2 parameter calculator for IPv4 addr
ii iproute 20100519-3 networking and traffic control too
-- debconf information:
iodine/daemon_options:
iodine/start_daemon: false
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
