Bug#608413: Possible patch for libio-socket-inet6-perl?
Hi On Thu, Jan 06, 2011 at 03:00:20PM +0100, gregor herrmann wrote: On Thu, 06 Jan 2011 07:50:42 +0100, Salvatore Bonaccorso wrote: I said on IRC the debian/rules change was wrong, and for the rest I'd like an ack/review from a perl person, which I'm not. I don't know enough about sockets and ipv6 to make real judgement, but: Julien, on the other side I got confirmation from Julien Blache in #608413, that the backported change from the diff 2.54 to 2.55 would work again with the cricket setup. That's fine, but this change does not contain the fix for https://rt.cpan.org/Ticket/Display.html?id=55901 (inet_pton / inet_ntop import warnings) which I remember myself and which was very annoying at least, so I'd rather opt for moving 2.65 to testing (giving some code review from another more knowledgable person). I have prepared the NMU for 2.65 with the change dh_clean - dh_prep instead of using dh_clean -k. But we still need a review regarding ipv6 changes from a knowledgable person ;-) Bests Salvatore diff -u libio-socket-inet6-perl-2.65/debian/changelog libio-socket-inet6-perl-2.65/debian/changelog --- libio-socket-inet6-perl-2.65/debian/changelog +++ libio-socket-inet6-perl-2.65/debian/changelog @@ -1,3 +1,11 @@ +libio-socket-inet6-perl (2.65-1.1) unstable; urgency=low + + * Non-maintainer upload. + * Revert changes to the dh_clean call in the install target: use dh_prep +instead of dh_clean -k. + + -- Salvatore Bonaccorso car...@debian.org Sun, 16 Jan 2011 09:33:09 +0100 + libio-socket-inet6-perl (2.65-1) unstable; urgency=low * New upstream release (closes: Bug#575531) diff -u libio-socket-inet6-perl-2.65/debian/rules libio-socket-inet6-perl-2.65/debian/rules --- libio-socket-inet6-perl-2.65/debian/rules +++ libio-socket-inet6-perl-2.65/debian/rules @@ -39,7 +39,7 @@ install: dh_testdir dh_testroot - dh_clean + dh_prep dh_installdirs $(MAKE) install PREFIX=$(TMP)/usr signature.asc Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
On Sun, Jan 16, 2011 at 09:43:51 +0100, Salvatore Bonaccorso wrote: Hi On Thu, Jan 06, 2011 at 03:00:20PM +0100, gregor herrmann wrote: On Thu, 06 Jan 2011 07:50:42 +0100, Salvatore Bonaccorso wrote: I said on IRC the debian/rules change was wrong, and for the rest I'd like an ack/review from a perl person, which I'm not. I don't know enough about sockets and ipv6 to make real judgement, but: Julien, on the other side I got confirmation from Julien Blache in #608413, that the backported change from the diff 2.54 to 2.55 would work again with the cricket setup. That's fine, but this change does not contain the fix for https://rt.cpan.org/Ticket/Display.html?id=55901 (inet_pton / inet_ntop import warnings) which I remember myself and which was very annoying at least, so I'd rather opt for moving 2.65 to testing (giving some code review from another more knowledgable person). I have prepared the NMU for 2.65 with the change dh_clean - dh_prep instead of using dh_clean -k. But we still need a review regarding ipv6 changes from a knowledgable person ;-) Please go back to dh_clean -k, and upload ASAP with urgency=high. Cheers, Julien signature.asc Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
Hi Julien On Sun, Jan 16, 2011 at 04:02:24PM +0100, Julien Cristau wrote: On Sun, Jan 16, 2011 at 09:43:51 +0100, Salvatore Bonaccorso wrote: Hi On Thu, Jan 06, 2011 at 03:00:20PM +0100, gregor herrmann wrote: On Thu, 06 Jan 2011 07:50:42 +0100, Salvatore Bonaccorso wrote: I said on IRC the debian/rules change was wrong, and for the rest I'd like an ack/review from a perl person, which I'm not. I don't know enough about sockets and ipv6 to make real judgement, but: Julien, on the other side I got confirmation from Julien Blache in #608413, that the backported change from the diff 2.54 to 2.55 would work again with the cricket setup. That's fine, but this change does not contain the fix for https://rt.cpan.org/Ticket/Display.html?id=55901 (inet_pton / inet_ntop import warnings) which I remember myself and which was very annoying at least, so I'd rather opt for moving 2.65 to testing (giving some code review from another more knowledgable person). I have prepared the NMU for 2.65 with the change dh_clean - dh_prep instead of using dh_clean -k. But we still need a review regarding ipv6 changes from a knowledgable person ;-) Please go back to dh_clean -k, and upload ASAP with urgency=high. Ok, no other changes done apart from the dh_clean -k call in the install target. I have uploaded it now with urgency high (directly without delay queue). Bests Salvatore diff -u libio-socket-inet6-perl-2.65/debian/changelog libio-socket-inet6-perl-2.65/debian/changelog --- libio-socket-inet6-perl-2.65/debian/changelog +++ libio-socket-inet6-perl-2.65/debian/changelog @@ -1,3 +1,11 @@ +libio-socket-inet6-perl (2.65-1.1) unstable; urgency=high + + * Non-maintainer upload. + * Revert changes to the dh_clean call in the install target: use dh_prep -k. + * Set urgency to high as requested by the release team. + + -- Salvatore Bonaccorso car...@debian.org Sun, 16 Jan 2011 21:22:09 +0100 + libio-socket-inet6-perl (2.65-1) unstable; urgency=low * New upstream release (closes: Bug#575531) diff -u libio-socket-inet6-perl-2.65/debian/rules libio-socket-inet6-perl-2.65/debian/rules --- libio-socket-inet6-perl-2.65/debian/rules +++ libio-socket-inet6-perl-2.65/debian/rules @@ -39,7 +39,7 @@ install: dh_testdir dh_testroot - dh_clean + dh_clean -k dh_installdirs $(MAKE) install PREFIX=$(TMP)/usr signature.asc Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
On Sun, Jan 16, 2011 at 21:57:12 +0100, Salvatore Bonaccorso wrote: Ok, no other changes done apart from the dh_clean -k call in the install target. I have uploaded it now with urgency high (directly without delay queue). Unblocked, thanks. Cheers, Julien signature.asc Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
On Thu, 06 Jan 2011 07:50:42 +0100, Salvatore Bonaccorso wrote: I said on IRC the debian/rules change was wrong, and for the rest I'd like an ack/review from a perl person, which I'm not. I don't know enough about sockets and ipv6 to make real judgement, but: Julien, on the other side I got confirmation from Julien Blache in #608413, that the backported change from the diff 2.54 to 2.55 would work again with the cricket setup. That's fine, but this change does not contain the fix for https://rt.cpan.org/Ticket/Display.html?id=55901 (inet_pton / inet_ntop import warnings) which I remember myself and which was very annoying at least, so I'd rather opt for moving 2.65 to testing (giving some code review from another more knowledgable person). Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: REM: Near Wild Heaven signature.asc Description: Digital signature
Bug#608413: Possible patch?
Hi Julien
First of all I'm not the maintainer and I'm not having that good IPv6
knowledge. Could you try if the patch inbetween the upstreams versions
2.55 and 2.56 solves the problem? The debdiff for a proposed NMU is
attached.
Could you try for that the package at [1]?
[1]
http://people.debian.org/~carnil/tmp/libio-socket-inet6-perl_2.54-1.2_all.deb
Bests
Salvatore
diff -u libio-socket-inet6-perl-2.54/lib/IO/Socket/INET6.pm libio-socket-inet6-perl-2.54/lib/IO/Socket/INET6.pm
--- libio-socket-inet6-perl-2.54/lib/IO/Socket/INET6.pm
+++ libio-socket-inet6-perl-2.54/lib/IO/Socket/INET6.pm
@@ -148,12 +148,6 @@
$proto ||= (getprotobyname('tcp'))[2];
$type = $arg-{Type} || $socket_type{(getprotobynumber($proto))[0]};
-my @lres = ();
-@lres = getaddrinfo($laddr,$lport,$family,$type,$proto,AI_PASSIVE);
-
-return _error($sock, $EINVAL, getaddrinfo: $lres[0])
- unless(scalar(@lres)=5);
-
$arg-{PeerAddr} = $arg-{PeerHost}
if exists $arg-{PeerHost} !exists $arg-{PeerAddr};
@@ -165,12 +159,60 @@
$sock-blocking($arg-{Blocking}) if defined $arg-{Blocking};
-
-my @rres = ();
-if (defined $raddr) {
-@rres = getaddrinfo($raddr,$rport,$family,$type,$proto,AI_PASSIVE);
-return _error($sock, $EINVAL, getaddrinfo: $rres[0])
- unless (scalar(@rres)=5);
+# Previously IO-Socket-INET6 tried to bind even when one side
+# is AF_INET and the other AF_INET6 and this cannot work.
+#
+# The FAMILY_CHECK loop is meant to make sure both sides have
+# the same family.
+
+my @families;
+if ($family == AF_UNSPEC) {
+@families = (AF_INET6, AF_INET);
+} else {
+@families = ($family);
+}
+
+my $ok = 0;
+my $msg;
+
+my @lres;
+my @rres;
+
+FAMILY_CHECK:
+for my $fam (@families) {
+
+@lres = getaddrinfo(
+$laddr,$lport,$fam,$type,$proto,AI_PASSIVE
+);
+
+if (scalar(@lres) 5) {
+$msg = $lres[0];
+next FAMILY_CHECK;
+}
+
+if (defined $raddr) {
+@rres = getaddrinfo(
+$raddr,$rport,$fam,$type,$proto,AI_PASSIVE
+);
+
+if (scalar(@rres) = 5) {
+$ok = 1;
+last FAMILY_CHECK;
+}
+else {
+$msg = $rres[0];
+}
+}
+else {
+$ok = 1;
+last FAMILY_CHECK;
+}
+
+}
+
+if (! $ok)
+{
+return _error($sock, $EINVAL, getaddrinfo: $msg);
}
while(1) {
diff -u libio-socket-inet6-perl-2.54/debian/changelog libio-socket-inet6-perl-2.54/debian/changelog
--- libio-socket-inet6-perl-2.54/debian/changelog
+++ libio-socket-inet6-perl-2.54/debian/changelog
@@ -1,3 +1,12 @@
+libio-socket-inet6-perl (2.54-1.2) testing-proposed-updates; urgency=low
+
+ * Non-maintainer upload.
+ * Assure that both side of the connection have the same family. Previously
+IO::Socket::Inet6 tried to bind even when one side is AF_INET and the
+other AF_INET6 (Closes: #608413).
+
+ -- Salvatore Bonaccorso car...@debian.org Wed, 05 Jan 2011 10:10:02 +0100
+
libio-socket-inet6-perl (2.54-1.1) unstable; urgency=low
* Non-maintainer upload.
signature.asc
Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
Hi Julien I'm adding the Release-Team and in particular Masahito Omote to the loop, as Masahito is the Maintainer. On Wed, Jan 05, 2011 at 12:42:37PM +0100, Julien BLACHE wrote: Salvatore Bonaccorso car...@debian.org wrote: First of all I'm not the maintainer and I'm not having that good IPv6 knowledge. Could you try if the patch inbetween the upstreams versions 2.55 and 2.56 solves the problem? The debdiff for a proposed NMU is attached. I'll give it a go; have you looked into 2.62 also? No, not in detail as I saw Steffen Ullrich mentioned it was due to a previous fix in the previous uploaded version. All in all, 2.65 has been in unstable for over 110 days now and I've been told the release team is OK with 2.65 but not with the packaging changes and would accept 2.65 with the old packaging. Oh, great. Didn't saw such conversation with RT! This would be way better given there were only v6 fixes and testsuite improvements/fixes between 2.54 and 2.65. If this would be accepted by the release-Team this would be way better yes! The changes between 2.54-1.1 and 2.65-1 related to the packaging itself are only: diff -Nru libio-socket-inet6-perl-2.54/debian/changelog libio-socket-inet6-perl-2.65/debian/changelog --- libio-socket-inet6-perl-2.54/debian/changelog 2011-01-05 13:00:17.0 +0100 +++ libio-socket-inet6-perl-2.65/debian/changelog 2011-01-05 13:00:17.0 +0100 @@ -1,3 +1,11 @@ +libio-socket-inet6-perl (2.65-1) unstable; urgency=low + + * New upstream release (closes: Bug#575531) + * Close #480500 that was already fixed in 2.54. (closes: Bug#480500) + * Standards-Version: 3.9.1 + + -- Masahito Omote om...@debian.org Sun, 12 Sep 2010 02:59:48 +0900 + libio-socket-inet6-perl (2.54-1.1) unstable; urgency=low * Non-maintainer upload. diff -Nru libio-socket-inet6-perl-2.54/debian/control libio-socket-inet6-perl-2.65/debian/control --- libio-socket-inet6-perl-2.54/debian/control 2011-01-05 13:00:17.0 +0100 +++ libio-socket-inet6-perl-2.65/debian/control 2011-01-05 13:00:17.0 +0100 @@ -4,7 +4,7 @@ Build-Depends: debhelper (= 7) Build-Depends-Indep: perl (= 5.8.0-7) Maintainer: Masahito Omote om...@debian.org -Standards-Version: 3.7.3.0 +Standards-Version: 3.9.1 Package: libio-socket-inet6-perl Architecture: all diff -Nru libio-socket-inet6-perl-2.54/debian/copyright libio-socket-inet6-perl-2.65/debian/copyright --- libio-socket-inet6-perl-2.54/debian/copyright 2011-01-05 13:00:17.0 +0100 +++ libio-socket-inet6-perl-2.65/debian/copyright 2011-01-05 13:00:17.0 +0100 @@ -1,10 +1,6 @@ This is the debian package for the IO::Socket::INET6 module. It was created by Masahito Omote om...@debian.org using dh-make-perl. -This copyright info was automatically extracted from the perl module. -It may not be accurate, so you better check the module sources -if don't want to get into legal troubles. - This program is based on IO::Socket::INET by Graham Barr gb...@pobox.com and currently maintained by the Perl Porters. diff -Nru libio-socket-inet6-perl-2.54/debian/rules libio-socket-inet6-perl-2.65/debian/rules --- libio-socket-inet6-perl-2.54/debian/rules 2011-01-05 13:00:17.0 +0100 +++ libio-socket-inet6-perl-2.65/debian/rules 2011-01-05 13:00:17.0 +0100 @@ -39,7 +39,7 @@ install: dh_testdir dh_testroot - dh_clean -k + dh_clean dh_installdirs $(MAKE) install PREFIX=$(TMP)/usr Release-Team, are you finde with uploading 2.65 to unstable again, but reverting thus only the dh_clean call? Please let me know, I can prepare an NMU in such case, if Masahito would not like to do it right himself? Bests Salvatore signature.asc Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
On Wed, Jan 5, 2011 at 13:07:54 +0100, Salvatore Bonaccorso wrote: On Wed, Jan 05, 2011 at 12:42:37PM +0100, Julien BLACHE wrote: All in all, 2.65 has been in unstable for over 110 days now and I've been told the release team is OK with 2.65 but not with the packaging changes and would accept 2.65 with the old packaging. Oh, great. Didn't saw such conversation with RT! I said on IRC the debian/rules change was wrong, and for the rest I'd like an ack/review from a perl person, which I'm not. Cheers, Julien signature.asc Description: Digital signature
Bug#608413: Possible patch for libio-socket-inet6-perl?
Hi all On Wed, Jan 05, 2011 at 01:25:09PM +0100, Julien Cristau wrote: On Wed, Jan 5, 2011 at 13:07:54 +0100, Salvatore Bonaccorso wrote: On Wed, Jan 05, 2011 at 12:42:37PM +0100, Julien BLACHE wrote: All in all, 2.65 has been in unstable for over 110 days now and I've been told the release team is OK with 2.65 but not with the packaging changes and would accept 2.65 with the old packaging. Oh, great. Didn't saw such conversation with RT! I said on IRC the debian/rules change was wrong, and for the rest I'd like an ack/review from a perl person, which I'm not. Yes, the 'dh_clean -k' - 'dh_clean' change is not correct. I'm cc'ing for the rest the debian-perl list, to have some further comments from the other team members. Julien, on the other side I got confirmation from Julien Blache in #608413, that the backported change from the diff 2.54 to 2.55 would work again with the cricket setup. Debian Perl Group and Masahito, could you give some input for the rest of the changes between the versions in squeeze and unstable for libio-socket-inet6-perl? Bests Salvatore signature.asc Description: Digital signature
