Bug#612179: resolvconf tries to awaken fetchmail even if its not running leading to failed service at boot

2011-02-06 Thread kiu
Package: resolvconf
Version: 1.46
Severity: normal


While booting a failed service is shown because resolvconf tries to awaken 
fetchmail which is not running yet.

/etc/resolvconf/update-libc.d/fetchmail

if [ -x /etc/init.d/fetchmail ]; then
/etc/init.d/fetchmail awaken
fi

should be something like this

if [ -x /etc/init.d/fetchmail ] && [ -e /var/run/fetchmail/fetchmail.pid ]; then
/etc/init.d/fetchmail awaken
fi


-- System Information:
Debian Release: 6.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages resolvconf depends on:
ii  debconf [debconf-2.0]   1.5.36.1 Debian configuration management sy
ii  lsb-base3.2-23.2squeeze1 Linux Standard Base 3.2 init scrip

resolvconf recommends no packages.

resolvconf suggests no packages.

-- debconf information excluded



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#612179: resolvconf tries to awaken fetchmail even if its not running leading to failed service at boot

2011-08-30 Thread Teodor MICU
limit source fetchmail
reopen 612179
notfixed 612179 6.3.21-1
stop

Hi,

The following change does not have the intended effect:

Changes made to '/etc/resolvconf/update-libc.d/fetchmail' follow:
  @@ -7,6 +7,6 @@
shift
   done

  -if [ -x /etc/init.d/fetchmail ]; then
  +if [ -x /etc/init.d/fetchmail ] && [ "$(pidof fetchmail)" != "x" ]; then
/etc/init.d/fetchmail awaken
   fi

The second test will always be true. You probably wanted to add "x"
before $() but I recommend to avoid such a workarround and use the
builtin test instead for non-empy string:
  [ -n "$(pidof fetchmail)" ]

The test will return false if that command will return an empty
string, thus fetchmail is not running. However, some other package
maintainers have decided to rely on the return code of
"/etc/init.d/$SRV status > /dev/null" to decide if the service should
be restarted/reloaded.

Thanks



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#612179: [Resolvconf-devel] Bug#612179: resolvconf tries to awaken fetchmail even if its not running leading to failed service at boot

2011-02-06 Thread Edward Allcutt

package resolvconf
reassign 612179 fetchmail 6.3.18-2
thanks

On Sun, 6 Feb 2011, kiu wrote:

While booting a failed service is shown because resolvconf tries to awaken 
fetchmail which is not running yet.

/etc/resolvconf/update-libc.d/fetchmail


That update script is provided by the fetchmail package.

--
Edward Allcutt



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#612179: [pkg-fetchmail-maint] Bug#612179: resolvconf tries to awaken fetchmail even if its not running leading to failed service at boot

2011-08-30 Thread Nico Golde
Hi,
* Teodor MICU  [2011-08-30 16:02]:
[...] 
> The following change does not have the intended effect:
> 
> Changes made to '/etc/resolvconf/update-libc.d/fetchmail' follow:
>   @@ -7,6 +7,6 @@
>   shift
>done
> 
>   -if [ -x /etc/init.d/fetchmail ]; then
>   +if [ -x /etc/init.d/fetchmail ] && [ "$(pidof fetchmail)" != "x" ]; then
>   /etc/init.d/fetchmail awaken
>fi
> 
> The second test will always be true. You probably wanted to add "x"
> before $()

Argl, indeed. I should've done c&p after I've tested that.

> but I recommend to avoid such a workarround and use the
> builtin test instead for non-empy string:
>   [ -n "$(pidof fetchmail)" ]
> 
> The test will return false if that command will return an empty
> string, thus fetchmail is not running. However, some other package
> maintainers have decided to rely on the return code of
> "/etc/init.d/$SRV status > /dev/null" to decide if the service should
> be restarted/reloaded.

Seems fine either way. Will be fixed in the next upload. Thanks for reopening!

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - n...@jabber.ccc.de - GPG: 0xA0A0
For security reasons, all text in this mail is double-rot13 encrypted.


pgp6SSbXdClZu.pgp
Description: PGP signature