Bug#612342: squeeze KDE updates (was Re: My last (hopefully) bits for KDE in Squeeze)
On Sat, Feb 12, 2011 at 07:49:53PM +0200, Modestas Vainius wrote: > > Are most themes targeted at either KDE3 or KDE4, or would they usually > > be expected to work with both? > KDE 3 themes do not work with KDE 4. Afaik, many icons were renamed to comply > with some XDG standard. So that's where "defacing" comes from. When KDE 4 > does not find an icon in the old KDE 3 theme, it uses a "default" one > (probably the first from the list). So in place of all missing icons, user > gets the same icon all over the place (new, open, save, save as, shutdown, > restart etc... buttons look the same). The patch resets icon theme in the > user > configuration if it does not find some KDE 4 compliant icons in the current > theme. Hrm, Gnome displays image-missing in this case... IIRC, that is. Kind regards Philipp Kern signature.asc Description: Digital signature
Bug#612342: squeeze KDE updates (was Re: My last (hopefully) bits for KDE in Squeeze)
On Sat, 2011-02-12 at 19:49 +0200, Modestas Vainius wrote: > On šeštadienis 12 Vasaris 2011 18:27:58 Adam D. Barratt wrote: > >Three would have been better; one package per report is much easier to > >keep track of. (As would using X-Debbugs-CC so the mail on the list > >actually had the bug number). > > Sorry, will try to do better next time. Heh. :-) > > > 1) krunner #607974 src:kdebase-workspace. The upload is planned to be > > > identical to the current 4:4.4.5-8 in unstable, just with > > > squeeze-adjusted revision number. 4:4.4.5-8 fared well in unstable, I > > > have never had a single krunner crash since upgrading. > > > > This would basically be > > http://websvn.kde.org/?view=revision&revision=1098125 ? How close to > > the 4.5 fix is the 4.4.5 version? (There didn't appear to be a link to > > the backported diff in the upstream bug report). > > Because it was not backported by upstream, I backported it myself. But my > backport is very close to the original patch. It's only an unfuzz of the > modified comment lines in KDE 4.5 (see below) Okay; thanks for the explanation. Please go ahead with this one. > > > 3) kde4libs #588374. Squeeze upload will be based on kde4libs 4:4.4.5-3 > > > currently in unstable. It solves a desktop "defacing" issues after > > > upgrade from KDE 3 (lenny -> squeeze). Quoting the changelog: [...] > KDE 3 themes do not work with KDE 4. Afaik, many icons were renamed to comply > with some XDG standard. So that's where "defacing" comes from. When KDE 4 > does not find an icon in the old KDE 3 theme, it uses a "default" one > (probably the first from the list). So in place of all missing icons, user > gets the same icon all over the place (new, open, save, save as, shutdown, > restart etc... buttons look the same). The patch resets icon theme in the > user > configuration if it does not find some KDE 4 compliant icons in the current > theme. Please go ahead with this one too. It would be good to get some testing of the updated packages for each of the fixes addressed in this report once they're in proposed-updates, although I suspect there's a good chance that most of the people reporting the issues may still be using unstable or testing. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#612342: squeeze KDE updates (was Re: My last (hopefully) bits for KDE in Squeeze)
Hello,
On šeštadienis 12 Vasaris 2011 18:27:58 Adam D. Barratt wrote:
>Three would have been better; one package per report is much easier to
>keep track of. (As would using X-Debbugs-CC so the mail on the list
>actually had the bug number).
Sorry, will try to do better next time.
> > More
> > detailed info can be found in the quoted text, individual bug reports and
> > previous mails in the thread.
> >
> > 1) krunner #607974 src:kdebase-workspace. The upload is planned to be
> > identical to the current 4:4.4.5-8 in unstable, just with
> > squeeze-adjusted revision number. 4:4.4.5-8 fared well in unstable, I
> > have never had a single krunner crash since upgrading.
>
> This would basically be
> http://websvn.kde.org/?view=revision&revision=1098125 ? How close to
> the 4.5 fix is the 4.4.5 version? (There didn't appear to be a link to
> the backported diff in the upstream bug report).
Because it was not backported by upstream, I backported it myself. But my
backport is very close to the original patch. It's only an unfuzz of the
modified comment lines in KDE 4.5 (see below)
@@ -1,3 +1,16 @@
+From: Aaron J. Seigo
+Subject: Fix for krunner occasionally crashes (threading related)
+Origin: backport http://websvn.kde.org/?view=revision&revision=1098125
+Bug: https://bugs.kde.org/show_bug.cgi?id=236496#c11
+Bug: https://bugs.kde.org/show_bug.cgi?id=224212
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607974
+Last-Update: 2011-01-18
+Forwarded: yes
+Applied-Upstream: 4.5.0
+
+move the kfileplaces usage to the main thread; really non-optimal, but KIO
+forces our hand. if this works out in trunk, i'll backport to the 4.4 branch.
+
--- a/plasma/generic/runners/places/placesrunner.cpp
+++ b/plasma/generic/runners/places/placesrunner.cpp
@@ -19,14 +19,20 @@
@@ -21,16 +34,16 @@
Q_UNUSED(args)
setObjectName("Places");
addSyntax(Plasma::RunnerSyntax(":q:", i18n("Finds file manager locations
that match :q:")));
-@@ -34,7 +40,7 @@
+@@ -34,7 +40,7 @@ PlacesRunner::PlacesRunner(QObject* pare
- // ensure the bookmarkmanager, etc. in the places model gets creates
created in the main thread
- // otherwise crashes ensue
+ // makes sure we have the bookmarks and what not that the places
+ // model uses set up in the main thread, otherwise crashes ensue
-KFilePlacesModel places;
+m_helper = new PlacesRunnerHelper(this);
}
PlacesRunner::~PlacesRunner()
-@@ -43,21 +49,48 @@
+@@ -43,21 +49,48 @@ PlacesRunner::~PlacesRunner()
void PlacesRunner::match(Plasma::RunnerContext &context)
{
@@ -84,7 +97,7 @@
if ((all && !text.isEmpty()) || text.compare(term,
Qt::CaseInsensitive) == 0) {
type = Plasma::QueryMatch::ExactMatch;
relevance = all ? 0.9 : 1.0;
-@@ -67,18 +100,18 @@
+@@ -67,18 +100,18 @@ void PlacesRunner::match(Plasma::RunnerC
}
if (type != Plasma::QueryMatch::NoMatch) {
@@ -133,7 +146,7 @@
class PlacesRunner : public Plasma::AbstractRunner
{
Q_OBJECT
-@@ -35,8 +51,14 @@
+@@ -35,8 +51,14 @@ public:
void match(Plasma::RunnerContext &context);
void run(const Plasma::RunnerContext &context, const Plasma::QueryMatch
&action);
> > 2) src:krusader #604196. All info, including the patch, below and in the
> > bug report. Package revision will be properly squeeze-adjusted.
>
> Please go ahead with this one.
>
> > 3) kde4libs #588374. Squeeze upload will be based on kde4libs 4:4.4.5-3
> > currently in unstable. It solves a desktop "defacing" issues after
> > upgrade from KDE 3 (lenny -> squeeze). Quoting the changelog:
> >
> > * Add a kconf_update script (migrate_from_kde3_icon_theme) to migrate
> > away
> >
> > from old KDE 3 icon themes which are KDE 4 incompatible (e.g.
> > crystalsvg). (Closes: #588374)
>
> This appears not to have been included in the previous discussions,
> afaics? It's a shame this wasn't resolved until so close to the
> release, given the date of the original report.
Well, I figured you would not accept non-RC fixes so I didn't even try asking.
> Are most themes targeted at either KDE3 or KDE4, or would they usually
> be expected to work with both?
KDE 3 themes do not work with KDE 4. Afaik, many icons were renamed to comply
with some XDG standard. So that's where "defacing" comes from. When KDE 4
does not find an icon in the old KDE 3 theme, it uses a "default" one
(probably the first from the list). So in place of all missing icons, user
gets the same icon all over the place (new, open, save, save as, shutdown,
restart etc... buttons look the same). The patch resets icon theme in the user
configuration if it does not find some KDE 4 compliant icons in the current
theme.
--
Modestas Vainius
signature.asc
Description: This is a digitally signed message part.
Bug#612342: squeeze KDE updates (was Re: My last (hopefully) bits for KDE in Squeeze)
On Mon, 2011-02-07 at 23:45 +0200, Modestas Vainius wrote: > so I'm turning this thread into a bug report. My requests are below. Three would have been better; one package per report is much easier to keep track of. (As would using X-Debbugs-CC so the mail on the list actually had the bug number). > More > detailed info can be found in the quoted text, individual bug reports and > previous mails in the thread. > > 1) krunner #607974 src:kdebase-workspace. The upload is planned to be > identical to the current 4:4.4.5-8 in unstable, just with squeeze-adjusted > revision number. 4:4.4.5-8 fared well in unstable, I have never had a single > krunner crash since upgrading. This would basically be http://websvn.kde.org/?view=revision&revision=1098125 ? How close to the 4.5 fix is the 4.4.5 version? (There didn't appear to be a link to the backported diff in the upstream bug report). > 2) src:krusader #604196. All info, including the patch, below and in the bug > report. Package revision will be properly squeeze-adjusted. Please go ahead with this one. > 3) kde4libs #588374. Squeeze upload will be based on kde4libs 4:4.4.5-3 > currently in unstable. It solves a desktop "defacing" issues after upgrade > from KDE 3 (lenny -> squeeze). Quoting the changelog: > > * Add a kconf_update script (migrate_from_kde3_icon_theme) to migrate away > from old KDE 3 icon themes which are KDE 4 incompatible (e.g. crystalsvg). > (Closes: #588374) This appears not to have been included in the previous discussions, afaics? It's a shame this wasn't resolved until so close to the release, given the date of the original report. Are most themes targeted at either KDE3 or KDE4, or would they usually be expected to work with both? Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#612342: squeeze KDE updates (was Re: My last (hopefully) bits for KDE in Squeeze)
Package: release.debian.org User: release.debian@packages.debian.org Usertags: pu Severity: normal Hello, so I'm turning this thread into a bug report. My requests are below. More detailed info can be found in the quoted text, individual bug reports and previous mails in the thread. 1) krunner #607974 src:kdebase-workspace. The upload is planned to be identical to the current 4:4.4.5-8 in unstable, just with squeeze-adjusted revision number. 4:4.4.5-8 fared well in unstable, I have never had a single krunner crash since upgrading. 2) src:krusader #604196. All info, including the patch, below and in the bug report. Package revision will be properly squeeze-adjusted. 3) kde4libs #588374. Squeeze upload will be based on kde4libs 4:4.4.5-3 currently in unstable. It solves a desktop "defacing" issues after upgrade from KDE 3 (lenny -> squeeze). Quoting the changelog: * Add a kconf_update script (migrate_from_kde3_icon_theme) to migrate away from old KDE 3 icon themes which are KDE 4 incompatible (e.g. crystalsvg). (Closes: #588374) * Urgency=high, the fix is solely targeted at fixing lenny->squeeze upgrades though it might not get there in time. Let me know if you could pull kdebase-workspace and kde4libs uploads directly from unstable. Or if I can start uploading. On trečiadienis 26 Sausis 2011 02:09:52 Julien Cristau wrote: > On Wed, Jan 19, 2011 at 23:04:31 +0200, Modestas Vainius wrote: > > Hello, > > > > On trečiadienis 19 Sausis 2011 11:18:34 Julien Cristau wrote: > > > On Tue, Jan 18, 2011 at 02:25:34 +0200, Modestas Vainius wrote: > > > > 4) src:krusader #604196 There are reports that the included fix for > > > > this grave bug is wrong. Too bad I would need to do a t-p-u upload > > > > in order to include the supposedly right fix ( > > > > http://websvn.kde.org/?view=revision&revision=1169424 + > > > > http://websvn.kde.org/?view=revision&revision=1169519 ). I will test > > > > it as best as I can. > > > > > > maybe r1 as well. > > > > First of all, some background on the issue: > > > > 1) Before 1:2.2.0~beta1-2 was uploaded, upstream [1] and me [2] had some > > considerations about the fix because it apparently introduced a new > > regression as serious as a crash [3]. To make things worse, #604196 was > > later opened saying that the patch didn't actually fix the bug in the > > end. > > > > 2) QCoreApplication::processEvents() [4] is considered to be a dangerous > > function when called manually. It messes up control flow in unpredictable > > ways as it triggers processing of the event loop right away. It may even > > dead lock an application in the worst case scenario (event loop > > processing from within unfinished event handler, oops). Who knows, maybe > > #604196 is because of event loop deadlock. > > > > The new patch apparently nails and fixes the real cause of the > > hang-on-quit. Of course if there is release process related reasons to > > wait (e.g. it's simply too late for t-p-u at this point), we can delay > > it. But if we could fix it now, we should do it (it's -1 RC bug anyway, > > karma++ :-)). > > I think this can wait for r1, and at this point I'm nervous about more > changes before the release, so I'll defer this. > On Tue, Jan 18, 2011 at 02:25:34 +0200, Modestas Vainius wrote: > > 2) krunner #607974 src:kdebase-workspace. The upstream patch > > http://tinyurl.com/6e6b24l is supposed to fix the crash. There is no time > > to confirm the fix 100% as the crash, while pretty common, is random and > > hard to reproduce reliably. The crash no longer occurs in KDE SC 4.5 (at > > least there no new reports against it upstream) which this patch is > > included in. > > > > I have already experienced the crash more than a dozen times. Whenever > > krunner goes down, it's really annoying as krunner is one of the primary > > UI interfaces for launching new applications in KDE. > > would delaying this to r1 allow to confirm the fix? > > 4) src:krusader #604196 There are reports that the included fix for this > > grave bug is wrong. Too bad I would need to do a t-p-u upload in order to > > include the supposedly right fix ( > > http://websvn.kde.org/?view=revision&revision=1169424 + > > http://websvn.kde.org/?view=revision&revision=1169519 ). I will test it > > as best as I can. > Debdiff of the latter is bellow (#604196 is actually a dupe of #587842, > but the latest discussion is in the former (#604196) bug). I tested & > verified the new patch, it works fine. The patch included in > 1:2.2.0~beta1-2 was wrong, I removed it. > > $ debdiff krusader_2.2.0~beta1-2.dsc krusader_2.2.0~beta1-3.dsc > diff -Nru krusader-2.2.0~beta1/debian/changelog > krusader-2.2.0~beta1/debian/changelog --- > krusader-2.2.0~beta1/debian/changelog 2010-10-09 03:38:41.0 > +0300 +++ krusader-2.2.0~beta1/debian/changelog 2011-01-19 > 01:42:58.0 +0200 @@ -1,3 +1,11 @@ > +krusader (1:2.2.0~beta1-3) testing-proposed-updates; urgency=high > + > + * Replace
