Bug#614512: FTBFS in version 8.0.1-2

2011-02-22 Thread David Witbrodt 


> From: Cyril Brulebois 

> Sent: Tue, February 22, 2011 7:02:55 AM
> Subject: Re: Bug#614512: FTBFS in version 8.0.1-2
> 
> Dave Witbrodt   (21/02/2011):
[...]
> > I was able  to resolve the problem after doing a bit of research.  I
> > found that  'xeglgears.c' and 'xeglthreads.c' (in 'src/egl/opengl')
> > both depend on  libX11, and 'xeglthreads.c' also depends on
> > libpthreads.
> 
> Thanks  for the patch; it should be checked (not sure hardcoding
> -lpthreads is the  right thing to do) and then sent upstream.

I was not sure about that either.  I got the idea from my Google search
and from looking around at the 'git log' in 'mesa-demos' around the
time frame of March 2010:


dawitbro@fileserver:~/sandbox/git/mesa-demos-git$ git show 
83580b776832d22d0039d820c637fe0be0855467
commit 83580b776832d22d0039d820c637fe0be0855467
Author: Chia-I Wu 
Date:   Wed Mar 24 08:34:39 2010 +0800

progs/egl: Link xeglthreads to libpthread.

This should hopefully fix a build failure reported by Chris Ball when
binutils-gold is used.

diff --git a/src/egl/Makefile b/src/egl/Makefile
index 8dfcb4e..890240f 100644
--- a/src/egl/Makefile
+++ b/src/egl/Makefile
@@ -60,7 +60,7 @@ xeglgears: xeglgears.o $(HEADERS) $(LIB_DEP)
$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) -lm $(X11_LIBS)
 
 xeglthreads: xeglthreads.o $(HEADERS) $(LIB_DEP)
-   $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) -lm $(X11_LIBS)
+   $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) -lpthread -lm $(X11_LIBS)
 
 xegl_tri: xegl_tri.o $(HEADERS) $(LIB_DEP)
$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) -lm $(X11_LIBS)


Apparently, the build system for 'mesa-demos' was reworked when they
ripped it out of 'mesa', and it had been working fine until now.  I see
this in the 'gcc-4.4' changelog (Feb. 15):

  * Pass --no-add-needed by default to the linker. See
http://wiki.debian.org/ToolChain/DSOLinking, section "Not resolving symbols
in indirect dependent shared libraries" for more information.

Is that the culprit?

By "checked" and "sent upstream," did you mean one of you XSF folks will
do that, or were you asking me to do that?


Thanks for your rapid response,
Dave W.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#614512: FTBFS in version 8.0.1-2

2011-02-22 Thread Cyril Brulebois 
Hi Dave,

Dave Witbrodt  (21/02/2011):
> I am getting a FTBFS when making a local build of mesa-demos using
> version 8.0.1-2.  I was able to build 8.0.1-1 from your git repo on
> Feb. 6 (before it was released), but my latest build attempt failed.

thanks to the last gcc-4.4 upload.

> I was able to resolve the problem after doing a bit of research.  I
> found that 'xeglgears.c' and 'xeglthreads.c' (in 'src/egl/opengl')
> both depend on libX11, and 'xeglthreads.c' also depends on
> libpthreads.

Thanks for the patch; it should be checked (not sure hardcoding
-lpthreads is the right thing to do) and then sent upstream.

KiBi.


signature.asc
Description: Digital signature

Bug#614512: FTBFS in version 8.0.1-2

2011-02-21 Thread Dave Witbrodt 
Source: mesa-demos
Version: 8.0.1-2
Severity: minor
Tags: patch


I am getting a FTBFS when making a local build of mesa-demos using
version 8.0.1-2.  I was able to build 8.0.1-1 from your git repo on
Feb. 6 (before it was released), but my latest build attempt failed.

I was able to resolve the problem after doing a bit of research.  I
found that 'xeglgears.c' and 'xeglthreads.c' (in 'src/egl/opengl') both
depend on libX11, and 'xeglthreads.c' also depends on libpthreads.

This apparently is a problem that has struck mesa-demos in the past,
before its sources were separated from mesa itself this past year.  I
found this online info, for example:

http://www.mail-archive.com/mesa3d-dev@lists.sourceforge.net/msg12679.html

I marked the severity as minor because I have a massively altered
graphics stack installed -- many packages built locally instead of
obtained from Debian servers -- and the problem may only affect me.
IOW, you may wish to dismiss this report out of hand.

My purpose of filing the bug is to provide an early warning to the
Debian XSF in case something has changed recently that is uncovering an
underlying bug.  As I mentioned before, I was able to build mesa-demos
before; tonight I could not.

I have attached a patch using 'reportbug -A'.  (If that fails to work,
let me know, and I will resend it.)  It is a two-liner which adds
*_LDADD specs for xegl{gears,threads} in 'Makefile.am' (dir:
'src/egl/opengl'); the build works fine for me with this patch applied.


HTH,
Dave W.


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (350, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.37.1+drm2.6.38+df110216.9f4283f4.110220.desktop.kms (SMP w/4 
CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u a/src/egl/opengl/Makefile.am b/src/egl/opengl/Makefile.am
--- a/src/egl/opengl/Makefile.am	2010-07-07 13:57:15.0 -0400
+++ b/src/egl/opengl/Makefile.am	2011-02-21 19:55:40.0 -0500
@@ -67,3 +67,6 @@
 
 eglgears_x11_LDADD = ../eglut/libeglut_x11.la
 egltri_x11_LDADD = ../eglut/libeglut_x11.la
+
+xeglgears_LDADD = $(X11_LIBS)
+xeglthreads_LDADD = $(X11_LIBS) -lpthread