Bug#619544: packagekit: please wipe out dependency_libs from .la files (Policy 10.2)

2011-03-25 Thread Matthias Klumpp
Hi!
Thanks for the explanation and the patch! It has been applied on our Git
repository and will be uploaded to Debian with PK 0.6.12-2, which is
currently blocked for unstable. (We need a higher version of GIR than
available in Sid) Maybe I will be pushed to experimental :)
Cheers,
   Matthias Klumpp






-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#619544: packagekit: please wipe out dependency_libs from .la files (Policy 10.2)

2011-03-24 Thread Steve Langasek
Package: packagekit
Version: 0.6.11-2
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu natty ubuntu-patch

Hi Matthias,

The attached patch has just been applied to the Ubuntu packagekit package,
to null out the dependency_libs field in the libtool .la file being shipped
in the -dev packages.  This is generally a good idea because it avoids
causing consumers of your library to require other .la files listed here to
be available at build time when they're not actually needed (i.e., in the
dynamic linking common case).  It's specifically a good idea right now
because multiarch is imminent, and that means the .la files referenced here
are going to *move* soon, causing build failures for anything using libtool
to build against packagekit.  As long as packagekit is going to need a
rebuild to fix up the invalid .la references, it would be nice to get rid of
them altogether.

Thanks,
--
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
=== modified file 'debian/rules'
--- debian/rules2011-01-25 15:54:54 +
+++ debian/rules2011-03-24 22:16:51 +
@@ -43,6 +43,10 @@
rm -f $(INSTALLDIR)/usr/lib/gtk-?.0/modules/*.la
rm -f 
$(INSTALLDIR)/usr/lib/polkit-1/extensions/libpackagekit-action-lookup.la
rm -f $(INSTALLDIR)/usr/bin/packagekit-bugreport.sh
+   # And these files should be cleaned to remove dependency_libs.
+   for file in $(INSTALLDIR)/usr/lib/*.la; do \
+   sed -i /dependency_libs/ s/'.*'/''/ $$file ; \
+   done
 
 override_dh_install:
dh_install --list-missing