Bug#622019: sslscan: FTBFS: sslscan.c:566: undefined reference to `SSLv2_client_method'

2011-08-26 Thread Christoph Berg
Re: Ilya Barygin 2011-08-23 4e53e126.6040...@gmail.com
 tags 622019 patch
 thanks
 
 Hello,
 
 Attached patch was used to fix this in Ubuntu.
 https://launchpad.net/ubuntu/+source/sslscan/1.8.2-1ubuntu1

 Description: Fix build in case of disabled SSLv2. This is needed for build 
 with
  OpenSSL 1.0.0.

Hmm... disabling SSLv2 kind of defeats the purpose of the package.
This is a monitoring tool to find servers supporting obsolete protocol
versions. Ideally, sslscan would bundle a library capable of speaking
SSLv2, but this is a pretty big hammer to implement.

Alternatively, is it possible to detect SSLv2 support in servers
without actually connecting with a v2 client library?

Christoph
-- 
c...@df7cb.de | http://www.df7cb.de/


signature.asc
Description: Digital signature


Bug#622019: sslscan: FTBFS: sslscan.c:566: undefined reference to `SSLv2_client_method'

2011-08-23 Thread Ilya Barygin
tags 622019 patch
thanks

Hello,

Attached patch was used to fix this in Ubuntu.
https://launchpad.net/ubuntu/+source/sslscan/1.8.2-1ubuntu1
Description: Fix build in case of disabled SSLv2. This is needed for build with
 OpenSSL 1.0.0.
Author: Ilya Barygin bary...@gmail.com
Bug-Debian: http://bugs.debian.org/622019
--- sslscan-1.8.2.orig/sslscan.c
+++ sslscan-1.8.2/sslscan.c
@@ -563,6 +563,7 @@
 	}
 	if (options-xmlOutput != 0)
 		fprintf(options-xmlOutput,  sslversion=\);
+#ifndef OPENSSL_NO_SSL2
 	if (sslCipherPointer-sslMethod == SSLv2_client_method())
 	{
 		if (options-xmlOutput != 0)
@@ -572,7 +573,9 @@
 		else
 			printf(SSLv2  );
 	}
-	else if (sslCipherPointer-sslMethod == SSLv3_client_method())
+	else
+#endif
+	if (sslCipherPointer-sslMethod == SSLv3_client_method())
 	{
 		if (options-xmlOutput != 0)
 			fprintf(options-xmlOutput, SSLv3\ bits=\);
@@ -688,6 +691,7 @@
 		cipherStatus = SSL_connect(ssl);
 		if (cipherStatus == 1)
 		{
+#ifndef OPENSSL_NO_SSL2
 			if (sslMethod == SSLv2_client_method())
 			{
 if (options-xmlOutput != 0)
@@ -697,7 +701,9 @@
 else
 	printf(SSLv2  );
 			}
-			else if (sslMethod == SSLv3_client_method())
+			else
+#endif
+			if (sslMethod == SSLv3_client_method())
 			{
 if (options-xmlOutput != 0)
 	fprintf(options-xmlOutput,   defaultcipher sslversion=\SSLv3\ bits=\);
@@ -1192,15 +1198,19 @@
 		switch (options-sslVersion)
 		{
 			case ssl_all:
+#ifndef OPENSSL_NO_SSL2
 status = defaultCipher(options, SSLv2_client_method());
 if (status != false)
+#endif
 	status = defaultCipher(options, SSLv3_client_method());
 if (status != false)
 	status = defaultCipher(options, TLSv1_client_method());
 break;
+#ifndef OPENSSL_NO_SSL2
 			case ssl_v2:
 status = defaultCipher(options, SSLv2_client_method());
 break;
+#endif
 			case ssl_v3:
 status = defaultCipher(options, SSLv3_client_method());
 break;
@@ -1415,13 +1425,17 @@
 			switch (options.sslVersion)
 			{
 case ssl_all:
+#ifndef OPENSSL_NO_SSL2
 	populateCipherList(options, SSLv2_client_method());
+#endif
 	populateCipherList(options, SSLv3_client_method());
 	populateCipherList(options, TLSv1_client_method());
 	break;
+#ifndef OPENSSL_NO_SSL2
 case ssl_v2:
 	populateCipherList(options, SSLv2_client_method());
 	break;
+#endif
 case ssl_v3:
 	populateCipherList(options, SSLv3_client_method());
 	break;


Bug#622019: sslscan: FTBFS: sslscan.c:566: undefined reference to `SSLv2_client_method'

2011-04-09 Thread Lucas Nussbaum
Source: sslscan
Version: 1.8.2-1
Severity: serious
Tags: wheezy sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20110408 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
 gcc -g -Wall -lssl -lcrypto -o sslscan sslscan.c  -g -O2
 sslscan.c: In function 'testCipher':
 sslscan.c:566:6: warning: implicit declaration of function 
 'SSLv2_client_method'
 sslscan.c:566:38: warning: comparison between pointer and integer
 sslscan.c: In function 'defaultCipher':
 sslscan.c:691:22: warning: comparison between pointer and integer
 sslscan.c: In function 'getCertificate':
 sslscan.c:811:13: warning: assignment discards qualifiers from pointer target 
 type
 sslscan.c: In function 'testHost':
 sslscan.c:1195:5: warning: passing argument 2 of 'defaultCipher' makes 
 pointer from integer without a cast
 sslscan.c:648:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'int'
 sslscan.c:1197:6: warning: passing argument 2 of 'defaultCipher' discards 
 qualifiers from pointer target type
 sslscan.c:648:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c:1199:6: warning: passing argument 2 of 'defaultCipher' discards 
 qualifiers from pointer target type
 sslscan.c:648:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c:1202:5: warning: passing argument 2 of 'defaultCipher' makes 
 pointer from integer without a cast
 sslscan.c:648:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'int'
 sslscan.c:1205:5: warning: passing argument 2 of 'defaultCipher' discards 
 qualifiers from pointer target type
 sslscan.c:648:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c:1208:5: warning: passing argument 2 of 'defaultCipher' discards 
 qualifiers from pointer target type
 sslscan.c:648:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c: In function 'main':
 sslscan.c:1418:6: warning: passing argument 2 of 'populateCipherList' makes 
 pointer from integer without a cast
 sslscan.c:128:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'int'
 sslscan.c:1419:6: warning: passing argument 2 of 'populateCipherList' 
 discards qualifiers from pointer target type
 sslscan.c:128:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c:1420:6: warning: passing argument 2 of 'populateCipherList' 
 discards qualifiers from pointer target type
 sslscan.c:128:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c:1423:6: warning: passing argument 2 of 'populateCipherList' makes 
 pointer from integer without a cast
 sslscan.c:128:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'int'
 sslscan.c:1426:6: warning: passing argument 2 of 'populateCipherList' 
 discards qualifiers from pointer target type
 sslscan.c:128:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 sslscan.c:1429:6: warning: passing argument 2 of 'populateCipherList' 
 discards qualifiers from pointer target type
 sslscan.c:128:5: note: expected 'struct SSL_METHOD *' but argument is of type 
 'const struct SSL_METHOD *'
 /tmp/ccWtWPvu.o: In function `testCipher':
 /build/user-sslscan_1.8.2-1-amd64-IKDDv2/sslscan-1.8.2/sslscan.c:566: 
 undefined reference to `SSLv2_client_method'
 /tmp/ccWtWPvu.o: In function `defaultCipher':
 /build/user-sslscan_1.8.2-1-amd64-IKDDv2/sslscan-1.8.2/sslscan.c:691: 
 undefined reference to `SSLv2_client_method'
 /tmp/ccWtWPvu.o: In function `testHost':
 /build/user-sslscan_1.8.2-1-amd64-IKDDv2/sslscan-1.8.2/sslscan.c:1195: 
 undefined reference to `SSLv2_client_method'
 /build/user-sslscan_1.8.2-1-amd64-IKDDv2/sslscan-1.8.2/sslscan.c:1202: 
 undefined reference to `SSLv2_client_method'
 /tmp/ccWtWPvu.o: In function `main':
 /build/user-sslscan_1.8.2-1-amd64-IKDDv2/sslscan-1.8.2/sslscan.c:1423: 
 undefined reference to `SSLv2_client_method'
 /tmp/ccWtWPvu.o:/build/user-sslscan_1.8.2-1-amd64-IKDDv2/sslscan-1.8.2/sslscan.c:1418:
  more undefined references to `SSLv2_client_method' follow
 collect2: ld returned 1 exit status

The full build log is available from:
   
http://people.debian.org/~lucas/logs/2011/04/08/sslscan_1.8.2-1_lsid64.buildlog

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.

-- 
| Lucas Nussbaum
| lu...@lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lu...@nussbaum.fr GPG: 1024D/023B3F4F |



-- 
To UNSUBSCRIBE, email to