Bug#623334: mr: git checkout checks out into wrong directory
On Tue, 19 Apr 2011 20:42:57 +0200 Richard Hartmann wrote: > Given that I am forced to specify a path anyway, the checkout should > obviously end up in work/git/ikiwiki . While shooting myself in the > foot by providing a different checkout path is of course my > privilege, but mr should default to doing the correct thing. I think that since `mr register` outputs the correct command but that the command you have written is broken, there is not much to do here. > Would it be acceptable to introduce a new config option like > > source = git+ssh://repo.or.cz/srv/git/foo > > that way, mr could Dot The Right Thing by default while still allowing > 'checkout' to do whatever the user wants it to. I'm leaning towards not having this, it feels like extra complexity and reduced flexibility. Perhaps mr could instead have a mode that checks the current value of checkout for the repo with the one `mr register` would output for the repo as it is now. -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#623334: mr: git checkout checks out into wrong directory
On Tue, Apr 19, 2011 at 18:59, Joey Hess wrote: > This tradeoff was made to allow mr checkout to run entirely arbitrary > commands. Would it be acceptable to introduce a new config option like source = git+ssh://repo.or.cz/srv/git/foo that way, mr could Dot The Right Thing by default while still allowing 'checkout' to do whatever the user wants it to. Maybe git_source or similar would be needed to enable mr to be certain what kind of remote to use. Richard -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#623334: mr: git checkout checks out into wrong directory
Richard Hartmann wrote: > When I use a config like this: > > richih@titanium ~/.config/mr/config.d % cat ikiwiki > [work/git/ikiwiki] > checkout = git clone git://git.ikiwiki.info/ > richih@titanium ~/.config/mr/config.d % > > the checkout ends up in ~/work/git/ikiwiki/git.ikiwiki.info . This tradeoff was made to allow mr checkout to run entirely arbitrary commands. One common example is to check out a git repository and then run git config in it, or switch to a branch other than master; another is to use an if statement to vary between anonymous and authed checkouts depending on locally available credentials. The downside of allowing arbitrary commands is that they cannot be tweaked to avoid foot-shooting. > Another weird side issue is that if I use > > richih@titanium ~/.config/mr/config.d % cat ikiwiki > [work/git/ikiwiki] > checkout = git clone git://git.ikiwiki.info/ foobar > richih@titanium ~/.config/mr/config.d % > > I end up with work/git/foobar so mr is obviously trying to put > everything into the correct parent directory. It runs the checkout command in the appropriate parent directory. -- see shy jo signature.asc Description: Digital signature
Bug#623334: mr: git checkout checks out into wrong directory
Package: mr Version: 1.02 Severity: normal When I use a config like this: richih@titanium ~/.config/mr/config.d % cat ikiwiki [work/git/ikiwiki] checkout = git clone git://git.ikiwiki.info/ richih@titanium ~/.config/mr/config.d % the checkout ends up in ~/work/git/ikiwiki/git.ikiwiki.info . Given that I am forced to specify a path anyway, the checkout should obviously end up in work/git/ikiwiki . While shooting myself in the foot by providing a different checkout path is of course my privilege, but mr should default to doing the correct thing. Another weird side issue is that if I use richih@titanium ~/.config/mr/config.d % cat ikiwiki [work/git/ikiwiki] checkout = git clone git://git.ikiwiki.info/ foobar richih@titanium ~/.config/mr/config.d % I end up with work/git/foobar so mr is obviously trying to put everything into the correct parent directory. Thanks, Richard -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.38-2-686 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash mr depends on no packages. Versions of packages mr recommends: ii libhtml-parser-perl 3.68-1 collection of modules that parse H ii libwww-perl 6.01-3 simple and consistent interface to ii perl 5.10.1-19 Larry Wall's Practical Extraction Versions of packages mr suggests: pn bzr(no description available) ii curl7.21.4-2 Get a file from an HTTP, HTTPS or ii cvs 1:1.12.13-12 Concurrent Versions System pn darcs (no description available) pn fossil (no description available) ii git [git-core] 1:1.7.4.4-1 fast, scalable, distributed revisi ii liburi-perl 1.58-1 module to manipulate and access UR pn mercurial (no description available) ii subversion 1.6.16dfsg-1 Advanced version control system -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
