Bug#627711: Intent to NMU (Re: Bug#627711: the connect window doesn't provide list of servers)
tags 627711 + pending thanks On Sun, Aug 21, 2011 at 12:24 PM, Theppitak Karoonboonyanan wrote: > On Thu, Aug 11, 2011 at 06:04:51PM +0700, Theppitak Karoonboonyanan wrote: >> On Sun, Aug 7, 2011 at 12:25 AM, Theppitak Karoonboonyanan >> wrote: >> > On Sat, Aug 6, 2011 at 1:14 PM, Theppitak Karoonboonyanan >> > wrote: >> > >> >> GNOME #656069 filed: >> >> >> >> https://bugzilla.gnome.org/show_bug.cgi?id=656069 >> > >> > FYI, the bug has been fixed upstream. >> >> May I request for a new upstream snapshot upload, to make the package >> usable again in testing? > > I have prepared a new upstream NMU here: > > http://people.debian.org/~thep/xchat-gnome_0.30.0~git20110821.e2a400-0.1.dsc > > with following changes: > > xchat-gnome (1:0.30.0~git20110821.e2a400-0.1) unstable; urgency=high > . > * Non-maintainer upload. > * New upstream git snapshot. > + Fix empty & non-functional connect & dcc dialogs Closes: #627711. > + Urgency high to fix long-lasting RC bug in testing. > * Drop all patches according to new upstream: > + 01_link_libice.patch: merged upstream. > + 02_libnotify_compat.patch: no longer needed. > + 03_dcc_window.patch: fixed differently upstream. > * Bump libnotify-dev B-Dep to (>= 0.7) as required by new upstream. > > (I have repacked the upstream 'make-dist' tarball with the top directory > renamed, as done in the recent release.) > > Is it OK to upload? NMU uploaded to DELAYED/2. Please feel free to override it or let me know if I should delay it longer. The mail from nmudiff has been blocked for 4 hours. So, I send a manual message instead. Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#627711: Intent to NMU (Re: Bug#627711: the connect window doesn't provide list of servers)
On Thu, Aug 11, 2011 at 06:04:51PM +0700, Theppitak Karoonboonyanan wrote: > On Sun, Aug 7, 2011 at 12:25 AM, Theppitak Karoonboonyanan > wrote: > > On Sat, Aug 6, 2011 at 1:14 PM, Theppitak Karoonboonyanan > > wrote: > > > >> GNOME #656069 filed: > >> > >> https://bugzilla.gnome.org/show_bug.cgi?id=656069 > > > > FYI, the bug has been fixed upstream. > > May I request for a new upstream snapshot upload, to make the package > usable again in testing? I have prepared a new upstream NMU here: http://people.debian.org/~thep/xchat-gnome_0.30.0~git20110821.e2a400-0.1.dsc with following changes: xchat-gnome (1:0.30.0~git20110821.e2a400-0.1) unstable; urgency=high . * Non-maintainer upload. * New upstream git snapshot. + Fix empty & non-functional connect & dcc dialogs Closes: #627711. + Urgency high to fix long-lasting RC bug in testing. * Drop all patches according to new upstream: + 01_link_libice.patch: merged upstream. + 02_libnotify_compat.patch: no longer needed. + 03_dcc_window.patch: fixed differently upstream. * Bump libnotify-dev B-Dep to (>= 0.7) as required by new upstream. (I have repacked the upstream 'make-dist' tarball with the top directory renamed, as done in the recent release.) Is it OK to upload? Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ signature.asc Description: Digital signature
Bug#627711: the connect window doesn't provide list of servers
On Sun, Aug 7, 2011 at 12:25 AM, Theppitak Karoonboonyanan wrote: > On Sat, Aug 6, 2011 at 1:14 PM, Theppitak Karoonboonyanan > wrote: > >> GNOME #656069 filed: >> >> https://bugzilla.gnome.org/show_bug.cgi?id=656069 > > FYI, the bug has been fixed upstream. May I request for a new upstream snapshot upload, to make the package usable again in testing? Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#627711: the connect window doesn't provide list of servers
On Sat, Aug 6, 2011 at 1:14 PM, Theppitak Karoonboonyanan wrote: > GNOME #656069 filed: > > https://bugzilla.gnome.org/show_bug.cgi?id=656069 FYI, the bug has been fixed upstream. Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#627711: the connect window doesn't provide list of servers
On Sat, Aug 6, 2011 at 12:42 PM, Theppitak Karoonboonyanan wrote: > But, yes, as you request this, I can forward it upstream (probably with > different patch) soon. GNOME #656069 filed: https://bugzilla.gnome.org/show_bug.cgi?id=656069 Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#627711: the connect window doesn't provide list of servers
On Sat, Aug 6, 2011 at 11:19 AM, Michael Biebl wrote: > Could you forward this issue upstream and get a review of the patch from the > upstream maintainer. > Looks like an upstream bug, so it should be fixed there. Sure. I didn't do this before for some reasons: I was not familiar with upstream code well enough, and latest upstream git seems to have other changes to the code, and different patch is required. xchat-gnome has been broken in testing for a long time (my user saw this when I distributed a customized CD image derived from testing, so I replaced it with xchat (without -gnome) as a workaround). So, I liked to have it fixed in testing first, and might work upstream later as needed. But, yes, as you request this, I can forward it upstream (probably with different patch) soon. Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#627711: the connect window doesn't provide list of servers
Hi, Am 06.08.2011 06:09, schrieb Theppitak Karoonboonyanan: > On Sat, Jul 30, 2011 at 4:41 AM, Theppitak Karoonboonyanan > wrote: > >> I think I've found a more correct patch: the "toplevel" scrolled box >> should be re-parented from the Glade design to the actual dialog's >> vbox. >> >> With this, I also fix the dcc-dialog (file transfer) in the same manner. > > Any progress on this? Is it OK for NMU? Could you forward this issue upstream and get a review of the patch from the upstream maintainer. Looks like an upstream bug, so it should be fixed there. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#627711: the connect window doesn't provide list of servers
On Sat, Jul 30, 2011 at 4:41 AM, Theppitak Karoonboonyanan wrote: > I think I've found a more correct patch: the "toplevel" scrolled box > should be re-parented from the Glade design to the actual dialog's > vbox. > > With this, I also fix the dcc-dialog (file transfer) in the same manner. Any progress on this? Is it OK for NMU? Regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#627711: the connect window doesn't provide list of servers
tags 627711 + patch
thanks
On Sat, Jul 30, 2011 at 12:26 AM, Theppitak Karoonboonyanan
wrote:
> I've been trying to fix this for myself, the derived ConnectDialog class
> appears to partially use the glade UI file, not the whole. Only the
> GtkScrolledWindow and GtkTreeView are referenced, not even the action
> buttons at the bottom. Instead, the buttons are explicitly created
> by the init function itself. This is broken somehow, and the bug still
> happens even in upstream git master. Looks like it's under unfinished
> development.
>
> My workaround is not to use the glade file at all. Just call GTK+
> functions directy to construct the widgets, as in the attached patch.
> (Note that this has yet to be done to other Glade-based UIs in the
> program as well.)
I think I've found a more correct patch: the "toplevel" scrolled box
should be re-parented from the Glade design to the actual dialog's
vbox.
With this, I also fix the dcc-dialog (file transfer) in the same manner.
Regards,
--
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/
Index: xchat-gnome-0.30.0~git20100421.29cc76/src/fe-gnome/connect-dialog.c
===
--- xchat-gnome-0.30.0~git20100421.29cc76.orig/src/fe-gnome/connect-dialog.c 2011-07-30 04:19:50.211908297 +0700
+++ xchat-gnome-0.30.0~git20100421.29cc76/src/fe-gnome/connect-dialog.c 2011-07-30 04:21:29.099913628 +0700
@@ -154,6 +154,8 @@
GtkTreeViewColumn *column = gtk_tree_view_column_new_with_attributes ("name", renderer, "text", 0, NULL);
gtk_tree_view_append_column (GTK_TREE_VIEW (dialog->server_list), column);
+ gtk_widget_reparent (dialog->toplevel, GTK_DIALOG(dialog)->vbox);
+
GtkWidget *button = gtk_button_new_with_mnemonic (_("C_onnect"));
gtk_dialog_add_button (GTK_DIALOG (dialog), GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE);
gtk_dialog_add_action_widget (GTK_DIALOG (dialog), button, GTK_RESPONSE_OK);
Index: xchat-gnome-0.30.0~git20100421.29cc76/src/fe-gnome/dcc-window.c
===
--- xchat-gnome-0.30.0~git20100421.29cc76.orig/src/fe-gnome/dcc-window.c 2011-07-30 04:22:04.623915540 +0700
+++ xchat-gnome-0.30.0~git20100421.29cc76/src/fe-gnome/dcc-window.c 2011-07-30 04:25:13.783925734 +0700
@@ -109,6 +109,8 @@
gtk_tree_view_set_model (GTK_TREE_VIEW (window->transfer_list), GTK_TREE_MODEL (window->transfer_store));
+ gtk_widget_reparent (window->toplevel, window);
+
gtk_container_set_border_width (GTK_CONTAINER (window), 12);
gtk_window_set_default_size (GTK_WINDOW (window), 300, 400);
Bug#627711: the connect window doesn't provide list of servers
Package: xchat-gnome
Version: 1:0.30.0~git20100421.29cc76-1
Followup-For: Bug #627711
I've been trying to fix this for myself, the derived ConnectDialog class
appears to partially use the glade UI file, not the whole. Only the
GtkScrolledWindow and GtkTreeView are referenced, not even the action
buttons at the bottom. Instead, the buttons are explicitly created
by the init function itself. This is broken somehow, and the bug still
happens even in upstream git master. Looks like it's under unfinished
development.
My workaround is not to use the glade file at all. Just call GTK+
functions directy to construct the widgets, as in the attached patch.
(Note that this has yet to be done to other Glade-based UIs in the
program as well.)
I know this may not be what upstream wants to adopt, as they obviously
want to use GtkBuilder over the derived GObject class. Just wish it
helps somehow to push this bug further.
Another choice is to downgrade to latest stable release?
Regards,
--
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/
Index: xchat-gnome-0.30.0~git20100421.29cc76/src/fe-gnome/connect-dialog.c
===
--- xchat-gnome-0.30.0~git20100421.29cc76.orig/src/fe-gnome/connect-dialog.c 2011-07-28 15:50:38.659477045 +0700
+++ xchat-gnome-0.30.0~git20100421.29cc76/src/fe-gnome/connect-dialog.c 2011-07-30 00:03:42.851410611 +0700
@@ -132,20 +132,15 @@
static void
connect_dialog_init (ConnectDialog *dialog)
{
- gchar *path = locate_data_file ("connect-dialog.glade");
- g_assert(path != NULL);
+ dialog->toplevel = gtk_scrolled_window_new (NULL, NULL);
+ gtk_container_set_border_width (GTK_CONTAINER (dialog->toplevel), 5);
+ gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (dialog->toplevel),
+ GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
+ gtk_box_pack_start (GTK_BOX (GTK_DIALOG(dialog)->vbox),
+ dialog->toplevel, TRUE, TRUE, 0);
+ gtk_widget_show (dialog->toplevel);
- GtkBuilder *xml = gtk_builder_new ();
- g_assert (gtk_builder_add_from_file ( xml, path, NULL) != 0);
-
- g_free (path);
-
-#define GW(name) ((dialog->name) = GTK_WIDGET (gtk_builder_get_object (xml, #name)))
- GW(toplevel);
- GW(server_list);
-#undef GW
-
- g_object_unref (xml);
+ dialog->server_list = gtk_tree_view_new ();
dialog->server_store = gtk_list_store_new (2, G_TYPE_STRING, G_TYPE_POINTER);
gtk_tree_view_set_model (GTK_TREE_VIEW (dialog->server_list), GTK_TREE_MODEL (dialog->server_store));
@@ -154,6 +149,10 @@
GtkTreeViewColumn *column = gtk_tree_view_column_new_with_attributes ("name", renderer, "text", 0, NULL);
gtk_tree_view_append_column (GTK_TREE_VIEW (dialog->server_list), column);
+ gtk_scrolled_window_add_with_viewport (GTK_SCROLLED_WINDOW (dialog->toplevel),
+ dialog->server_list);
+ gtk_widget_show (dialog->server_list);
+
GtkWidget *button = gtk_button_new_with_mnemonic (_("C_onnect"));
gtk_dialog_add_button (GTK_DIALOG (dialog), GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE);
gtk_dialog_add_action_widget (GTK_DIALOG (dialog), button, GTK_RESPONSE_OK);
