Bug#630682: collectd: ping plugin ignores Interval in case of warnings

2012-11-22 Thread Sebastian Harl
tags 630682 +moreinfo
thanks

Hi,

On Thu, Jun 16, 2011 at 11:29:44AM +0200, Bernd Zeimetz wrote:
> whenever the ping plugin throws a WARNING and hits 'continue' in the
> main while loop, the Interval setting will be ignored as
> pthread_cond_timedwait is only executed when the whole loop body run
> trough successful. So when things like '"ping plugin: Cannot find host'
> happen, my syslog will be spammed...

Hrm, can you provide an example for that? From looking at the code, this
should not happen because 'continue' is only used in the inner iterator
loop. The main while loop does not use 'continue' at all but only uses
'break' to shutdown the ping-thread completely.

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin



signature.asc
Description: Digital signature


Bug#630682: collectd: ping plugin ignores Interval in case of warnings

2011-06-16 Thread Bernd Zeimetz
Package: collectd
Severity: important
Version: 4.10.1-1+squeeze2

Hi,

whenever the ping plugin throws a WARNING and hits 'continue' in the
main while loop, the Interval setting will be ignored as
pthread_cond_timedwait is only executed when the whole loop body run
trough successful. So when things like '"ping plugin: Cannot find host'
happen, my syslog will be spammed...

Please fix :)

Cheers,

Bernd

-- 
 Bernd ZeimetzDebian GNU/Linux Developer
 http://bzed.dehttp://www.debian.org
 GPG Fingerprints: ECA1 E3F2 8E11 2432 D485 DD95 EB36 171A 6FF9 435F



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org