Bug#631548: [libglew1.6] support multiarch: same

2011-06-24 Thread gregory hainaut
Package: libglew1.6
Version: 1.6.0-2.1
Severity: wishlist
Tags: patch


Dear maintainer,

The build toolchain was recently updated to support multiarch. I wrote a
small patch to convert libglew (1.6) to multiarch same. I based my
work on 
http://wiki.debian.org/Multiarch/Implementation

Warning it would need more testing. Dh compatibility must be check
(level goes from 5 to 9, the latter is required by multiarch). I check
lintian and the manpage but I'm a beginner.

Dpkg (sid) does not fully enable multiarch yet, so those build warning
are expected DEBIAN/control' contains user-defined field 'Multi-Arch'

Patch description:
1/ increase compat from 5 to 9 
2/ rule file: Set LIBDIR variable based on $DEB_HOST_MULTIARCH
3/ control file: new dependencies for multiarch
4/ update *.install files with the new destination


Best regards,
Gregory

multiarch_glew.patch.gz
Description: GNU Zip compressed data


Bug#631548: [libglew1.6] support multiarch: same

2011-06-24 Thread Steve Langasek
Hi there,

On Fri, Jun 24, 2011 at 09:00:01PM +0200, gregory hainaut wrote:
 Package: libglew1.6
 Version: 1.6.0-2.1
 Severity: wishlist
 Tags: patch

 Dear maintainer,

 The build toolchain was recently updated to support multiarch. I wrote a
 small patch to convert libglew (1.6) to multiarch same. I based my
 work on 
 http://wiki.debian.org/Multiarch/Implementation

 Warning it would need more testing. Dh compatibility must be check
 (level goes from 5 to 9, the latter is required by multiarch). I check
 lintian and the manpage but I'm a beginner.

DH compat 9 is only interesting in a multiarch context if you are using
dh(1).  The appropiate recipe for converting this package to multiarch is
the classic debhelper one:

  
http://wiki.debian.org/Multiarch/Implementation#classic_debhelper_and_autotools

So since compat level 9 doesn't help this package for multiarch support, and
the interfaces for level 9 are still not finalized in debhelper, I would
recommend *not* including that part of the change.

Updating to compat 8 is reasonable, since this is the current recommended
compat level for debhelper; but that's orthogonal to updating for multiarch.

The rest of the patch looks sensible to me, though I haven't build-tested to
check the results.

Cheers,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: Digital signature


Bug#631548: [libglew1.6] support multiarch: same

2011-06-24 Thread gregory hainaut
Hello Steve,

Thanks for your feedback. I was mislead by the debhelper wrong man
page. Hopefully it will be fix in the coming release.

Refresh patch without compat change.

Best regards,
Gregory



multiarch_glew_v2.patch.gz
Description: GNU Zip compressed data