Bug#634451: hwinfo: FTBFS: /usr/include/dbus-1.0/dbus/dbus.h:29:33: fatal error: dbus/dbus-arch-deps.h: No such file or directory
tags 634451 + patch upstream thanks William Vera wrote: This is because dbus is already discontinued in Debian and hwinfo still depends on it D-Bus is not discontinued. (Perhaps you meant HAL?) This FTBFS appears to be caused by the multiarch transition: hwinfo wrongly hard-codes the CFLAGS for libdbus (which changed in dbus 1.4.12-3, and in recent Ubuntu versions too). It should ask pkg-config, which would work regardless of D-Bus version (and installed location, for that matter). Please forward this patch upstream - ideally they should be using pkg-config --libs for both D-Bus and HAL too, rather than hard-coding -ldbus-1 and -lhal, but that's less likely to fail randomly. Regards, Simon From 186314996ce970e922b3200fde33508eb3185aae Mon Sep 17 00:00:00 2001 From: Simon McVittie s...@debian.org Date: Wed, 27 Jul 2011 16:36:24 +0100 Subject: [PATCH] Use pkg-config for D-Bus' cpp flags instead of hard-coding them (Closes: #634451) --- debian/changelog |8 debian/control |2 +- debian/patches/dbus_pkg_config.patch | 20 debian/patches/series|1 + 4 files changed, 30 insertions(+), 1 deletions(-) create mode 100644 debian/patches/dbus_pkg_config.patch diff --git a/debian/changelog b/debian/changelog index aed826b..bc741ca 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +hwinfo (16.0-2.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * Use pkg-config for D-Bus' cpp flags instead of hard-coding them +(Closes: #634451, LP: #749278) + + -- Simon McVittie s...@debian.org Wed, 27 Jul 2011 16:19:36 +0100 + hwinfo (16.0-2) unstable; urgency=low * Added the patch to port to sh4 (Closes: #546151). diff --git a/debian/control b/debian/control index a2caf8d..8b12a88 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,7 @@ Source: hwinfo Section: admin Priority: optional Maintainer: William Vera bi...@billy.com.mx -Build-Depends: debhelper (= 7.2.11), quilt, perl, flex, libdbus-1-dev, libhal-dev, linux-kernel-headers, doxygen +Build-Depends: debhelper (= 7.2.11), quilt, perl, flex, libdbus-1-dev, libhal-dev, linux-kernel-headers, doxygen, pkg-config Standards-Version: 3.8.3 Package: hwinfo diff --git a/debian/patches/dbus_pkg_config.patch b/debian/patches/dbus_pkg_config.patch new file mode 100644 index 000..ee1f3f9 --- /dev/null +++ b/debian/patches/dbus_pkg_config.patch @@ -0,0 +1,20 @@ +From: Simon McVittie s...@debian.org +Subject: pick up cpp flags for dbus-1 from pkg-config instead of hard-coding + +Hard-coding the include path for dbus-1 is not recommended, and was broken +by the multiarch transition. The interface provided by upstream can be +summarized as use pkg-config. + +diff --git a/src/hd/Makefile b/src/hd/Makefile +index 3aa4819..be5b346 100644 +--- a/src/hd/Makefile b/src/hd/Makefile +@@ -4,7 +4,7 @@ CLEANFILES = version.h + + include $(TOPDIR)/Makefile.common + +-CFLAGS += -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include ++CFLAGS += $(shell pkg-config --cflags dbus-1) + + version.h: $(TOPDIR)/VERSION + @echo #define HD_VERSION_STRING \`cat $(TOPDIR)/VERSION`\ $@ diff --git a/debian/patches/series b/debian/patches/series index 355ae00..e2d7788 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -6,3 +6,4 @@ kbd.c-tiocgdev_undefined cpu.c-alpha_bogo fix-ftbfs sh_support.patch +dbus_pkg_config.patch -- 1.7.5.4
Bug#634451: hwinfo: FTBFS: /usr/include/dbus-1.0/dbus/dbus.h:29:33: fatal error: dbus/dbus-arch-deps.h: No such file or directory
HI On Wed, Jul 27, 2011 at 10:37 AM, Simon McVittie s...@debian.org wrote: tags 634451 + patch upstream thanks William Vera wrote: This is because dbus is already discontinued in Debian and hwinfo still depends on it D-Bus is not discontinued. (Perhaps you meant HAL?) Yes, my mistake This FTBFS appears to be caused by the multiarch transition: hwinfo wrongly hard-codes the CFLAGS for libdbus (which changed in dbus 1.4.12-3, and in recent Ubuntu versions too). It should ask pkg-config, which would work regardless of D-Bus version (and installed location, for that matter). I understood Please forward this patch upstream - ideally they should be using pkg-config --libs for both D-Bus and HAL too, rather than hard-coding -ldbus-1 and -lhal, but that's less likely to fail randomly. Thanks for your review and help, I'll update the package ASAP Regards, Simon Regards -- William Vera bi...@billy.com.mx PGP Key: 1024D/F5CC22A4 Fingerprint: 3E73 FA1F 5C57 6005 0439 4D75 1FD2 BF96 F5CC 22A4 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634451: hwinfo: FTBFS: /usr/include/dbus-1.0/dbus/dbus.h:29:33: fatal error: dbus/dbus-arch-deps.h: No such file or directory
Hi! On Mon, Jul 18, 2011 at 5:25 PM, Lucas Nussbaum lu...@lucas-nussbaum.net wrote: Source: hwinfo Version: 16.0-2 Severity: serious Tags: wheezy sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20110718 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part: make[3]: Entering directory `/build/hwinfo-Krq4gl/hwinfo-16.0/src/hd' gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include bios.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include block.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include braille.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include cpu.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include edd.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include fb.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include floppy.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include hal.c In file included from hal.c:18:0: /usr/include/dbus-1.0/dbus/dbus.h:29:33: fatal error: dbus/dbus-arch-deps.h: No such file or directory compilation terminated. make[3]: *** [hal.o] Error 1 This is because dbus is already discontinued in Debian and hwinfo still depends on it, I'm working on the new version that corrects this bug. I hope to have it ready this weekend The full build log is available from: http://people.debian.org/~lucas/logs/2011/07/18/hwinfo_16.0-2_lsid64.buildlog A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on about 50 AMD64 nodes of the Grid'5000 platform, using a clean chroot. Internet was not accessible from the build systems. Thanks for the report -- | Lucas Nussbaum | lu...@lucas-nussbaum.net http://www.lucas-nussbaum.net/ | | jabber: lu...@nussbaum.fr GPG: 1024D/023B3F4F | Cheers -- William Vera bi...@billy.com.mx PGP Key: 1024D/F5CC22A4 Fingerprint: 3E73 FA1F 5C57 6005 0439 4D75 1FD2 BF96 F5CC 22A4 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634451: hwinfo: FTBFS: /usr/include/dbus-1.0/dbus/dbus.h:29:33: fatal error: dbus/dbus-arch-deps.h: No such file or directory
Source: hwinfo Version: 16.0-2 Severity: serious Tags: wheezy sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20110718 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part: make[3]: Entering directory `/build/hwinfo-Krq4gl/hwinfo-16.0/src/hd' gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include bios.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include block.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include braille.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include cpu.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include edd.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include fb.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include floppy.c gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g -fPIC -I../../src/hd -I /usr/include/dbus-1.0 -I /usr/lib64/dbus-1.0/include -I /usr/lib/dbus-1.0/include hal.c In file included from hal.c:18:0: /usr/include/dbus-1.0/dbus/dbus.h:29:33: fatal error: dbus/dbus-arch-deps.h: No such file or directory compilation terminated. make[3]: *** [hal.o] Error 1 The full build log is available from: http://people.debian.org/~lucas/logs/2011/07/18/hwinfo_16.0-2_lsid64.buildlog A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on about 50 AMD64 nodes of the Grid'5000 platform, using a clean chroot. Internet was not accessible from the build systems. -- | Lucas Nussbaum | lu...@lucas-nussbaum.net http://www.lucas-nussbaum.net/ | | jabber: lu...@nussbaum.fr GPG: 1024D/023B3F4F | -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
