Bug#637020: pu: package zfsutils/8.1-5
Robert, am Mon, Aug 08, 2011 at 03:45:12PM +0200 hast du folgendes geschrieben: 2011/8/8 Philipp Kern pk...@debian.org: I presume that it would still unshare the volume prior to umount? Your change seems to contradict the OpenSolaris ZFS documentation[1]. It postulates that automatic mount management is what you want and the other way is legacy. Now the consequence of that chance is that the ZFS data structures tell that they should be automounted at $location but we ignore that now? Doesn't that have the potential for breakage upon the next reboot after installing that stable update? (Especially for machines with a single kFreeBSDZFS instance, i.e. servers?) Uhm yes, you're right. The real problem is that partman-zfs shouldn't be marking filesystems as auto-mountable, it should use legacy mode. I've documented this as bug #637086 (and reverted my change in sid). As for zfsutils, please consider this package update instead. I discarded the automount part, and I'm also proposing addition of the bash-completion script that was added in 8.2-3. please use version 8.1-4+squeeze1 and target stable. Otherwise ACK, please go ahead. Kind regards Philipp Kern signature.asc Description: Digital signature
Bug#637020: pu: package zfsutils/8.1-5
2011/9/18 Philipp Kern pk...@debian.org: please use version 8.1-4+squeeze1 and target stable. Otherwise ACK, please go ahead. Uploaded, thanks. Btw, is there any guideline on when to use X.Y+squeezeZ and then to just increment Y? I notice that both schemes are used. -- Robert Millan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#637020: pu: package zfsutils/8.1-5
tag 637020 + pending thanks On Sun, 2011-09-18 at 18:51 +0200, Robert Millan wrote: 2011/9/18 Philipp Kern pk...@debian.org: please use version 8.1-4+squeeze1 and target stable. Otherwise ACK, please go ahead. Uploaded, thanks. I've marked the package for acceptance at the next dinstall. Btw, is there any guideline on when to use X.Y+squeezeZ and then to just increment Y? I notice that both schemes are used. +squeezeZ is generally preferable as it's more obvious that it was a post-release update and much easier to avoid clashes with previously used version numbers. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#637020: pu: package zfsutils/8.1-5
2011/8/8 Philipp Kern pk...@debian.org:
I presume that it would still unshare the volume prior to umount?
Your change seems to contradict the OpenSolaris ZFS documentation[1]. It
postulates that automatic mount management is what you want and the other way
is legacy. Now the consequence of that chance is that the ZFS data structures
tell that they should be automounted at $location but we ignore that now?
Doesn't that have the potential for breakage upon the next reboot after
installing that stable update? (Especially for machines with a single
kFreeBSDZFS instance, i.e. servers?)
Uhm yes, you're right. The real problem is that partman-zfs shouldn't
be marking filesystems as auto-mountable, it should use legacy mode.
I've documented this as bug #637086 (and reverted my change in sid).
As for zfsutils, please consider this package update instead. I
discarded the automount part, and I'm also proposing addition of the
bash-completion script that was added in 8.2-3.
--
Robert Millan
Index: debian/zfsutils.zfs.init
===
--- debian/zfsutils.zfs.init (revision 3674)
+++ debian/zfsutils.zfs.init (working copy)
@@ -3,6 +3,8 @@
# Provides: zvol zfs
# Required-Start:
# Required-Stop:
+# X-Start-Before:checkroot
+# X-Stop-After: umountfs
# Default-Start: S
# Default-Stop: 0 6
# Short-Description: Start/stop ZFS subsystem.
Index: debian/changelog
===
--- debian/changelog (revision 3674)
+++ debian/changelog (working copy)
@@ -1,3 +1,13 @@
+zfsutils (8.1-5) unstable; urgency=low
+
+ * Set X-Start-Before: checkroot so that boot doesn't break when
+fstab relies on ZFS volumes. (Closes: #635627)
+ * Set X-Stop-After: umountfs to ensure ZVOLs are no longer in use
+when zfs volfini is called.
+ * Add bash_completion script (stolen from zfs-fuse).
+
+ -- Robert Millan r...@debian.org Mon, 08 Aug 2011 13:35:06 +
+
zfsutils (8.1-4) unstable; urgency=low
* Create a /boot/zfs/ directory in zfsutils-udeb, so that zpool.cache
Index: debian/zfsutils.install
===
--- debian/zfsutils.install (revision 3674)
+++ debian/zfsutils.install (working copy)
@@ -1,2 +1,3 @@
cddl/sbin/zpool/zpool /sbin
cddl/sbin/zfs/zfs /sbin
+debian/local/bash_completion.d/zfsutils /etc/bash_completion.d
Index: debian/local/bash_completion.d/zfsutils
===
--- debian/local/bash_completion.d/zfsutils (revision 0)
+++ debian/local/bash_completion.d/zfsutils (revision 0)
@@ -0,0 +1,232 @@
+# Copyright (c) 2010, Aneurin Price aneurin.pr...@gmail.com
+
+# Permission is hereby granted, free of charge, to any person
+# obtaining a copy of this software and associated documentation
+# files (the Software), to deal in the Software without
+# restriction, including without limitation the rights to use,
+# copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the
+# Software is furnished to do so, subject to the following
+# conditions:
+
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+
+# THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+# OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+# HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+# WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+# OTHER DEALINGS IN THE SOFTWARE.
+
+__zfs_get_commands()
+{
+zfs 21 | awk '/^\t[a-z]/ {print $1}' | uniq
+}
+
+__zfs_get_properties()
+{
+zfs get 21 | awk '$2 == YES || $2 == NO {print $1}'; echo all
+}
+
+__zfs_get_editable_properties()
+{
+zfs get 21 | awk '$2 == YES {printf(%s=\n, $1)}'
+}
+
+__zfs_get_inheritable_properties()
+{
+zfs get 21 | awk '$3 == YES {print $1}'
+}
+
+__zfs_list_datasets()
+{
+zfs list -H -o name
+}
+
+__zfs_list_filesystems()
+{
+zfs list -H -o name -t filesystem
+}
+
+__zfs_list_snapshots()
+{
+zfs list -H -o name -t snapshot
+}
+
+__zfs_list_volumes()
+{
+zfs list -H -o name -t volume
+}
+
+__zfs_argument_chosen()
+{
+for word in $(seq $((COMP_CWORD-1)) -1 2)
+do
+local prev=${COMP_WORDS[$word]}
+for property in $@
+do
+if [ x$prev = x$property ]
+then
+return 0
+fi
+done
+done
+return 1
+}
+
+__zfs_complete_ordered_arguments()
+{
+local list1=$1
+local list2=$2
+local cur=$3
+local extra=$4
+if __zfs_argument_chosen $list1
+then
+COMPREPLY=($(compgen -W $list2 $extra -- $cur))
Bug#637020: pu: package zfsutils/8.1-5
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: pu This proposed update fixes three problems that may cause boot errors when zfsutils is installed: * Set X-Start-Before: checkroot so that boot doesn't break when fstab relies on ZFS volumes. (Closes: #635627) * Do not mount/unmount filesystems! This may result in unbootable system if their mountpoints collide (typical in a dual-boot machine). Use /etc/fstab instead. * Set X-Stop-After: umountfs to ensure ZVOLs are no longer in use when zfs volfini is called. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: kfreebsd-amd64 (x86_64) Kernel: kFreeBSD 8.2-1-amd64 Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Index: debian/zfsutils.zfs.init === --- debian/zfsutils.zfs.init (revision 3674) +++ debian/zfsutils.zfs.init (working copy) @@ -3,6 +3,8 @@ # Provides: zvol zfs # Required-Start: # Required-Stop: +# X-Start-Before:checkroot +# X-Stop-After: umountfs # Default-Start: S # Default-Stop: 0 6 # Short-Description: Start/stop ZFS subsystem. @@ -41,15 +43,6 @@ esac done - # filesystems - log_progress_msg filesystems - zfs mount -a - RET=$? - if [ $RET != 0 ] ; then - log_end_msg $RET - exit $RET - fi - # end log_end_msg 0 } @@ -82,21 +75,6 @@ exit $RET fi - # filesystems - log_progress_msg filesystems - zfs unshare -a - RET=$? - if [ $RET != 0 ] ; then - log_end_msg $RET - exit $RET - fi - zfs umount -a - RET=$? - if [ $RET != 0 ] ; then - log_end_msg $RET - exit $RET - fi - # end log_end_msg 0 } Index: debian/changelog === --- debian/changelog (revision 3674) +++ debian/changelog (working copy) @@ -1,3 +1,15 @@ +zfsutils (8.1-5) unstable; urgency=low + + * Set X-Start-Before: checkroot so that boot doesn't break when +fstab relies on ZFS volumes. (Closes: #635627) + * Do not mount/unmount filesystems! This may result in unbootable +system if their mountpoints collide (typical in a dual-boot +machine). Use /etc/fstab instead. + * Set X-Stop-After: umountfs to ensure ZVOLs are no longer in use +when zfs volfini is called. + + -- Robert Millan r...@debian.org Sun, 07 Aug 2011 20:31:55 + + zfsutils (8.1-4) unstable; urgency=low * Create a /boot/zfs/ directory in zfsutils-udeb, so that zpool.cache
Bug#637020: pu: package zfsutils/8.1-5
Hi, On Sun, Aug 07, 2011 at 08:45:21PM +, Robert Millan wrote: This proposed update fixes three problems that may cause boot errors when zfsutils is installed: [...] * Do not mount/unmount filesystems! This may result in unbootable system if their mountpoints collide (typical in a dual-boot machine). Use /etc/fstab instead. I presume that it would still unshare the volume prior to umount? Your change seems to contradict the OpenSolaris ZFS documentation[1]. It postulates that automatic mount management is what you want and the other way is legacy. Now the consequence of that chance is that the ZFS data structures tell that they should be automounted at $location but we ignore that now? Doesn't that have the potential for breakage upon the next reboot after installing that stable update? (Especially for machines with a single kFreeBSDZFS instance, i.e. servers?) Kind regards, Philipp Kern [1] http://dlc.sun.com/osol/docs/content/ZFSADMIN/gaynd.html#gamnd -- .''`. Philipp KernDebian Developer : :' : http://philkern.de Stable Release Manager `. `' xmpp:p...@0x539.de Wanna-Build Admin `-finger pkern/k...@db.debian.org signature.asc Description: Digital signature
