Bug#637543: libpam-ldap: pam_template_login not working as documented in manpage

[Hermann Lauer]

Package: libpam-ldap
Version: 184-8.6
Followup-For: Bug #637543

Dear Maintainer,
the patch send in for squeeze is needed to fix this issue also in wheezy.
It was running on squeeze over 2 years and on wheezy 2 weeks now 
without any problems.

Please consider inclusion,
thanks  greetings
  Hermann

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages libpam-ldap depends on:
ii  debconf [debconf-2.0]  1.5.49
ii  libc6  2.13-38
ii  libldap-2.4-2  2.4.31-1+nmu2
ii  libpam-runtime 1.1.3-7.1
ii  libpam0g   1.1.3-7.1

libpam-ldap recommends no packages.

Versions of packages libpam-ldap suggests:
ii  libnss-ldap  264-2.5

-- debconf information:
* shared/ldapns/base-dn: dc=example,dc=net
* shared/ldapns/ldap-server: 127.0.0.1
  libpam-ldap/pam_password: crypt
  libpam-ldap/binddn: cn=proxyuser,dc=example,dc=net
* libpam-ldap/rootbinddn: cn=manager,dc=example,dc=net
* libpam-ldap/dbrootlogin: true
* libpam-ldap/override: false
* shared/ldapns/ldap_version: 3
* libpam-ldap/dblogin: false


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#637543: libpam-ldap: pam_template_login not working as documented in manpage

[Hermann Lauer]

Package: libpam-ldap
Version: 184-8.5
Severity: normal
Tags: patch

the appended small fix makes pam_template_login_attribute and pam_template_login
working for my case as described in the manpage. Please review
and tell me if I missed something.

Thanks,
  Hermann

-- System Information:
Debian Release: 6.0.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages libpam-ldap depends on:
ii  debconf [debconf-2.0] 1.5.36.1   Debian configuration management sy
ii  libc6 2.11.2-10  Embedded GNU C Library: Shared lib
ii  libldap-2.4-2 2.4.23-7.2 OpenLDAP libraries
ii  libpam-runtime1.1.1-6.1  Runtime support for the PAM librar
ii  libpam0g  1.1.1-6.1  Pluggable Authentication Modules l

libpam-ldap recommends no packages.

Versions of packages libpam-ldap suggests:
ii  libnss-ldap   264-2.2NSS module for using LDAP as a nam

-- debconf information excluded
# HG changeset patch
# Parent 26d0443ed3ec92e7f0fcc48eec53863aec4ef408

diff --git a/pam_ldap.c b/pam_ldap.c
--- a/pam_ldap.c
+++ b/pam_ldap.c
@@ -3324,7 +3324,7 @@
 
 	  if (rc == PAM_SUCCESS  session-info-tmpluser != NULL 
 	  session-conf-tmpluser != NULL 
-	  strcmp (session-info-tmpluser, session-conf-tmpluser) == 0)
+	  strcmp (session-info-tmpluser, session-conf-tmpluser) != 0)
 	{
 	  (void) pam_set_data (pamh, PADL_LDAP_AUTH_DATA,
    (void *) strdup (session-info-username),
@@ -3354,7 +3354,7 @@
*/
   if (rc == PAM_SUCCESS  session-info-tmpluser != NULL 
   session-conf-tmpluser != NULL 
-  strcmp (session-info-tmpluser, session-conf-tmpluser) == 0)
+  strcmp (session-info-tmpluser, session-conf-tmpluser) != 0)
 {
   /* keep original username for posterity */