Bug#639292: lintian: --color=html does not close 'p' - breaks xhtml (lintian.d.o)
On 2011-08-25 21:15, Adam D. Barratt wrote: On Thu, 2011-08-25 at 19:15 +0200, Niels Thykier wrote: Notice how none of the p tags are closed; given xhtml is xml-based, all tags must be closed or the document will be malformed. [...] push(@o,p$_\n); [...] becomes [...] push(@o,p$_/p\n); [...] but I do not fully understand the code there. It's a fairly uncomplicated function, other than keeping track of whether we're trying to display literal text - e.g the two examples on http://lintian.debian.org/tags/binary-or-shlib-defines-rpath.html - and your change looks sane enough to me, fwiw. Okay, I applied it and cherry-picked it to lintian.d.o; the w3.org validator seems to approve[1], so that's always something. :) While we're on the subject of that page, it would be nice to do something about the pre - p spacing, as at least in Iceweasel here there's a large gap after each of the gcc lines. I agree, but I think we need someone to mess with the .css file then. The resulting source is: pTo fix this problem, look for link lines like:/p pre gcc test.o -o test -Wl,--rpath,/usr/local/lib /pre por/p pre gcc test.o -o test -R/usr/local/lib /pre pand remove the tt-Wl,--rpath/tt or [...]/p I see nothing here in the html that adds unneeded line breaks. On a related note; I am not good with .css. Regards, Adam ~Niels [1] http://validator.w3.org/check?uri=http%3A%2F%2Flintian.debian.org%2Ftags%2Fbinary-or-shlib-defines-rpath.htmlcharset=%28detect+automatically%29doctype=Inliness=1group=0verbose=1user-agent=W3C_Validator%2F1.2 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639292: lintian: --color=html does not close 'p' - breaks xhtml (lintian.d.o)
Niels Thykier ni...@thykier.net writes: I agree, but I think we need someone to mess with the .css file then. The resulting source is: pTo fix this problem, look for link lines like:/p pre gcc test.o -o test -Wl,--rpath,/usr/local/lib /pre por/p pre gcc test.o -o test -R/usr/local/lib /pre pand remove the tt-Wl,--rpath/tt or [...]/p I see nothing here in the html that adds unneeded line breaks. On a related note; I am not good with .css. IIRC, you'll find that killing the line breaks inside the pre will help. In other words, you want: pre gcc test.o -o test -Wl,--rpath,/usr/local/lib/pre instead. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639292: lintian: --color=html does not close 'p' - breaks xhtml (lintian.d.o)
Package: lintian Version: 2.5.2 Severity: minor -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Source snippet from http://lintian.debian.org/tags/arch-dep-package-has-big-usr-share.html Notice how none of the p tags are closed; given xhtml is xml-based, all tags must be closed or the document will be malformed. blockquote class=type-I pThe package has a significant amount of architecture-independent data (over 4MB, or over 2MB and more than 50% of the package) in tt/usr/share/tt but is an architecture-dependent package. This is wasteful of mirror space and bandwidth since it means distributing multiple copies of this data, one for each architecture. pIf the data in tt/usr/share/tt is not architecture-independent, this is a Policy violation that should be fixed by moving the data elsewhere (usually tt/usr/lib/tt). pRefer to a href=http://www.debian.org/doc/developers-reference/;Debian Developer's Reference/a section 6.7.5 (a href=http://www.debian.org/doc/developers-reference/best-pkging-practices.html#bpp-archindepdata;Architecture-independent data/a) for details. pSeverity: wishlist, Certainty: certain pCheck: huge-usr-share, Type: binary /blockquote This seems to be caused by dtml_to_html in lib/Text_utils.pm; it seems to work if [...] push(@o,p$_\n); [...] becomes [...] push(@o,p$_/p\n); [...] but I do not fully understand the code there. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOVoM+AAoJEAVLu599gGRCYaIP/RJ/ZTVK9DzG2UM1SkB1xoU3 34z1ADa6jigQwdiQ5OEBCveI/bHJQEpmE4JgeuQe3inD2ha+PGOOIoTrsRpJZYnZ ELGROJO578so0eIIzLANSlH7PViD/Gkd/67ZQ+2d0BqJjopugkIZrXj5GdQj/XwC h/IG7xL+z6FNp5Cp6GgsLT9va9G+SJo2WeuA9uhlDDNyZiZJn+5iZqJ1wo8Zl499 +Rs4agMeLfha0VJC3AvxTqB7BRB4krq4cKnS5Uh9qBsOI+OIBP1EZKcjTaVai9fj jcakc3z97Aav0cMY5doxnMSrIBuBZ4AF5u+tfKg+hvzm6DlOEXY1MUl7hofVOKaY Og7UxFV6k3WgmgfM0ggpRgraKjIJNrwFCz84eCyiQ6YzLbg7tn3H0Rj4BduH3CZ+ 30ReKEnbgBMC7eZ0Z5sSd/R61lpMfFwDQNJ6hCOJembDRQR6hLw5lh/3qMPbXV0V LUzb2j2ESNUeG0TJeIYDD5rRKUbiadZ7mFZPXqcM3J5y9xunWQDmEzlzTkEWX1GI RqTdJCJmIe+YvpPrxF7ECh+Y9L4NXjXK9GZ48+jugg+gMXQzK22+YA4pU0tTFMPa HX/IFcjeRFN+7VsWTb4zSZaquy+e93NWj9pnpfgilkPxCVQmPtVgjw5D9rDeiml1 OfP3w92h4mXbU5Gh0CDJ =W3QN -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639292: lintian: --color=html does not close 'p' - breaks xhtml (lintian.d.o)
On Thu, 2011-08-25 at 19:15 +0200, Niels Thykier wrote: Notice how none of the p tags are closed; given xhtml is xml-based, all tags must be closed or the document will be malformed. [...] push(@o,p$_\n); [...] becomes [...] push(@o,p$_/p\n); [...] but I do not fully understand the code there. It's a fairly uncomplicated function, other than keeping track of whether we're trying to display literal text - e.g the two examples on http://lintian.debian.org/tags/binary-or-shlib-defines-rpath.html - and your change looks sane enough to me, fwiw. While we're on the subject of that page, it would be nice to do something about the pre - p spacing, as at least in Iceweasel here there's a large gap after each of the gcc lines. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
