Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
On Fri, Sep 23, 2011 at 3:40 AM, Nelson A. de Oliveira nao...@debian.org wrote: It should remove this on purge. Hi Nelson, Why do you think it should be removed? The user might've put conf files in those dirs. Even other packages might've put conf files there. We can't just remove them. Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
Hi Olaf! On Fri, Sep 23, 2011 at 8:51 AM, Olaf van der Spek olafvds...@gmail.com wrote: Why do you think it should be removed? The user might've put conf files in those dirs. Even other packages might've put conf files there. We can't just remove them. I see two cases here: if the user is only removing the package (and not purging it), config files shouldn't be touched. Now when purging the package yes, it shouldn't be a blind rm -r /etc/lighttpd but at least it should remove it's own files/links (and let the files that were created locally or by other means). The example that I sent on the bug report fits on this second case: there is no local file and the only link was created by lighttpd-enable-mod itself. Thank you! Best regards, Nelson -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 fixed 642494 1.4.29-2 tags 642494 pending thanks Hi Nelson, On 23.09.2011 14:25, Nelson A. de Oliveira wrote: I see two cases here: if the user is only removing the package (and not purging it), config files shouldn't be touched. Now when purging the package yes, it shouldn't be a blind rm -r /etc/lighttpd but at least it should remove it's own files/links (and let the files that were created locally or by other means). I just commited a change to our trunk doing pretty much what you suggest. Upon purge a postrm script will remove all dangling symlinks found in /etc/lighttpd/conf-enabled [1]. This is all I can offer you, everything else is either the responsibility of the user or other package maintainers. You are invited to check out the fix and test it. [1] http://anonscm.debian.org/viewvc/pkg-lighttpd?view=revisionrevision=555 - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOfIGkAAoJEMcrUe6dgPNtpGoQALVyyajrNwlZ+JeqCMRXZVDe /DllqShMv/UqV1tq45v+RxYXY+rrNORUxuOKlTaBr0k75J1E+dEpn4OUtcBfcSkm AY6dRZ0gk8bJQ7JiRATJvxA8aXdBjrV71/BYJzchMHKToXjYNxAVOIVvXJjFYFfQ ETaSOMNUnEl7GD7WqOi7ZohAyadwFPQb+A/+H3+8Kg98UxFONJDn2nFUI4OQASLC jPQMueZBpFpe3hIl7zdg9hqruT8kZCCQVr9qow+VxOwJaGCX223zau8eGooZSPyi qDbCoSH194WjfFlGphyomU67lbCKll6lVjb1JC7sPQ3Y4YrbR3Ji/4Y8mKQtTLdo 4iY433BU92LY0W3Lqpn2tmBku3jP7ozi0KjCM87gEx07c3mFUI4DkGbDHg5R4jgN /OPqE6q0F/1ZbaivmvXzmhhHqxSzVCOrykkxiQsrZgV0vbhcUPguMaJ+lWy3ezRL 4Th3s+XK/+3BW75W9UxEMCeHYK2tDJFsRc3nr/wqwdDmHUX7ZjrvXnYFLqeqHNYQ r2Apq4c+VoJvrcTFdB7KMrVNIVTp9nLUfZI5KvCW+3bQMNAm/fZbS9DBzrJUXJ4J Ez39CELCx8sj/c6slcnwfln8OdLViH/MmwVbe0sptTGhAilpaedaVl8MFpSQVuWm S7E03Pv/GLosSJiPKZfd =JWOg -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
On Fri, Sep 23, 2011 at 2:25 PM, Nelson A. de Oliveira nao...@debian.org wrote: On Fri, Sep 23, 2011 at 8:51 AM, Olaf van der Spek olafvds...@gmail.com wrote: Why do you think it should be removed? The user might've put conf files in those dirs. Even other packages might've put conf files there. We can't just remove them. I see two cases here: if the user is only removing the package (and not purging it), config files shouldn't be touched. Of course Now when purging the package yes, it shouldn't be a blind rm -r /etc/lighttpd but at least it should remove it's own files/links (and let the files that were created locally or by other means). The example that I sent on the bug report fits on this second case: there is no local file and the only link was created by lighttpd-enable-mod itself. How is the code supposed to know who created a symlink? -- Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
Hi! On Fri, Sep 23, 2011 at 9:58 AM, Olaf van der Spek olafvds...@gmail.com wrote: Now when purging the package yes, it shouldn't be a blind rm -r /etc/lighttpd but at least it should remove it's own files/links (and let the files that were created locally or by other means). The example that I sent on the bug report fits on this second case: there is no local file and the only link was created by lighttpd-enable-mod itself. How is the code supposed to know who created a symlink? postrm code from Arno [1] does basically this (handle the case where lighttpd mods were left enabled before removing the package) [1] http://anonscm.debian.org/viewvc/pkg-lighttpd/lighttpd/trunk/debian/lighttpd.postrm?view=markuppathrev=555 Best regards, Nelson -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
On Fri, Sep 23, 2011 at 3:32 PM, Nelson A. de Oliveira nao...@debian.org wrote: Hi! On Fri, Sep 23, 2011 at 9:58 AM, Olaf van der Spek olafvds...@gmail.com wrote: Now when purging the package yes, it shouldn't be a blind rm -r /etc/lighttpd but at least it should remove it's own files/links (and let the files that were created locally or by other means). The example that I sent on the bug report fits on this second case: there is no local file and the only link was created by lighttpd-enable-mod itself. How is the code supposed to know who created a symlink? postrm code from Arno [1] does basically this (handle the case where lighttpd mods were left enabled before removing the package) [1] http://anonscm.debian.org/viewvc/pkg-lighttpd/lighttpd/trunk/debian/lighttpd.postrm?view=markuppathrev=555 That does not really answer the question. ;) Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#642494: [pkg-lighttpd] Bug#642494: Doesn't remove /etc/lighttpd on purge
Hi! On Fri, Sep 23, 2011 at 10:43 AM, Olaf van der Spek olafvds...@gmail.com wrote: That does not really answer the question. ;) Yes, it's not possible to know if the user manually enabled a mod or if he enabled it via lighttpd-enable-mod/lighty-enable-mod or something else. But I am satisfied with Arno's solution and I think that it's a good heuristic. Best regards, Nelson -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
