Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2012-08-15 Thread Jakub Moc
Can someone remove or at least reword this finally? Warning users
about default and recommended configuration makes absolutely no sense.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2012-06-05 Thread Paul Vojta
On Wed, Jun 06, 2012 at 02:30:03AM +0200, Tobias Diedrich wrote:
> Paul Vojta wrote:
> > On Sun, Feb 05, 2012 at 01:24:38PM +0100, Tobias Diedrich wrote:
> > > Package: pulseaudio
> > > Version: 1.1-2
> > > Followup-For: Bug #644809
> > > 
> > > -BEGIN PGP SIGNED MESSAGE-
> > > Hash: SHA1
> > > 
> > > Dear Maintainer,
> > > 
> > > FWIW I also found this confusing on package upgrade:
> > > Processing triggers for man-db ...
> > > Setting up pulseaudio (1.1-2) ...
> > > PulseAudio configured for per-user sessions ... (warning).
> > > 
> > > Especially since dpkg-reconfigure then offers no options, but also prints 
> > > the warning (because it reloads the init script):
> > > sudo dpkg-reconfigure pulseaudio
> > > PulseAudio configured for per-user sessions ... (warning).
> > > PulseAudio configured for per-user sessions ... (warning).
> > > 
> > > Cheers,
> > > Tobias
> > >
> > 
> > How about the following:
> > 
> > --- /root/pulseaudio-prev   2012-05-19 13:05:24.0 -0700
> > +++ /etc/init.d/pulseaudio  2012-06-04 16:06:01.813487453 -0700
> > @@ -26,7 +26,7 @@
> >  DISALLOW_MODULE_LOADING=1
> >  test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
> >  if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
> > -   log_warning_msg "PulseAudio configured for per-user sessions"
> > +   log_action_msg "Configuring PulseAudio for per-user sessions (not 
> > starting system daemon)"
> > exit 0
> >  fi
> >  
> 
> How about:
> 
> log_action_msg "PulseAudio not started: Configured for per-user sessions"
> 
> I wouldn't say "Configuring PulseAudio for per-user sessions" since
> it's not actually configuring anything. :)
> The above would instead say what action was taken (none) and why.
> 
> Cheers,
> 
> -- 
> TobiasPGP: 
> http://8ef7ddba.uguu.de

Sounds good.

Most such messages use parentheses, though; for example:

log_action_msg "PulseAudio not started (it is configured for per-user sessions)"

Sincerely,


Paul Vojta



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2012-06-05 Thread Tobias Diedrich
Paul Vojta wrote:
> On Sun, Feb 05, 2012 at 01:24:38PM +0100, Tobias Diedrich wrote:
> > Package: pulseaudio
> > Version: 1.1-2
> > Followup-For: Bug #644809
> > 
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA1
> > 
> > Dear Maintainer,
> > 
> > FWIW I also found this confusing on package upgrade:
> > Processing triggers for man-db ...
> > Setting up pulseaudio (1.1-2) ...
> > PulseAudio configured for per-user sessions ... (warning).
> > 
> > Especially since dpkg-reconfigure then offers no options, but also prints 
> > the warning (because it reloads the init script):
> > sudo dpkg-reconfigure pulseaudio
> > PulseAudio configured for per-user sessions ... (warning).
> > PulseAudio configured for per-user sessions ... (warning).
> > 
> > Cheers,
> > Tobias
> >
> 
> How about the following:
> 
> --- /root/pulseaudio-prev 2012-05-19 13:05:24.0 -0700
> +++ /etc/init.d/pulseaudio2012-06-04 16:06:01.813487453 -0700
> @@ -26,7 +26,7 @@
>  DISALLOW_MODULE_LOADING=1
>  test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
>  if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
> - log_warning_msg "PulseAudio configured for per-user sessions"
> + log_action_msg "Configuring PulseAudio for per-user sessions (not 
> starting system daemon)"
>   exit 0
>  fi
>  

How about:

log_action_msg "PulseAudio not started: Configured for per-user sessions"

I wouldn't say "Configuring PulseAudio for per-user sessions" since
it's not actually configuring anything. :)
The above would instead say what action was taken (none) and why.

Cheers,

-- 
Tobias  PGP: http://8ef7ddba.uguu.de



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2012-06-04 Thread Paul Vojta
On Sun, Feb 05, 2012 at 01:24:38PM +0100, Tobias Diedrich wrote:
> Package: pulseaudio
> Version: 1.1-2
> Followup-For: Bug #644809
> 
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> 
> Dear Maintainer,
> 
> FWIW I also found this confusing on package upgrade:
> Processing triggers for man-db ...
> Setting up pulseaudio (1.1-2) ...
> PulseAudio configured for per-user sessions ... (warning).
> 
> Especially since dpkg-reconfigure then offers no options, but also prints the 
> warning (because it reloads the init script):
> sudo dpkg-reconfigure pulseaudio
> PulseAudio configured for per-user sessions ... (warning).
> PulseAudio configured for per-user sessions ... (warning).
> 
> Cheers,
> Tobias
>

How about the following:

--- /root/pulseaudio-prev   2012-05-19 13:05:24.0 -0700
+++ /etc/init.d/pulseaudio  2012-06-04 16:06:01.813487453 -0700
@@ -26,7 +26,7 @@
 DISALLOW_MODULE_LOADING=1
 test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
 if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
-   log_warning_msg "PulseAudio configured for per-user sessions"
+   log_action_msg "Configuring PulseAudio for per-user sessions (not 
starting system daemon)"
exit 0
 fi
 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2012-02-05 Thread Tobias Diedrich
Package: pulseaudio
Version: 1.1-2
Followup-For: Bug #644809

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear Maintainer,

FWIW I also found this confusing on package upgrade:
Processing triggers for man-db ...
Setting up pulseaudio (1.1-2) ...
PulseAudio configured for per-user sessions ... (warning).

Especially since dpkg-reconfigure then offers no options, but also prints the 
warning (because it reloads the init script):
sudo dpkg-reconfigure pulseaudio
PulseAudio configured for per-user sessions ... (warning).
PulseAudio configured for per-user sessions ... (warning).

Cheers,
Tobias

- -- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.2 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pulseaudio depends on:
ii  adduser 3.113
ii  consolekit  0.4.5-1
ii  libasound2  1.0.24.1-4
ii  libasound2-plugins  1.0.24-3
ii  libc6   2.13-24
ii  libcap2 1:2.22-1
ii  libdbus-1-3 1.4.16-1
ii  libfftw3-3  3.3-1
ii  libice6 2:1.0.7-2
ii  libltdl72.4.2-1
ii  liborc-0.4-01:0.4.16-1
ii  libpulse0   1.1-2
ii  libsamplerate0  0.1.8-1
ii  libsm6  2:1.2.0-2
ii  libsndfile1 1.0.25-4
ii  libspeexdsp11.2~rc1-3
ii  libtdb1 1.2.9-4+b1
ii  libudev0175-3
ii  libx11-62:1.4.4-4
ii  libx11-xcb1 2:1.4.4-4
ii  libxcb1 1.7-4
ii  libxtst62:1.2.0-4
ii  lsb-base3.2-28
ii  udev175-3

Versions of packages pulseaudio recommends:
ii  gstreamer0.10-pulseaudio  0.10.30-2.1
ii  pulseaudio-esound-compat  
ii  pulseaudio-module-x11 1.0-4
ii  rtkit 0.10-2

Versions of packages pulseaudio suggests:
ii  paman 0.9.4-1
ii  paprefs   
ii  pavucontrol   0.99.2-1
ii  pavumeter 0.9.3-1
ii  pulseaudio-utils  1.0-4

- -- no debconf information

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFPLnUD5q/seprH4LwRAixQAKCCIfWVzISipbhsnBxE1QW+0uFWCACgiDM0
+VwvaxWXOUevxK6leoeAJDA=
=Vhs8
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#644809: [pulseaudio-discuss] Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2011-10-10 Thread Paul Menzel
Am Montag, den 10.10.2011, 10:55 +0200 schrieb Maarten Bosmans:
> 2011/10/9 Paul Menzel :

> > X-Debbugs-CC: pulseaudio-disc...@lists.freedesktop.org

Damn, I though that this setting would not put 
into the CC list and the correct bug address <644...@bugs.debian.org>.

> > Dear PulseAudio Debian packagers and upstream PA folks,
> >
> >
> > the Debian init script `/etc/init.d/pulseaudio` [1] currently prints a
> > warning when PA is configured in non-system mode.
> >
> >PULSEAUDIO_SYSTEM_START=0
> >DISALLOW_MODULE_LOADING=1
> >test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
> >if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
> >log_warning_msg "PulseAudio configured for per-user sessions"
> >exit 0
> >fi
> >
> > In my opinion a warning suggests that something might be wrong and
> > therefore I am bringing this issues to your attention.
> 
> First of all: I appreciate that Debian (and thus Ubuntu) provides the
> init script to make it easier to run pulse in system mode.
> 
> The warning is correct when /etc/init.d/pulseaudio start is invoked
> manually. Because in that case the user expects pulse to be started
> and it isn't.

True, I have not thought about that.

> For normal bootup procedure (on an unchanged system), the warning
> should not be shown, because then it is expected that pulse is run
> per-user.
> 
> > In `/etc/default/pulseaudio` [2] there is the following explanation.
> >
> ># Start the PulseAudio sound server in system mode.
> ># (enables the pulseaudio init script - requires that users be in the
> ># pulse-access group)
> ># System mode is not the recommended way to run PulseAudio as it has 
> > some
> ># limitations (such as no shared memory access) and could 
> > potentially allow
> ># users to disconnect or redirect each others' audio streams. The
> ># recommended way to run PulseAudio is as a per-session daemon. For 
> > GNOME/KDE/
> ># Xfce sessions in Ubuntu Lucid/10.04, 
> > /etc/xdg/autostart/pulseaudio.desktop
> ># handles this function of automatically starting PulseAudio on 
> > login, and for
> ># it to work correctly your user must *not* have "autospawn = no" 
> > set in
> ># ~/.pulse/client.conf (or in /etc/pulse/client.conf). By default, 
> > autospawn
> ># is enabled. For other sessions, you can simply start PulseAudio 
> > with
> ># "pulseaudio --daemonize".
> ># 0 = don't start in system mode, 1 = start in system mode
> >PULSEAUDIO_SYSTEM_START=0
> >
> ># Prevent users from dynamically loading modules into the PulseAudio 
> > sound
> ># server. Dynamic module loading enhances the flexibility of the 
> > PulseAudio
> ># system, but may pose a security risk.
> ># 0 = no, 1 = yes
> >DISALLOW_MODULE_LOADING=1
> >
> > As far as I remember this explanation is correct and also upstream’s, i.
> > e. your, view/recommendation.
> 
> Indeed, that is why we (upstream) do not provide the init script: to
> underline our recommendation.
> 
> > If this is correct I guess the init script should be changed to not log
> > a warning or explain the warning in a better way.
> 
> I'm not sure whether it is possible to differentiate between manual
> and bootup invocation of the init script. But that would be the best
> solution, I think.

Hopefully, Sjoerd has an idea.


Thanks,

Paul


signature.asc
Description: This is a digitally signed message part


Bug#644888: [pulseaudio-discuss] Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2011-10-10 Thread Maarten Bosmans
Package: pulseaudio
Version: 1.0-4
Severity: normal
X-Debbugs-CC: pulseaudio-disc...@lists.freedesktop.org

2011/10/10 Maarten Bosmans :
> 2011/10/9 Paul Menzel :
>> Package: pulseaudio
>> Version: 1.0-4
>> Severity: normal
>> X-Debbugs-CC: pulseaudio-disc...@lists.freedesktop.org
>>
>>
>> Dear PulseAudio Debian packagers and upstream PA folks,
>>
>>
>> the Debian init script `/etc/init.d/pulseaudio` [1] currently prints a
>> warning when PA is configured in non-system mode.
>>
>>        PULSEAUDIO_SYSTEM_START=0
>>        DISALLOW_MODULE_LOADING=1
>>        test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
>>        if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
>>                log_warning_msg "PulseAudio configured for per-user sessions"
>>                exit 0
>>        fi
>>
>> In my opinion a warning suggests that something might be wrong and
>> therefore I am bringing this issues to your attention.
>
> First of all: I appreciate that Debian (and thus Ubuntu) provides the
> init script to make it easier to run pulse in system mode.
>
> The warning is correct when /etc/init.d/pulseaudio start is invoked
> manually. Because in that case the user expects pulse to be started
> and it isn't.
> For normal bootup procedure (on an unchanged system), the warning
> should not be shown, because then it is expected that pulse is run
> per-user.
>
>> In `/etc/default/pulseaudio` [2] there is the following explanation.
>>
>>        # Start the PulseAudio sound server in system mode.
>>        # (enables the pulseaudio init script - requires that users be in the
>>        # pulse-access group)
>>        # System mode is not the recommended way to run PulseAudio as it has 
>> some
>>        # limitations (such as no shared memory access) and could potentially 
>> allow
>>        # users to disconnect or redirect each others' audio streams. The
>>        # recommended way to run PulseAudio is as a per-session daemon. For 
>> GNOME/KDE/
>>        # Xfce sessions in Ubuntu Lucid/10.04, 
>> /etc/xdg/autostart/pulseaudio.desktop
>>        # handles this function of automatically starting PulseAudio on 
>> login, and for
>>        # it to work correctly your user must *not* have "autospawn = no" set 
>> in
>>        # ~/.pulse/client.conf (or in /etc/pulse/client.conf). By default, 
>> autospawn
>>        # is enabled. For other sessions, you can simply start PulseAudio with
>>        # "pulseaudio --daemonize".
>>        # 0 = don't start in system mode, 1 = start in system mode
>>        PULSEAUDIO_SYSTEM_START=0
>>
>>        # Prevent users from dynamically loading modules into the PulseAudio 
>> sound
>>        # server. Dynamic module loading enhances the flexibility of the 
>> PulseAudio
>>        # system, but may pose a security risk.
>>        # 0 = no, 1 = yes
>>        DISALLOW_MODULE_LOADING=1
>>
>> As far as I remember this explanation is correct and also upstream’s, i.
>> e. your, view/recommendation.
>
> Indeed, that is why we (upstream) do not provide the init script: to
> underline our recommendation.
>
>> If this is correct I guess the init script should be changed to not log
>> a warning or explain the warning in a better way.
>
> I'm not sure whether it is possible to differentiate between manual
> and bootup invocation of the init script. But that would be the best
> solution, I think.
>
>> Thanks,
>>
>> Paul
>
> Maarten
>



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

2011-10-09 Thread Paul Menzel
Package: pulseaudio
Version: 1.0-4
Severity: normal
X-Debbugs-CC: pulseaudio-disc...@lists.freedesktop.org


Dear PulseAudio Debian packagers and upstream PA folks,


the Debian init script `/etc/init.d/pulseaudio` [1] currently prints a
warning when PA is configured in non-system mode.

PULSEAUDIO_SYSTEM_START=0
DISALLOW_MODULE_LOADING=1
test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
log_warning_msg "PulseAudio configured for per-user sessions"
exit 0
fi

In my opinion a warning suggests that something might be wrong and
therefore I am bringing this issues to your attention.

In `/etc/default/pulseaudio` [2] there is the following explanation.

# Start the PulseAudio sound server in system mode.
# (enables the pulseaudio init script - requires that users be in the
# pulse-access group)
# System mode is not the recommended way to run PulseAudio as it has 
some
# limitations (such as no shared memory access) and could potentially 
allow
# users to disconnect or redirect each others' audio streams. The
# recommended way to run PulseAudio is as a per-session daemon. For 
GNOME/KDE/
# Xfce sessions in Ubuntu Lucid/10.04, 
/etc/xdg/autostart/pulseaudio.desktop
# handles this function of automatically starting PulseAudio on login, 
and for
# it to work correctly your user must *not* have "autospawn = no" set in
# ~/.pulse/client.conf (or in /etc/pulse/client.conf). By default, 
autospawn
# is enabled. For other sessions, you can simply start PulseAudio with
# "pulseaudio --daemonize".
# 0 = don't start in system mode, 1 = start in system mode
PULSEAUDIO_SYSTEM_START=0

# Prevent users from dynamically loading modules into the PulseAudio 
sound
# server. Dynamic module loading enhances the flexibility of the 
PulseAudio
# system, but may pose a security risk.
# 0 = no, 1 = yes
DISALLOW_MODULE_LOADING=1

As far as I remember this explanation is correct and also upstream’s, i.
e. your, view/recommendation.

If this is correct I guess the init script should be changed to not log
a warning or explain the warning in a better way.


Thanks,

Paul


[1] 
http://anonscm.debian.org/gitweb/?p=pkg-pulseaudio/pulseaudio.git;a=blob;f=debian/pulseaudio.init;h=6386510759186380abde0335d3738dd909c22ee7;hb=HEAD#l25
[2] 
http://anonscm.debian.org/gitweb/?p=pkg-pulseaudio/pulseaudio.git;a=blob;f=debian/pulseaudio.default;h=39261987e554db65b9244f1e3861cea10339d108;hb=HEAD


signature.asc
Description: This is a digitally signed message part