Bug#646881: pptp-linux: pptpsetup fails to properly store password with quotation mark (") in /etc/ppp/chap-secrets

2017-08-21 Thread James Cameron 
Thanks, taken upstream.

e62bfa7f11b0af355ff0367f8e1f22c42328639b

Bug#646881: pptp-linux: pptpsetup fails to properly store password with quotation mark (") in /etc/ppp/chap-secrets

2017-08-04 Thread Christoph Biedl 
tags 646881 confirmed upstream
thanks

Daniel Kahn Gillmor wrote...

> I was using a randomly-generated password that happened to have a
> quotation mark (") in it (let's pretend it was: sek"rit).  I entered it
> as requested by pptpsetup.
> 
> it stored it in /etc/ppp/chap-secrets like this:
> 
> dkg remoteendpoint "sek"rit" *

That should be pretty easy to fix by adding

$PASSWORD =~ s/([^\x20\x21\x23-\x7e])/sprintf ("\\x%02x", ord ($1))/eg;

before writing out. I took the opportunity to check how ppp deals with
characters in the secrets outside 7bit printable, including the \0 one.
Long story short, they *should* work but you can expect a bad time until
things work as expected. So they should best be avoided.

Christoph



signature.asc
Description: Digital signature

Bug#646881: pptp-linux: pptpsetup fails to properly store password with quotation mark () in /etc/ppp/chap-secrets

2011-10-27 Thread Daniel Kahn Gillmor 
Package: pptp-linux
Version: 1.7.2-6
Severity: normal

I was using a randomly-generated password that happened to have a
quotation mark () in it (let's pretend it was: sekrit).  I entered it
as requested by pptpsetup.

it stored it in /etc/ppp/chap-secrets like this:

dkg remoteendpoint sekrit *

and this failed to sync properly with the pptp server listening at
remoteendpoint:

.
rcvd [LCP EchoRep id=0x0 magic=0x5af09778]
rcvd [CHAP Failure id=0x1 E=691 R=0 M=Login incorrect]
MS-CHAP authentication failed: Login incorrect
CHAP authentication failed
sent [LCP TermReq id=0x2 Failed to authenticate ourselves to peer]
.

switching my password to one that does not use a  character (and
updating /etc/ppp/chap-secrets by hand) allowed me to successfully
authenticate.

--dkg

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (200, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.0.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pptp-linux depends on:
ii  binutils  2.21.90.20111004-2
ii  libc6 2.13-21   
ii  ppp   2.4.5-5   

pptp-linux recommends no packages.

pptp-linux suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#646881: pptp-linux: pptpsetup fails to properly store password with quotation mark () in /etc/ppp/chap-secrets

2011-10-27 Thread Ola Lundqvist 
Thanks again. Yes this do not work. I'll see if it can be corrected.

// Ola

On Fri, Oct 28, 2011 at 12:41:23AM -0400, Daniel Kahn Gillmor wrote:
 Package: pptp-linux
 Version: 1.7.2-6
 Severity: normal
 
 I was using a randomly-generated password that happened to have a
 quotation mark () in it (let's pretend it was: sekrit).  I entered it
 as requested by pptpsetup.
 
 it stored it in /etc/ppp/chap-secrets like this:
 
 dkg remoteendpoint sekrit *
 
 and this failed to sync properly with the pptp server listening at
 remoteendpoint:
 
 .
 rcvd [LCP EchoRep id=0x0 magic=0x5af09778]
 rcvd [CHAP Failure id=0x1 E=691 R=0 M=Login incorrect]
 MS-CHAP authentication failed: Login incorrect
 CHAP authentication failed
 sent [LCP TermReq id=0x2 Failed to authenticate ourselves to peer]
 .
 
 switching my password to one that does not use a  character (and
 updating /etc/ppp/chap-secrets by hand) allowed me to successfully
 authenticate.
 
 --dkg
 
 -- System Information:
 Debian Release: wheezy/sid
   APT prefers testing
   APT policy: (500, 'testing'), (200, 'unstable'), (1, 'experimental')
 Architecture: i386 (i686)
 
 Kernel: Linux 3.0.0-1-686-pae (SMP w/1 CPU core)
 Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/dash
 
 Versions of packages pptp-linux depends on:
 ii  binutils  2.21.90.20111004-2
 ii  libc6 2.13-21   
 ii  ppp   2.4.5-5   
 
 pptp-linux recommends no packages.
 
 pptp-linux suggests no packages.
 
 -- no debconf information
 
 
 

-- 
 - Ola Lundqvist ---
/  o...@debian.org Annebergsslingan 37  \
|  o...@inguza.com  654 65 KARLSTAD  |
|  http://inguza.com/  +46 (0)70-332 1551   |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org