Bug#648177: piuparts.py: code synchronization, de-duplication, ...
Package: piuparts
Version: 0.41
Followup-For: Bug #648177
Hi,
here are some additional cleanup patches that should not introduce
functional difference. As always, git branches are in
git://github.com/anbe42/piuparts.git
cleanup/compute-changes
compute the changes in restore_selections()
Avoid code duplication, pass the selections to restore_selections()
and compute the changes there.
cleanup/apt-get-update-clean
consolidate apt-get {update,clean}
Stop scattering apt-get clean/update all over the place.
Run apt-get update only after updating the sources.list.
Run apt-get clean only from pack_into_tgz() before creating a
tarball and from save_meta_data() before recording chroot state
for later comparison.
Andreas
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#648177: piuparts.py: code synchronization, de-duplication, ...
Package: piuparts Version: 0.41 Severity: normal Tags: patch This bug tracks several patches made available in git branches of git://github.com/anbe42/piuparts.git These patches target code cleanup without introducing functional differences. cleanup/consistent-variable-names use consistent variable names for package lists use consistent naming of the variables of package lists: * packages - a list of package names * package_files - a list of .debs * package_list - if undecided cleanup/use-chroot-relative use chroot.relative() more often to build filenames use self.relative(...) to build a path name instead of manually doing it via os.path.join(self.name, ...) cleanup/scriptsdir-check check for settings.scriptsdir inside run_scripts() move the check for settings.scriptsdir inside run_scripts(), no need to replicate it before every call Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
