Bug#648299: uscan; whitespace in filename
On Thu, Nov 10, 2011 at 11:48:58AM +0100, Ansgar Burchardt wrote: Package: devscripts Version: 2.10.69 Mathieu Malaterre mathieu.malate...@gmail.com writes: Has anyone work with upstream tarball with a space in the filename ? I could get uscan to work (--verbose), however --repack fails miserably on the following file: http://anonscm.debian.org/viewvc/collab-maint/deb-maint/openmcdf/debian/watch?view=markup with: unzip: cannot find or open ../OpenMCDF, ../OpenMCDF.zip or ../OpenMCDF.ZIP. tar: 1.5.2.tar.gz: Cannot stat: No such file or directory tar: Exiting with failure status due to previous errors Repacking from zip to tar.gz failed make: *** [get-orig-source] Error 2 This seems to be a bug in uscan: Indeed, thanks. it uses system(unzip -q -d $tempdir $destdir/$newfile_base; GZIP=-9 tar -C $tempdir -czf $destdir/$newfile_base_gz .) == 0 to call unzip. It would probably be useful to have OpenMCDF's watch file use filenamemangle so the downloaded file uses an appropriate name for an orig.tar.gz, for example version=3 opts=filenamemangle=s/OpenMCDF\s/openmcdf-/ \ http://sf.net/openmcdf/OpenMCDF\s([\d\.]+)\.zip -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy james...@debian.org signature.asc Description: Digital signature
Bug#648299: uscan; whitespace in filename
Package: devscripts Version: 2.10.69 Mathieu Malaterre mathieu.malate...@gmail.com writes: Has anyone work with upstream tarball with a space in the filename ? I could get uscan to work (--verbose), however --repack fails miserably on the following file: http://anonscm.debian.org/viewvc/collab-maint/deb-maint/openmcdf/debian/watch?view=markup with: unzip: cannot find or open ../OpenMCDF, ../OpenMCDF.zip or ../OpenMCDF.ZIP. tar: 1.5.2.tar.gz: Cannot stat: No such file or directory tar: Exiting with failure status due to previous errors Repacking from zip to tar.gz failed make: *** [get-orig-source] Error 2 This seems to be a bug in uscan: it uses system(unzip -q -d $tempdir $destdir/$newfile_base; GZIP=-9 tar -C $tempdir -czf $destdir/$newfile_base_gz .) == 0 to call unzip. As this involves a shell, it breaks if any of the variables contains whitespace (or other problematic characters). It should probably use a list instead of a scalar to avoid the shell. Ansgar -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#648299: uscan; whitespace in filename
On 11/10/2011 11:48 AM, Ansgar Burchardt wrote: Package: devscripts Version: 2.10.69 Mathieu Malaterre mathieu.malate...@gmail.com writes: Has anyone work with upstream tarball with a space in the filename ? I could get uscan to work (--verbose), however --repack fails miserably on the following file: http://anonscm.debian.org/viewvc/collab-maint/deb-maint/openmcdf/debian/watch?view=markup with: unzip: cannot find or open ../OpenMCDF, ../OpenMCDF.zip or ../OpenMCDF.ZIP. tar: 1.5.2.tar.gz: Cannot stat: No such file or directory tar: Exiting with failure status due to previous errors Repacking from zip to tar.gz failed make: *** [get-orig-source] Error 2 This seems to be a bug in uscan: it uses system(unzip -q -d $tempdir $destdir/$newfile_base; GZIP=-9 tar -C $tempdir -czf $destdir/$newfile_base_gz .) == 0 to call unzip. As this involves a shell, it breaks if any of the variables contains whitespace (or other problematic characters). It should probably use a list instead of a scalar to avoid the shell. That, or add some \ to the line above. Good you spotted that. Steffen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
