Bug#651313: desktopnova-module-gnome: desktopnova seems to be not compatible with Gnome 3
forgot to update control file
and some dconf syntax changed a lot, I had to patch the patch...
I hope I didn't mess up things, in case please send me an email and I'll fix it
up
G.
diff -Nru desktopnova-0.8.1/debian/changelog desktopnova-0.8.1/debian/changelog
--- desktopnova-0.8.1/debian/changelog 2018-05-16 08:49:31.0 +0200
+++ desktopnova-0.8.1/debian/changelog 2019-09-23 15:51:39.0 +0200
@@ -1,3 +1,12 @@
+desktopnova (0.8.1-1.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Add proposed patch to make it work with gnome-shell (LP: #780079, Closes:
+#651313)
+ * Add libdconf-dev dependency, needed to find libs
+
+ -- Gianfranco Costamagna Mon, 23 Sep 2019
15:51:39 +0200
+
desktopnova (0.8.1-1.1) unstable; urgency=low
* Non-maintainer upload.
diff -Nru desktopnova-0.8.1/debian/control desktopnova-0.8.1/debian/control
--- desktopnova-0.8.1/debian/control2018-05-16 08:49:31.0 +0200
+++ desktopnova-0.8.1/debian/control2019-09-23 15:51:39.0 +0200
@@ -2,7 +2,7 @@
Section: misc
Priority: optional
Maintainer: Stefan Haller
-Build-Depends: debhelper (>= 9), cmake, libglib2.0-dev, libgconf2-dev,
libgtk2.0-dev, intltool, libxml2-dev, libdbus-glib-1-dev, libxfconf-0-dev,
python-minimal
+Build-Depends: debhelper (>= 9), cmake, libglib2.0-dev, libgconf2-dev,
libdconf-dev, libgtk2.0-dev, intltool, libxml2-dev, libdbus-glib-1-dev,
libxfconf-0-dev, python-minimal
Standards-Version: 3.9.2
Homepage: http://launchpad.net/desktopnova
diff -Nru desktopnova-0.8.1/debian/patches/gnome-shell.patch
desktopnova-0.8.1/debian/patches/gnome-shell.patch
--- desktopnova-0.8.1/debian/patches/gnome-shell.patch 1970-01-01
01:00:00.0 +0100
+++ desktopnova-0.8.1/debian/patches/gnome-shell.patch 2019-09-23
15:51:39.0 +0200
@@ -0,0 +1,156 @@
+Description: Adding Gnome-Shell support
+ A patch that adds a module for gnome-shell to change the background.
+ This patch uses the dconf library to change the wallpaper.
+ .
+Author: Eric Gach
+Reported by: Andrea Capriotti
+Bug-Debian: http://bugs.debian.org/651313
+
+--- a/CMakeLists.txt 2011-03-20 14:05:02 +
b/CMakeLists.txt 2011-05-09 18:39:01 +
+@@ -11,6 +11,7 @@
+
+ SET(GETTEXT_PACKAGE "desktopnova")
+ SET(GETTEXT_PACKAGE_MODULE_GNOME "desktopnova-module-gnome")
++SET(GETTEXT_PACKAGE_MODULE_GNOME_SHELL "desktopnova-module-gnome-shell")
+ SET(GETTEXT_PACKAGE_MODULE_XFCE "desktopnova-module-xfce")
+ SET(GETTEXT_PACKAGE_TRAY "desktopnova-tray")
+
+@@ -20,6 +21,7 @@
+ SET(DIRS_PKGLIBDIR "lib/desktopnova" CACHE STRING "Directory for modules")
+
+ SET(VERSION_MODULE_GNOME "0.2")
++SET(VERSION_MODULE_GNOME_SHELL "0.1")
+ SET(VERSION_MODULE_XFCE "0.1")
+ SET(VERSION_MODULE_XFCE_XFCONF "0.2")
+
+@@ -37,6 +39,7 @@
+ SET(ENABLE_DBUS 1 CACHE BOOL "Define whether dbus should be supported (dbus
is required in order to use desktopnova-tray).")
+ SET(ENABLE_TRAY 1 CACHE BOOL "Define whether desktopnova-tray should be
compiled (requires dbus-support).")
+ SET(ENABLE_MODULE_GNOME 1 CACHE BOOL "Define whether the gnome module should
be compiled.")
++SET(ENABLE_MODULE_GNOME_SHELL 1 CACHE BOOL "Define whether the gnome-shell
module should be compiled.")
+ SET(ENABLE_MODULE_XFCE 1 CACHE BOOL "Define whether the old xfce module
(supports XFCE < 4.6) should be compiled.")
+ SET(ENABLE_MODULE_XFCE_XFCONF 1 CACHE BOOL "Define whether the new xfce
module (supports XFCE >= 4.6) should be compiled.")
+
+@@ -83,6 +86,9 @@
+ IF(ENABLE_DBUS)
+ PKG_CHECK_MODULES(DBUS REQUIRED dbus-glib-1)
+ ENDIF(ENABLE_DBUS)
++IF(ENABLE_MODULE_GNOME_SHELL)
++ PKG_CHECK_MODULES(DCONF REQUIRED dconf)
++ENDIF(ENABLE_MODULE_GNOME_SHELL)
+
+ SET(TEMP_PRINT_DEBUG 0)
+ IF(NOT RELEASE_BUILD)
+
+=== modified file 'config.h.cmake'
+--- a/config.h.cmake 2009-10-15 17:16:08 +
b/config.h.cmake 2011-05-09 18:41:10 +
+@@ -10,11 +10,13 @@
+
+ #define VERSION "${VERSION}"
+ #define VERSION_MODULE_GNOME "${VERSION_MODULE_GNOME}"
++#define VERSION_MODULE_GNOME_SHELL "${VERSION_MODULE_GNOME_SHELL}"
+ #define VERSION_MODULE_XFCE "${VERSION_MODULE_XFCE}"
+ #define VERSION_MODULE_XFCE_XFCONF "${VERSION_MODULE_XFCE_XFCONF}"
+
+ #define GETTEXT_PACKAGE "${GETTEXT_PACKAGE}"
+ #define GETTEXT_PACKAGE_MODULE_GNOME "${GETTEXT_PACKAGE_MODULE_GNOME}"
++#define GETTEXT_PACKAGE_MODULE_GNOME_SHELL
"${GETTEXT_PACKAGE_MODULE_GNOME_SHELL}"
+ #define GETTEXT_PACKAGE_MODULE_XFCE "${GETTEXT_PACKAGE_MODULE_XFCE}"
+ #define GETTEXT_PACKAGE_TRAY "${GETTEXT_PACKAGE_TRAY}"
+
+
+=== modified file 'src/modules/CMakeLists.txt'
+--- a/src/modules/CMakeLists.txt 2010-03-14 14:18:42 +
b/src/modules/CMakeLists.txt 2011-05-09 18:40:10 +
+@@ -11,6 +11,15 @@
+ SET(TARGETS ${TARGETS} desktopnova-module-gnome)
+ ENDIF(ENABLE_MODULE_GNOME)
+
++IF(ENABLE_MODULE_GNOME_SHELL)
++ ADD_LIBRARY(desktopnova-module-gnome-shell MODULE module_gnome_shell.c)
++
Bug#651313: desktopnova-module-gnome: desktopnova seems to be not compatible with Gnome 3
control: tags -1 patch pending
Lets do it
G.
On Tue, 08 Jan 2013 16:46:24 +0100 Andrea Capriotti wrote:
> Hi,
>
> there's a patch (attached) for that and it works:
>
> https://bugs.launchpad.net/desktopnova/+bug/780079
>
> I did a backport for Debian unstable version of desktopnova (0.8.1):
>
> http://people.debian.org/~capriott/debian/unstable/
>
> Bye
> --
> Andrea Capriotti
diff -Nru desktopnova-0.8.1/debian/changelog desktopnova-0.8.1/debian/changelog
--- desktopnova-0.8.1/debian/changelog 2018-05-16 08:49:31.0 +0200
+++ desktopnova-0.8.1/debian/changelog 2019-09-23 15:51:39.0 +0200
@@ -1,3 +1,11 @@
+desktopnova (0.8.1-1.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Add proposed patch to make it work with gnome-shell (LP: #780079, Closes:
+#651313)
+
+ -- Gianfranco Costamagna Mon, 23 Sep 2019
15:51:39 +0200
+
desktopnova (0.8.1-1.1) unstable; urgency=low
* Non-maintainer upload.
diff -Nru desktopnova-0.8.1/debian/patches/gnome-shell.patch
desktopnova-0.8.1/debian/patches/gnome-shell.patch
--- desktopnova-0.8.1/debian/patches/gnome-shell.patch 1970-01-01
01:00:00.0 +0100
+++ desktopnova-0.8.1/debian/patches/gnome-shell.patch 2019-09-23
15:51:37.0 +0200
@@ -0,0 +1,156 @@
+Description: Adding Gnome-Shell support
+ A patch that adds a module for gnome-shell to change the background.
+ This patch uses the dconf library to change the wallpaper.
+ .
+Author: Eric Gach
+Reported by: Andrea Capriotti
+Bug-Debian: http://bugs.debian.org/651313
+
+--- a/CMakeLists.txt 2011-03-20 14:05:02 +
b/CMakeLists.txt 2011-05-09 18:39:01 +
+@@ -11,6 +11,7 @@
+
+ SET(GETTEXT_PACKAGE "desktopnova")
+ SET(GETTEXT_PACKAGE_MODULE_GNOME "desktopnova-module-gnome")
++SET(GETTEXT_PACKAGE_MODULE_GNOME_SHELL "desktopnova-module-gnome-shell")
+ SET(GETTEXT_PACKAGE_MODULE_XFCE "desktopnova-module-xfce")
+ SET(GETTEXT_PACKAGE_TRAY "desktopnova-tray")
+
+@@ -20,6 +21,7 @@
+ SET(DIRS_PKGLIBDIR "lib/desktopnova" CACHE STRING "Directory for modules")
+
+ SET(VERSION_MODULE_GNOME "0.2")
++SET(VERSION_MODULE_GNOME_SHELL "0.1")
+ SET(VERSION_MODULE_XFCE "0.1")
+ SET(VERSION_MODULE_XFCE_XFCONF "0.2")
+
+@@ -37,6 +39,7 @@
+ SET(ENABLE_DBUS 1 CACHE BOOL "Define whether dbus should be supported (dbus
is required in order to use desktopnova-tray).")
+ SET(ENABLE_TRAY 1 CACHE BOOL "Define whether desktopnova-tray should be
compiled (requires dbus-support).")
+ SET(ENABLE_MODULE_GNOME 1 CACHE BOOL "Define whether the gnome module should
be compiled.")
++SET(ENABLE_MODULE_GNOME_SHELL 1 CACHE BOOL "Define whether the gnome-shell
module should be compiled.")
+ SET(ENABLE_MODULE_XFCE 1 CACHE BOOL "Define whether the old xfce module
(supports XFCE < 4.6) should be compiled.")
+ SET(ENABLE_MODULE_XFCE_XFCONF 1 CACHE BOOL "Define whether the new xfce
module (supports XFCE >= 4.6) should be compiled.")
+
+@@ -83,6 +86,9 @@
+ IF(ENABLE_DBUS)
+ PKG_CHECK_MODULES(DBUS REQUIRED dbus-glib-1)
+ ENDIF(ENABLE_DBUS)
++IF(ENABLE_MODULE_GNOME_SHELL)
++ PKG_CHECK_MODULES(DCONF REQUIRED dconf)
++ENDIF(ENABLE_MODULE_GNOME_SHELL)
+
+ SET(TEMP_PRINT_DEBUG 0)
+ IF(NOT RELEASE_BUILD)
+
+=== modified file 'config.h.cmake'
+--- a/config.h.cmake 2009-10-15 17:16:08 +
b/config.h.cmake 2011-05-09 18:41:10 +
+@@ -10,11 +10,13 @@
+
+ #define VERSION "${VERSION}"
+ #define VERSION_MODULE_GNOME "${VERSION_MODULE_GNOME}"
++#define VERSION_MODULE_GNOME_SHELL "${VERSION_MODULE_GNOME_SHELL}"
+ #define VERSION_MODULE_XFCE "${VERSION_MODULE_XFCE}"
+ #define VERSION_MODULE_XFCE_XFCONF "${VERSION_MODULE_XFCE_XFCONF}"
+
+ #define GETTEXT_PACKAGE "${GETTEXT_PACKAGE}"
+ #define GETTEXT_PACKAGE_MODULE_GNOME "${GETTEXT_PACKAGE_MODULE_GNOME}"
++#define GETTEXT_PACKAGE_MODULE_GNOME_SHELL
"${GETTEXT_PACKAGE_MODULE_GNOME_SHELL}"
+ #define GETTEXT_PACKAGE_MODULE_XFCE "${GETTEXT_PACKAGE_MODULE_XFCE}"
+ #define GETTEXT_PACKAGE_TRAY "${GETTEXT_PACKAGE_TRAY}"
+
+
+=== modified file 'src/modules/CMakeLists.txt'
+--- a/src/modules/CMakeLists.txt 2010-03-14 14:18:42 +
b/src/modules/CMakeLists.txt 2011-05-09 18:40:10 +
+@@ -11,6 +11,15 @@
+ SET(TARGETS ${TARGETS} desktopnova-module-gnome)
+ ENDIF(ENABLE_MODULE_GNOME)
+
++IF(ENABLE_MODULE_GNOME_SHELL)
++ ADD_LIBRARY(desktopnova-module-gnome-shell MODULE module_gnome_shell.c)
++ SET_TARGET_PROPERTIES(desktopnova-module-gnome-shell
++PROPERTIES PREFIX ""
++ OUTPUT_NAME module_gnome_shell)
++ TARGET_LINK_LIBRARIES(desktopnova-module-gnome-shell ${DCONF_LIBRARIES})
++ SET(TARGETS ${TARGETS} desktopnova-module-gnome-shell)
++ENDIF(ENABLE_MODULE_GNOME_SHELL)
++
+ IF(ENABLE_MODULE_XFCE)
+ ADD_LIBRARY(desktopnova-module-xfce MODULE module_xfce.c)
+ SET_TARGET_PROPERTIES(desktopnova-module-xfce
+
+=== added file 'src/modules/module_gnome_shell.c'
+--- a/src/modules/module_gnome_shell.c 1970-01-01 00:00:00
Bug#651313: desktopnova-module-gnome: desktopnova seems to be not compatible with Gnome 3
Hi,
there's a patch (attached) for that and it works:
https://bugs.launchpad.net/desktopnova/+bug/780079
I did a backport for Debian unstable version of desktopnova (0.8.1):
http://people.debian.org/~capriott/debian/unstable/
Bye
--
Andrea Capriotti capri...@debian.org
Description: Adding Gnome-Shell support
A patch that adds a module for gnome-shell to change the background.
This patch uses the dconf library to change the wallpaper.
.
desktopnova (0.8.1-1capriott1) UNRELEASED; urgency=low
.
* Adding Gnome-Shell support (Closes: #651313).
Author: Andrea Capriotti capri...@debian.org
Bug-Debian: http://bugs.debian.org/651313
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: other, https://bugs.launchpad.net/desktopnova/+bug/780079
Bug: https://bugs.launchpad.net/desktopnova/+bug/780079
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=651313
Bug-Ubuntu: https://bugs.launchpad.net/desktopnova/+bug/780079
Forwarded: not-needed
Reviewed-By: name and email of someone who approved the patch
Last-Update: 2012-01-08
--- desktopnova-0.8.1.orig/CMakeLists.txt
+++ desktopnova-0.8.1/CMakeLists.txt
@@ -11,6 +11,7 @@ SET(CMAKE_MODULE_PATH ${PROJECT_SOURCE_D
SET(GETTEXT_PACKAGE desktopnova)
SET(GETTEXT_PACKAGE_MODULE_GNOME desktopnova-module-gnome)
+SET(GETTEXT_PACKAGE_MODULE_GNOME_SHELL desktopnova-module-gnome-shell)
SET(GETTEXT_PACKAGE_MODULE_XFCE desktopnova-module-xfce)
SET(GETTEXT_PACKAGE_TRAY desktopnova-tray)
@@ -20,6 +21,7 @@ SET(DIRS_LOCALEDIR share/locale CACHE
SET(DIRS_PKGLIBDIR lib/desktopnova CACHE STRING Directory for modules)
SET(VERSION_MODULE_GNOME 0.2)
+SET(VERSION_MODULE_GNOME_SHELL 0.1)
SET(VERSION_MODULE_XFCE 0.1)
SET(VERSION_MODULE_XFCE_XFCONF 0.2)
@@ -37,6 +39,7 @@ SET(ENABLE_MAIN 1 CACHE BOOL Define whe
SET(ENABLE_DBUS 1 CACHE BOOL Define whether dbus should be supported (dbus is
required in order to use desktopnova-tray).)
SET(ENABLE_TRAY 1 CACHE BOOL Define whether desktopnova-tray should be
compiled (requires dbus-support).)
SET(ENABLE_MODULE_GNOME 1 CACHE BOOL Define whether the gnome module should
be compiled.)
+SET(ENABLE_MODULE_GNOME_SHELL 1 CACHE BOOL Define whether the gnome-shell
module should be compiled.)
SET(ENABLE_MODULE_XFCE 1 CACHE BOOL Define whether the old xfce module
(supports XFCE 4.6) should be compiled.)
SET(ENABLE_MODULE_XFCE_XFCONF 1 CACHE BOOL Define whether the new xfce module
(supports XFCE = 4.6) should be compiled.)
@@ -83,6 +86,9 @@ ENDIF(ENABLE_MODULE_XFCE_XFCONF)
IF(ENABLE_DBUS)
PKG_CHECK_MODULES(DBUS REQUIRED dbus-glib-1)
ENDIF(ENABLE_DBUS)
+IF(ENABLE_MODULE_GNOME_SHELL)
+ PKG_CHECK_MODULES(DCONF REQUIRED dconf)
+ENDIF(ENABLE_MODULE_GNOME_SHELL)
SET(TEMP_PRINT_DEBUG 0)
IF(NOT RELEASE_BUILD)
--- desktopnova-0.8.1.orig/config.h.cmake
+++ desktopnova-0.8.1/config.h.cmake
@@ -10,11 +10,13 @@
#define VERSION ${VERSION}
#define VERSION_MODULE_GNOME ${VERSION_MODULE_GNOME}
+#define VERSION_MODULE_GNOME_SHELL ${VERSION_MODULE_GNOME_SHELL}
#define VERSION_MODULE_XFCE ${VERSION_MODULE_XFCE}
#define VERSION_MODULE_XFCE_XFCONF ${VERSION_MODULE_XFCE_XFCONF}
#define GETTEXT_PACKAGE ${GETTEXT_PACKAGE}
#define GETTEXT_PACKAGE_MODULE_GNOME ${GETTEXT_PACKAGE_MODULE_GNOME}
+#define GETTEXT_PACKAGE_MODULE_GNOME_SHELL
${GETTEXT_PACKAGE_MODULE_GNOME_SHELL}
#define GETTEXT_PACKAGE_MODULE_XFCE ${GETTEXT_PACKAGE_MODULE_XFCE}
#define GETTEXT_PACKAGE_TRAY ${GETTEXT_PACKAGE_TRAY}
--- /dev/null
+++ desktopnova-0.8.1/gnome-shell.patch
@@ -0,0 +1,149 @@
+=== modified file 'CMakeLists.txt'
+--- CMakeLists.txt 2011-03-20 14:05:02 +
CMakeLists.txt 2011-05-09 18:39:01 +
+@@ -11,6 +11,7 @@
+
+ SET(GETTEXT_PACKAGE desktopnova)
+ SET(GETTEXT_PACKAGE_MODULE_GNOME desktopnova-module-gnome)
++SET(GETTEXT_PACKAGE_MODULE_GNOME_SHELL desktopnova-module-gnome-shell)
+ SET(GETTEXT_PACKAGE_MODULE_XFCE desktopnova-module-xfce)
+ SET(GETTEXT_PACKAGE_TRAY desktopnova-tray)
+
+@@ -20,6 +21,7 @@
+ SET(DIRS_PKGLIBDIR lib/desktopnova CACHE STRING Directory for modules)
+
+ SET(VERSION_MODULE_GNOME 0.2)
++SET(VERSION_MODULE_GNOME_SHELL 0.1)
+ SET(VERSION_MODULE_XFCE 0.1)
+ SET(VERSION_MODULE_XFCE_XFCONF 0.2)
+
+@@ -37,6 +39,7 @@
+ SET(ENABLE_DBUS 1 CACHE BOOL Define whether dbus should be supported (dbus
is required in order to use desktopnova-tray).)
+ SET(ENABLE_TRAY 1 CACHE BOOL Define whether desktopnova-tray should be
compiled (requires dbus-support).)
+ SET(ENABLE_MODULE_GNOME 1 CACHE BOOL Define whether the gnome module should
be compiled.)
++SET(ENABLE_MODULE_GNOME_SHELL 1 CACHE BOOL Define whether the gnome-shell
module should be compiled.)
+ SET(ENABLE_MODULE_XFCE 1 CACHE BOOL Define whether the old xfce module
(supports XFCE 4.6) should be compiled.)
+ SET(ENABLE_MODULE_XFCE_XFCONF 1 CACHE BOOL Define whether the new
Bug#651313: desktopnova-module-gnome: desktopnova seems to be not compatible with Gnome 3
Package: desktopnova-module-gnome Version: 0.8.1-1 Severity: important Dear Maintainer, Desktopnova seems to be not compatible with Gnome 3: standard backgrounds of Gnome 3 are used and backgrounds of desktopnova not. Thank you. Pierre Crescenzo -- System Information: Debian Release: wheezy/sid APT prefers testing-proposed-updates APT policy: (500, 'testing-proposed-updates'), (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'testing'), (500, 'stable') Architecture: i386 (i686) Kernel: Linux 3.1.0-1-686-pae (SMP w/2 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages desktopnova-module-gnome depends on: ii desktopnova 0.8.1-1 ii libc6 2.13-21 ii libgconf2-4 2.32.4-1 ii libglib2.0-0 2.30.2-4 desktopnova-module-gnome recommends no packages. desktopnova-module-gnome suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
