Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-02-05 Thread Vincent Bernat 
OoO  Pendant le repas  du dimanche  05 février  2012, vers  19:50, Marc
Dequènes (Duck) d...@duckcorp.org disait :

 The output of ls -l is misleading for this file:
 lrwxrwxrwx 1 root root 49 janv. 22 12:37
 /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js -
 ../../../../javascript/jquery-ui/jquery-ui.min.js

 Why misleading?

Becauseitwouldappear thatittriestoaccess
/var/lib/javascript/jquery-ui/jquery-ui.min.js  (which  does not  exist)
while in fact there is an intermediate symlink:
 lrwxrwxrwx 1 root root 37 déc.  26 21:50 /var/lib/roundcube/plugins/jqueryui 
- /usr/share/roundcube/plugins/jqueryui

Therefore, the above symlink works.

 I have:
 Alias /roundcube /var/lib/roundcube

 I'm using a dedicated vhost, but was using /usr/share/roundcube.

 It seems i missed the change in the changelog in 0.5.1-1 « Rework how
 symlinks work. ». Nevertheless, after changing the directory, it does
 not work better.

The  correct  directory  has   always  been  /var/lib/roundcube  but  we
previously arranged  so that /usr/share/roundcube would work  too but it
was getting quite complicated. I  am unsure when we removed the symlinks
From /usr/share/roundcube  to /var/lib/roundcube.  I would say  this was
for 0.3.

 I had another look at the problem. When building your package i get
 (using debc):
 lrwxrwxrwx root/root 0 2012-02-05 19:06
 ./var/lib/roundcube/plugins/jqueryui -
 /usr/share/roundcube/plugins/jqueryui
 In my system, it is not a symlink, but a directory. I may have done a
 mistake earlier, so i moved /var/lib/roundcube/plugins/jqueryui away,
 before upgrading to 0.7.1-1. This file is then recreated as a
 directory!

 Looking a bit further, i can see /usr/share/roundcube/plugins should
 be a directory, but in my system is a symlink to
 /var/lib/roundcube/plugins.

 It really seems the migration to the new symlink layout did not work
 correctly on my system :-(.

That's quite surprising because it is the job of dpkg to work with those
symlinks. I will  try to find which version had symlinks  in the old way
and test an upgrade.
-- 
Vincent Bernat ☯ http://vincent.bernat.im

Test input for validity and plausibility.
- The Elements of Programming Style (Kernighan  Plauger)


pgpyrQcJ8JuWw.pgp
Description: PGP signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-02-05 Thread Marc Dequènes (Duck) 

Coin,

Quoting Vincent Bernat ber...@debian.org:


I don't  really understand why the  fact that the symlink  is a relative
one is a problem. From what I understand, you want to try to access to:
 /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js


Apache tries to yes:
[Sun Feb 05 18:59:15 2012] [error] [client  
2001:7a8:810:6969:21f:d0ff:fe8f:cfec] Symbolic link not allowed or  
link target not accessible: /var/lib/roundcube/plugins/jqueryui/css,  
referer: https://webmail-rc.duckcorp.org/?_task=settings
[Sun Feb 05 18:59:15 2012] [error] [client  
2001:7a8:810:6969:21f:d0ff:fe8f:cfec] Symbolic link not allowed or  
link target not accessible:  
/var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js, referer:  
https://webmail-rc.duckcorp.org/?_task=settings


And as you can see, the css symlink is not working either.


The output of ls -l is misleading for this file:
 lrwxrwxrwx 1 root root 49 janv. 22 12:37  
/var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js -  
../../../../javascript/jquery-ui/jquery-ui.min.js


Why misleading?


From the above, we may assume that the linked file is:
 /var/lib/javascript/jquery-ui/jquery-ui.min.js
Is that what you mean?


Yes.


However, readlink -f output confirms that everything works as expected:
 $ readlink -f /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js
 /usr/share/javascript/jquery-ui/jquery-ui.min.js


But it does not here.


Do you get a 404 when accessing this file? With Apache, if I try this, I
get the file:
 $ curl http://localhost/roundcube/plugins/jqueryui/js/jquery-ui.min.js


I get a 403, see log entries above.


I have:
 Alias /roundcube /var/lib/roundcube


I'm using a dedicated vhost, but was using /usr/share/roundcube.

It seems i missed the change in the changelog in 0.5.1-1 « Rework how  
symlinks work. ». Nevertheless, after changing the directory, it does  
not work better.



I had another look at the problem. When building your package i get  
(using debc):
lrwxrwxrwx root/root 0 2012-02-05 19:06  
./var/lib/roundcube/plugins/jqueryui -  
/usr/share/roundcube/plugins/jqueryui
In my system, it is not a symlink, but a directory. I may have done a  
mistake earlier, so i moved /var/lib/roundcube/plugins/jqueryui away,  
before upgrading to 0.7.1-1. This file is then recreated… as a  
directory!


Looking a bit further, i can see /usr/share/roundcube/plugins should  
be a directory, but in my system is a symlink to  
/var/lib/roundcube/plugins.


It really seems the migration to the new symlink layout did not work  
correctly on my system :-(.


--
Marc Dequènes (Duck)


pgpqF1L84LUu6.pgp
Description: PGP Digital Signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-02-04 Thread Vincent Bernat 
OoO Lors de la soirée naissante du dimanche 22 janvier 2012, vers 18:02,
Marc Dequènes (Duck) d...@duckcorp.org disait :

 Thanks for adding the jquery plugin in the core. Nevertheless there is
 small problem with the symlinks. As /usr/share/roundcube/plugins is in
 fact /var/lib/roundcube/plugins, and the generated symlinks are
 relative, it fails to load:
 # ll /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
 lrwxrwxrwx 1 root root 49 Jan  2 21:49
 /usr/share/roundcube/plugins/jqueryui_pkg/js/jquery-ui.min.js -
 ../../../../javascript/jquery-ui/jquery-ui.min.js

 This problem also arise for the contextmenu plugin, and maybe others.

 According to debian/roundcube-core.links you used absolute path to the
 /usr/share/javascript directory, but unfortunately dh_link generate
 relative paths (duuno why). I just rebuilt your package to unsure any
 local modification from before the jqueryui plugin was shipped is not
 in the way, but debc just confirm this issue.

Sorry for the delayed answer. I do not have this problem on my PC:

$ ls -l /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
lrwxrwxrwx 1 root root 49 janv. 22 12:37 
/usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js - 
../../../../javascript/jquery-ui/jquery-ui.min.js
$ ls -lH /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
-rw-r--r-- 1 root root 219321 janv. 24 21:19 
/usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
$ ls -l /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js
lrwxrwxrwx 1 root root 49 janv. 22 12:37 
/var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js - 
../../../../javascript/jquery-ui/jquery-ui.min.js
$ ls -lH /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js
-rw-r--r-- 1 root root 219321 janv. 24 21:19 
/var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js

I don't  understand where  jqueryui_pkg comes from  in your  output. You
type plugins/jqueryui and  you get plugins/jqueryui_pkg. Moreover, I
have no such  directory on my system.  Maybe you have  an old version of
roundcube-plugins-extra?
-- 
Vincent Bernat ☯ http://vincent.bernat.im

 /* Identify the flock of penguins.  */
2.2.16 /usr/src/linux/arch/alpha/kernel/setup.c


pgpL6mvDf5pre.pgp
Description: PGP signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-02-04 Thread Marc Dequènes (Duck) 

Coin,

Quoting Vincent Bernat ber...@debian.org:


I don't  understand where  jqueryui_pkg comes from  in your  output. You
type plugins/jqueryui and  you get plugins/jqueryui_pkg. Moreover, I
have no such  directory on my system.  Maybe you have  an old version of
roundcube-plugins-extra?


Because of this symlink problem, i had to find a fix quickly, to avoid  
my users killing me, so i moved the jqueryui directory from the  
package away, copied it, and fixed the symlinks in the copy. But when  
you asked for details, i had to use these original path, and did not  
remove the _pkg suffix everywhere by mistake, sorry.


Regards.

--
Marc Dequènes (Duck)


pgp8WE1clbqYP.pgp
Description: PGP Digital Signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-02-04 Thread Vincent Bernat 
OoO En  cette matinée pluvieuse du  samedi 04 février  2012, vers 10:30,
Marc Dequènes (Duck) d...@duckcorp.org disait :

 I don't  understand where  jqueryui_pkg comes from  in your  output. You
 type plugins/jqueryui and  you get plugins/jqueryui_pkg. Moreover, I
 have no such  directory on my system.  Maybe you have  an old version of
 roundcube-plugins-extra?

 Because of this symlink problem, i had to find a fix quickly, to avoid
 my users killing me, so i moved the jqueryui directory from the
 package away, copied it, and fixed the symlinks in the copy. But when
 you asked for details, i had to use these original path, and did not
 remove the _pkg suffix everywhere by mistake, sorry.

OK. I am still in the blue about the problem.

I don't  really understand why the  fact that the symlink  is a relative
one is a problem. From what I understand, you want to try to access to:
 /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js

The output of ls -l is misleading for this file:
 lrwxrwxrwx 1 root root 49 janv. 22 12:37 
/var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js - 
../../../../javascript/jquery-ui/jquery-ui.min.js

From the above, we may assume that the linked file is:
 /var/lib/javascript/jquery-ui/jquery-ui.min.js

Is that what you mean?

However, readlink -f output confirms that everything works as expected:
 $ readlink -f /var/lib/roundcube/plugins/jqueryui/js/jquery-ui.min.js
 /usr/share/javascript/jquery-ui/jquery-ui.min.js

Do you get a 404 when accessing this file? With Apache, if I try this, I
get the file:
 $ curl http://localhost/roundcube/plugins/jqueryui/js/jquery-ui.min.js

I have:
 Alias /roundcube /var/lib/roundcube
-- 
Vincent Bernat ☯ http://vincent.bernat.im

prom_printf(Detected PenguinPages, getting out of here.\n);
2.0.38 /usr/src/linux/arch/sparc/mm/srmmu.c


pgpDJj2J5hIKo.pgp
Description: PGP signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-01-24 Thread Marc Dequènes (Duck) 

Quoting Vincent Bernat ber...@luffy.cx:

This should be the same for jquery.js. Why is it working for  
jquery.js and not jquery-ui.js?




Probably because it is under /usr/share/roundcube/program while  
jqueryui is only used by a small set of plugins. There is no such  
symlink to /var/lib for program/.


--
Marc Dequènes (Duck)


pgpRCuMeYEhKH.pgp
Description: PGP Digital Signature

Bug#656886: [Pkg-roundcube-maintainers] Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-01-24 Thread Marc Dequènes (Duck) 

Coin,

Quoting Jérémy Bobbio lu...@debian.org:


  PHP Error: Failed to load config from
  /var/lib/roundcube/plugins/jqueryui/config.inc.php in
  /usr/share/roundcube/program/include/rcube_plugin.php


I don't have such errors.


I saw this message once on a fresh install. But I am usually doing my
tests with the following in /etc/roundcube/plugins/jqueryui/config.inc.php:


Mine contains:

// if you want to load localization strings for specific sub-libraries  
of jquery-ui, configure them here

$rcmail_config['jquery_ui_i18n'] = array('datepicker');

// map Roundcube skins with jquery-ui themes here
$rcmail_config['jquery_ui_skin_map'] = array(
  'groupvice4' = 'redmond',
);


Which is in fact a copy of the default config here:  
/usr/share/roundcube/plugins/jqueryui/config.inc.php



Regards.

--
Marc Dequènes (Duck)


pgpTMlf1CRjSw.pgp
Description: PGP Digital Signature

Bug#656886: [Pkg-roundcube-maintainers] Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-01-23 Thread Jérémy Bobbio 
clone 656886 -1
reassign -1 roundcube-plugins-extra
thanks

On Sun, Jan 22, 2012 at 06:02:02PM +0100, Marc Dequènes (Duck) wrote:
 Thanks for adding the jquery plugin in the core. Nevertheless there
 is small problem with the symlinks. As /usr/share/roundcube/plugins
 is in fact /var/lib/roundcube/plugins, and the generated symlinks are
 relative, it fails to load:
 # ll /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
 lrwxrwxrwx 1 root root 49 Jan  2 21:49
 /usr/share/roundcube/plugins/jqueryui_pkg/js/jquery-ui.min.js -
 ../../../../javascript/jquery-ui/jquery-ui.min.js
 
 This problem also arise for the contextmenu plugin, and maybe others.

This also affects roundcube-plugins-extra. The symlinks of
jquery.mousewheel.js as used by contextmenu is wrong…

Cheers,
-- 
Jérémy Bobbio.''`. 
jeremy.bob...@irq7.fr   : :   : lu...@debian.org
`. `'` 
  `-


signature.asc
Description: Digital signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-01-23 Thread Vincent Bernat 

On Sun, 22 Jan 2012 18:02:02 +0100, Marc Dequènes (Duck) wrote:


Thanks for adding the jquery plugin in the core. Nevertheless there
is  small problem with the symlinks. As /usr/share/roundcube/plugins
is in  fact /var/lib/roundcube/plugins, and the generated symlinks 
are

relative, it fails to load:
# ll /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
lrwxrwxrwx 1 root root 49 Jan  2 21:49
/usr/share/roundcube/plugins/jqueryui_pkg/js/jquery-ui.min.js -
../../../../javascript/jquery-ui/jquery-ui.min.js


This should be the same for jquery.js. Why is it working for jquery.js 
and not jquery-ui.js?




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#656886: [Pkg-roundcube-maintainers] Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-01-23 Thread Jérémy Bobbio 
On Mon, Jan 23, 2012 at 06:12:05PM +0100, Vincent Bernat wrote:
 On Sun, 22 Jan 2012 18:02:02 +0100, Marc Dequènes (Duck) wrote:
 
 Thanks for adding the jquery plugin in the core. Nevertheless there
 is  small problem with the symlinks. As /usr/share/roundcube/plugins
 is in  fact /var/lib/roundcube/plugins, and the generated symlinks
 are
 relative, it fails to load:
 # ll /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
 lrwxrwxrwx 1 root root 49 Jan  2 21:49
 /usr/share/roundcube/plugins/jqueryui_pkg/js/jquery-ui.min.js -
 ../../../../javascript/jquery-ui/jquery-ui.min.js
 
 This should be the same for jquery.js. Why is it working for
 jquery.js and not jquery-ui.js?

Marc, on another thought, could you try to enable Roundcube logs and
look if you encounter something along:

  PHP Error: Failed to load config from
  /var/lib/roundcube/plugins/jqueryui/config.inc.php in
  /usr/share/roundcube/program/include/rcube_plugin.php

I saw this message once on a fresh install. But I am usually doing my
tests with the following in /etc/roundcube/plugins/jqueryui/config.inc.php:

  $rcmail_config['jquery_ui_i18n'] = array('datepicker');
  $rcmail_config['jquery_ui_skin_map'] = array('default' = 'smoothness');

And it looks like this config enables the jqueryui to work fine…

Cheers,
-- 
Jérémy Bobbio.''`. 
jeremy.bob...@irq7.fr   : :   : lu...@debian.org
`. `'` 
  `-


signature.asc
Description: Digital signature

Bug#656886: roundcube: problems with symlinks in /var/lib/roundcube/plugins/

2012-01-22 Thread Marc Dequènes (Duck) 

Source: roundcube
Version: 0.7-3

Coin,

Thanks for adding the jquery plugin in the core. Nevertheless there is  
small problem with the symlinks. As /usr/share/roundcube/plugins is in  
fact /var/lib/roundcube/plugins, and the generated symlinks are  
relative, it fails to load:

# ll /usr/share/roundcube/plugins/jqueryui/js/jquery-ui.min.js
lrwxrwxrwx 1 root root 49 Jan  2 21:49  
/usr/share/roundcube/plugins/jqueryui_pkg/js/jquery-ui.min.js -  
../../../../javascript/jquery-ui/jquery-ui.min.js


This problem also arise for the contextmenu plugin, and maybe others.

According to debian/roundcube-core.links you used absolute path to the  
/usr/share/javascript directory, but unfortunately dh_link generate  
relative paths (duuno why). I just rebuilt your package to unsure any  
local modification from before the jqueryui plugin was shipped is not  
in the way, but debc just confirm this issue.


Regards.

--
Marc Dequènes (Duck)


pgpM1FKFNnw7I.pgp
Description: PGP Digital Signature